From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-omap@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
Tony Lindgren <tony@atomide.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 4/4] mfd/tps65910: Move an assignment in tps65910_sleepinit()
Date: Tue, 16 Jan 2018 13:02:30 +0100 [thread overview]
Message-ID: <ecbcfe5a-ed61-9a8a-72ce-d495c2e59763@users.sourceforge.net> (raw)
In-Reply-To: <a524388f-a56d-c2f3-9ec3-fd6343062aad@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 16 Jan 2018 12:22:28 +0100
Move the assignment for the local variable "dev" so that its setting
will be performed after a configuration check by this function.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/mfd/tps65910.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index 7e7d3d1642c6..bf16cbe6fd88 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -315,11 +315,11 @@ static int tps65910_sleepinit(struct tps65910 *tps65910,
struct device *dev;
int ret;
- dev = tps65910->dev;
-
if (!pmic_pdata->en_dev_slp)
return 0;
+ dev = tps65910->dev;
+
/* enabling SLEEP device state */
ret = tps65910_reg_set_bits(tps65910, TPS65910_DEVCTRL,
DEVCTRL_DEV_SLP_MASK);
--
2.15.1
prev parent reply other threads:[~2018-01-16 12:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 11:57 [PATCH 0/4] mfd/tps65910: Adjustments for four function implementations SF Markus Elfring
2018-01-16 11:59 ` [PATCH 1/4] mfd/tps65910: Delete an error message for a failed memory allocation in tps65910_parse_dt() SF Markus Elfring
2018-01-16 12:00 ` [PATCH 2/4] mfd/tps65910: Delete an unnecessary variable initialisation in four functions SF Markus Elfring
2018-01-16 12:01 ` [PATCH 3/4] mfd/tps65910: Delete an unnecessary variable initialisation in tps65910_sleepinit() SF Markus Elfring
2018-01-16 12:02 ` SF Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecbcfe5a-ed61-9a8a-72ce-d495c2e59763@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).