From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: RE: [PATCH 1/5] ARM: gic: Add hooks for architecture specific extensions Date: Wed, 26 Jan 2011 13:01:44 +0530 Message-ID: References: <1295859080-15259-1-git-send-email-santosh.shilimkar@ti.com><1295859080-15259-2-git-send-email-santosh.shilimkar@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from na3sys009aog101.obsmtp.com ([74.125.149.67]:37920 "EHLO na3sys009aog101.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751383Ab1AZHbs convert rfc822-to-8bit (ORCPT ); Wed, 26 Jan 2011 02:31:48 -0500 Received: by mail-fx0-f52.google.com with SMTP id 5so789306fxm.25 for ; Tue, 25 Jan 2011 23:31:47 -0800 (PST) In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Colin Cross Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, catalin.marinas@arm.com, linux@arm.linux.org.uk, linus.ml.walleij@gmail.com, Russell King > -----Original Message----- > From: ccross@google.com [mailto:ccross@google.com] On Behalf Of > Colin Cross > Sent: Wednesday, January 26, 2011 12:54 PM > To: Santosh Shilimkar > Cc: linux-arm-kernel@lists.infradead.org; linux- > omap@vger.kernel.org; catalin.marinas@arm.com; > linux@arm.linux.org.uk; linus.ml.walleij@gmail.com; Russell King > Subject: Re: [PATCH 1/5] ARM: gic: Add hooks for architecture > specific extensions > [....] > >> > > Great. > > Can I fold below changes in my patch and add you ack and tested- > by? > > Sure After reading your initial comment, you mentioned you need to have 'gic_set_type' as well. Is this still true. If yes then we need to have arch_extn call for that as well. > > >> diff --git a/arch/arm/common/gic.c b/arch/arm/common/gic.c > >> index 0b6c043..7993f07 100644 > >> --- a/arch/arm/common/gic.c > >> +++ b/arch/arm/common/gic.c > >> @@ -90,6 +90,8 @@ static inline unsigned int gic_irq(struct > irq_data > >> *d) > >> =A0static void gic_ack_irq(struct irq_data *d) > >> =A0{ > >> =A0 =A0 =A0 spin_lock(&irq_controller_lock); > >> + =A0 =A0 if (gic_arch_extn.irq_ack) > >> + =A0 =A0 =A0 =A0 =A0 =A0 gic_arch_extn.irq_ack(d); > >> =A0 =A0 =A0 writel(gic_irq(d), gic_cpu_base(d) + GIC_CPU_EOI); > >> =A0 =A0 =A0 spin_unlock(&irq_controller_lock); > >> =A0} > >> @@ -161,6 +163,14 @@ static int gic_set_type(struct irq_data *d, > >> unsigned int type) > >> =A0 =A0 =A0 return 0; > >> =A0} > >> > >> +static int gic_retrigger(struct irq_data *d) > >> +{ > >> + =A0 =A0 if (gic_arch_extn.irq_retrigger) > >> + =A0 =A0 =A0 =A0 =A0 =A0 return gic_arch_extn.irq_retrigger(d); > >> + > >> + =A0 =A0 return 0; > >> +} > >> + > >> =A0#ifdef CONFIG_SMP > >> =A0static int > >> =A0gic_set_cpu(struct irq_data *d, const struct cpumask *mask_val, > >> bool force) > >> @@ -234,6 +244,7 @@ static struct irq_chip gic_chip =3D { > >> =A0 =A0 =A0 .irq_mask =A0 =A0 =A0 =A0 =A0 =A0 =A0 =3D gic_mask_irq= , > >> =A0 =A0 =A0 .irq_unmask =A0 =A0 =A0 =A0 =A0 =A0 =3D gic_unmask_irq= , > >> =A0 =A0 =A0 .irq_set_type =A0 =A0 =A0 =A0 =A0 =3D gic_set_type, > >> + =A0 =A0 .irq_retrigger =A0 =A0 =A0 =A0 =A0=3D gic_retrigger, > >> =A0#ifdef CONFIG_SMP > >> =A0 =A0 =A0 .irq_set_affinity =A0 =A0 =A0 =3D gic_set_cpu, > >> =A0#endif > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html