From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5812E2153FE for ; Thu, 9 Jan 2025 09:32:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736415156; cv=none; b=iW9QCWXtlqLHrxBdGW+vfALNuLSM9M7yCdNT+qOjZHPz5QMVwPEQinnto6REWsE33QIZNMVtfllbeAvr/NpVHK/V/0L0Dop9xJdiK02EjtGDIeBv7qT/eP/nX5JCND1jZw7Ziy7vhfhnYQe5WQZcBWxDAJjEabnGwalU8APtdEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736415156; c=relaxed/simple; bh=/82Bie17qmYKHBJQrNwBn4tkvCVUGCTzTY3GMsrrnAg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m8M0AX3Q7qzjV6E1tdoM4GdSJyNT7W9fliwA957xtJtYrgB3FNyIxJAXYbOXPncgMOzVrKwd0YFloe5+4RK/oBEUyE2XURMDbyLhzdbKEw5YgoLaIkaa6PscDtf2QAMsrvrlVPogANNefsvkvMpRZEp14ZXBq0ZonUpg1IbH9sw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=smile.fr; spf=pass smtp.mailfrom=smile.fr; dkim=pass (1024-bit key) header.d=smile.fr header.i=@smile.fr header.b=zpB45N8J; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=smile.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=smile.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=smile.fr header.i=@smile.fr header.b="zpB45N8J" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43626213fffso11236955e9.1 for ; Thu, 09 Jan 2025 01:32:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smile.fr; s=google; t=1736415152; x=1737019952; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZdSoGM0IN0Zxqh7qDqdJr7Z4o4Vwb6jb+542zPpHAYI=; b=zpB45N8JmCjgGfoYRQTS8Yc6M6Iv7viDC6BtueEPXJxsCSjhvIB9TWkIS8s2qG4cwU /3SSrf5HGHoKghUGfVFarxTO6c5ldIQLcXRRHloK9XJxPVeqbqU5kmNtyxus5kccQvzI LDGuqFTi4HjnVUhj0d/XKcYV8pCLryQQQElrs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736415152; x=1737019952; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZdSoGM0IN0Zxqh7qDqdJr7Z4o4Vwb6jb+542zPpHAYI=; b=T189rD1cfgQ7f6OiNDbqHipwVkCw7dbFOIE+ZMj5UjvaWMnKH3ivf96MUFJJODh28I CSlSmwEvDjth7Ern22gv829OqtjUETrNwccczr8MRatTPLzdSDBZS6jUs/V5909HiIgb UPPGbujLSBAItic8CN4rIik+3CKLmQp9BxXom+C98/Ubd9mwzQZIcoFbOzK0yU8ANj93 OpMlCsVpYyJtqzrc2oEN3tGUy8OZwfXowOeaOnS0V+W3h99uPtoizcHLNs0zRn3eYGkR vZ5CTE85EAGojtstAExWhvHGMiw1M/8TpLReXzK4ehwQJ2LFdxc5Jn3n0XbywoExZ+70 b7ng== X-Forwarded-Encrypted: i=1; AJvYcCU0zdK86kNV9zDU0xYbg9pis2L2RM12TxBdYduRe9KxYLcICRBh8GDS9Sf0pqvqXdCFp4ZcY+gkxA7t@vger.kernel.org X-Gm-Message-State: AOJu0YxRAXpUkEs/Dk5WxC4RspL/pswThlIa9/t4iJ+Ddbqnk9knU+Gl lxTqpSLfjFJhIl3IP8lKYyp5EkcALuNXsPl73WCrCPCId2X3YNbavePaSvzezhE= X-Gm-Gg: ASbGnct9LqyCvoq8l8Bo5fXCbecBI60TkkfbFM2Mf2pqN1GNeTmrb+1Lko4KW3DHipX cMxf4oy7wMU+u1w3jD0+B2Mrkwcbq53yCZg65hv1vWZeB8FoNX1ksDcX3utY0vF5pHR4dDjQ9zY XIS6k/9Zg6LrvoGFh9lwkHdGS+YKaJsxNLFP8ipb9paMRB6W7GD9fHkCs/Gc9APeGxeZeQqbppI hVuUi4djDvdhvvWSeD7oZ8dLmitF4GVNw3xrb12rLFZoWux5V+yK9WnRXQFJJebU1kY9DmJOusO djgJMGK9suOcSpMtkO8eVWxMImipU36bIOIp/n56IeLC48tB2baGijhJ7wqLLulmBY4DfOwOQOG HVQ12ojvW0vkjzL0D X-Google-Smtp-Source: AGHT+IG6EVqO91UjbtoUelxcOZNCcrgW27kDqPVuoYWnpsd+PlHziHUYVSflHCF+xbYHxYClj+IZyg== X-Received: by 2002:a05:6000:4011:b0:386:3d27:b4f0 with SMTP id ffacd0b85a97d-38a8b0d324bmr1808176f8f.14.1736415152547; Thu, 09 Jan 2025 01:32:32 -0800 (PST) Received: from ?IPV6:2a01:cb05:949d:5800:e3ef:2d7a:4131:71f? (2a01cb05949d5800e3ef2d7a4131071f.ipv6.abo.wanadoo.fr. [2a01:cb05:949d:5800:e3ef:2d7a:4131:71f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e4c1bebsm1274803f8f.95.2025.01.09.01.32.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jan 2025 01:32:32 -0800 (PST) Message-ID: Date: Thu, 9 Jan 2025 10:32:31 +0100 Precedence: bulk X-Mailing-List: linux-omap@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv3 1/2] dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible To: Siddharth Vadapalli , Andrew Davis Cc: Nishanth Menon , Kevin Hilman , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org, kristo@kernel.org, vigneshr@ti.com, Romain Naour References: <20241202143331.126800-1-romain.naour@smile.fr> <173344002250.407600.8303166891165540615.b4-ty@baylibre.com> <20250103212528.enq4ur5afxhwzh7n@outdoors> <7hr05eb5st.fsf@baylibre.com> <20250108131139.dygei6ejamh5zaij@segment> <1251db38-5009-4e93-9603-3ae02f276e5b@ti.com> Content-Language: en-US From: Romain Naour In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hello Andrew, Siddharth, All, Le 08/01/2025 à 16:46, Siddharth Vadapalli a écrit : > On Wed, Jan 08, 2025 at 09:09:37AM -0600, Andrew Davis wrote: > > Hello Andrew, > >> On 1/8/25 7:11 AM, Nishanth Menon wrote: >>> On 14:46-20250107, Kevin Hilman wrote: >>>> Nishanth Menon writes: >>>> >>>>> On 15:07-20241205, Kevin Hilman wrote: >>>>>> >>>>>> On Mon, 02 Dec 2024 15:33:30 +0100, Romain Naour wrote: >>>>>>> The ACSPCIE_PROXY_CTRL registers within the CTRL_MMR space of TI's J721e >>>>>>> SoC are used to drive the reference clock to the PCIe Endpoint device via >>>>>>> the PAD IO Buffers. Add the compatible for allowing the PCIe driver to >>>>>>> obtain the regmap for the ACSPCIE_CTRL register within the System >>>>>>> Controller device-tree node in order to enable the PAD IO Buffers. >>>>>>> >>>>>>> The Technical Reference Manual for J721e SoC with details of the >>>>>>> ASCPCIE_CTRL registers is available at: >>>>>>> https://www.ti.com/lit/zip/spruil1 >>>>>>> >>>>>>> [...] >>>>>> >>>>>> Applied, thanks! >>>>>> >>>>>> [1/2] dt-bindings: mfd: syscon: Add ti,j721e-acspcie-proxy-ctrl compatible >>>>>> commit: d8efc0b428856137608ffcbb6994da6041c9fe2a >>>>>> [2/2] arm64: dts: ti: k3-j721e-beagleboneai64: Enable ACSPCIE output for PCIe1 >>>>>> commit: 1d5e14a20dc60b440c60bec8489acfd45cdf7508 >>>>>> >>>>>> Best regards, >>>>>> -- >>>>>> Kevin Hilman >>>>>> >>>>> This will need a bit of fixup - See along the lines of the following. >>>>> Additionally, we should be a bit careful about the dependency of dts >>>>> mix up from two trees. >>>> >>>> sorry, these should be going through your tree in the first place. They >>>> are now dropped from my tree, please go ahead and take them along with >>>> Andrews fixup. Sorry for complicating things. >>> >>> >>> Romain, >>> >>> There is additional fixups needed, unfortunately as well: syscon yaml >>> has two lists based on which dt-schema version you use.. your patch >>> fixed one list, but missed the other as well. Could you integrate the >>> fixes and resubmit, please? >>> >>> >> >> Or since we already have 'ti,j784s4-acspcie-proxy-ctrl' for the same >> reason, you could drop the first patch and re-use this compatible. > > I had suggested this in the past since the ACSPCIE IP on J784S4 and J721E > is the same, but Krzysztof insists that there will be hardware differences > in the ACSPCIE block across J784S4 and J721E irrespective of what the > datasheet says, as mentioned by Krzysztof at: > https://lore.kernel.org/r/1bfdf1f1-7542-4149-a85d-2ac4b659b26b@kernel.org/ > Therefore Romain had to introduce a new compatible for J721E. There is a pending patch series from Andrew [1] fixing ti,j784s4-acspcie-proxy-ctrl compatible for the same reason. Should I take it into account before resubmit? [1] https://lore.kernel.org/linux-devicetree/20250103174524.28768-1-afd@ti.com/ Best regards, Romain > > Regards, > Siddharth.