From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCHv5 4/6] drm/omap: fix incorrect union usage Date: Mon, 26 Nov 2018 11:32:08 +0200 Message-ID: References: <20181121160916.22017-1-sebastian.reichel@collabora.com> <20181121160916.22017-5-sebastian.reichel@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181121160916.22017-5-sebastian.reichel@collabora.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sebastian Reichel , Sebastian Reichel , Tony Lindgren , Pavel Machek , Laurent Pinchart Cc: "H. Nikolaus Schaller" , linux-omap@vger.kernel.org, kernel@collabora.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: linux-omap@vger.kernel.org T24gMjEvMTEvMTggMTg6MDksIFNlYmFzdGlhbiBSZWljaGVsIHdyb3RlOgo+IFRoZSBEU0kgZW5j b2RlciBzZXRzIGRzc2Rldi0+b3BzLT5kc2kuc2V0X2NvbmZpZywgd2hpY2ggaXMgc3RvcmVkIGF0 IHRoZQo+IHNhbWUgb2Zmc2V0IGFzIGRzc2Rldi0+b3BzLT5oZG1pLnNldF9oZG1pX21vZGUuIFRo ZSBjb2RlIGluIG9tYXBfZW5jb2Rlcgo+IG9ubHkgY2hlY2tzIGlmIGRzc2Rldi0+b3BzLT5oZG1p LnNldF9oZG1pX21vZGUgaXMgTlVMTC4gRHVlIHRvIHRoZSB3YXkKPiB1bmlvbiB3b3JrcywgaXQg d29uJ3QgYmUgTlVMTCBpZiBkc2kuc2V0X2NvbmZpZyBpcyBzZXQuIFRoaXMgbWVhbnMKPiBkc2lf c2V0X2NvbmZpZyB3aWxsIGJlIGNhbGxlZCB3aXRoIGNvbmZpZz1oZG1pX21vZGU9ZmFsc2U9TlVM TCBwYXJhbWV0ZXIKPiByZXN1bHRpbmcgaW4gYSBOVUxMIGRlcmVmZXJlbmNlLiBBbHNvIHRoZSBk ZXJlZmVyZW5jZSBoYXBwZW5zIHdoaWxlCj4gY29uc29sZSBpcyBsb2NrZWQsIHNvIGtlcm5lbCBo YW5ncyB3aXRob3V0IGFueSBkZWJ1ZyBvdXRwdXQgd2l0aG91dAo+ICJmYi5sb2NrbGVzc19yZWdp c3Rlcl9mYj0xIiBwYXJhbWV0ZXIuCj4gCj4gVGhpcyByZXN0cnVjdHVyZXMgdGhlIGNvZGUsIHNv IHRoYXQgdGhlIEhETUkgbW9kZSBpcyBvbmx5IGNvbmZpZ3VyZWQKPiBmb3IgSERNSSBvdXRwdXQg dHlwZXMuIFRoZSBuZXcgZnVuY3Rpb24gYWxzbyBoYXMgYSBzYWZlLWd1YXJkIGRpcmVjdGx5Cj4g YmVmb3JlIGFjY2Vzc2luZyB0aGUgdW5pb24sIHRoYXQgY2FuIGJlIG9wdGltaXplZCBhd2F5IGJ5 IHRoZSBjb21waWxlcgo+IHdoZW4gdGhlIGZ1bmN0aW9uIGlzIGlubGluZWQgYW5kIEhETUkgdHlw ZSBoYXMgYWxyZWFkeSBiZWVuIGNoZWNrZWQuCj4gCj4gRml4ZXM6IDgzOTEwYWQzZjUxZmIgKCJk cm0vb21hcDogTW92ZSBtb3N0IG9tYXBfZHNzX2RyaXZlciBvcGVyYXRpb25zIHRvIG9tYXBfZHNz X2RldmljZV9vcHMiKQo+IFNpZ25lZC1vZmYtYnk6IFNlYmFzdGlhbiBSZWljaGVsIDxzZWJhc3Rp YW4ucmVpY2hlbEBjb2xsYWJvcmEuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vb21hcGRy bS9vbWFwX2VuY29kZXIuYyB8IDYyICsrKysrKysrKysrKysrKy0tLS0tLS0tLS0tCj4gIDEgZmls ZSBjaGFuZ2VkLCAzNyBpbnNlcnRpb25zKCspLCAyNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9lbmNvZGVyLmMgYi9kcml2ZXJzL2dw dS9kcm0vb21hcGRybS9vbWFwX2VuY29kZXIuYwo+IGluZGV4IDMyYmJlM2E4MGU3ZC4uZjM1Njgy MWNkMDc4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfZW5jb2Rl ci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9lbmNvZGVyLmMKPiBAQCAt NTIsMTcgKzUyLDQ4IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX2VuY29kZXJfZnVuY3Mgb21h cF9lbmNvZGVyX2Z1bmNzID0gewo+ICAJLmRlc3Ryb3kgPSBvbWFwX2VuY29kZXJfZGVzdHJveSwK PiAgfTsKPiAgCj4gK3N0YXRpYyB2b2lkIG9tYXBfZW5jb2Rlcl9oZG1pX21vZGVfc2V0KHN0cnVj dCBkcm1fZW5jb2RlciAqZW5jb2RlciwKPiArCQkJCSAgICAgICBzdHJ1Y3QgZHJtX2Rpc3BsYXlf bW9kZSAqYWRqdXN0ZWRfbW9kZSkKPiArewo+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGVu Y29kZXItPmRldjsKPiArCXN0cnVjdCBvbWFwX2VuY29kZXIgKm9tYXBfZW5jb2RlciA9IHRvX29t YXBfZW5jb2RlcihlbmNvZGVyKTsKPiArCXN0cnVjdCBvbWFwX2Rzc19kZXZpY2UgKmRzc2RldiA9 IG9tYXBfZW5jb2Rlci0+b3V0cHV0Owo+ICsJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3Rv cjsKPiArCWJvb2wgaGRtaV9tb2RlOwo+ICsKPiArCWhkbWlfbW9kZSA9IGZhbHNlOwo+ICsJbGlz dF9mb3JfZWFjaF9lbnRyeShjb25uZWN0b3IsICZkZXYtPm1vZGVfY29uZmlnLmNvbm5lY3Rvcl9s aXN0LCBoZWFkKSB7Cj4gKwkJaWYgKGNvbm5lY3Rvci0+ZW5jb2RlciA9PSBlbmNvZGVyKSB7Cj4g KwkJCWhkbWlfbW9kZSA9IG9tYXBfY29ubmVjdG9yX2dldF9oZG1pX21vZGUoY29ubmVjdG9yKTsK PiArCQkJYnJlYWs7Cj4gKwkJfQo+ICsJfQo+ICsKPiArCS8qIHNhZmUtZ3VhcmQgZm9yIGFjY2Vz c2luZyBkc3NkZXYtPm9wcy0+aGRtaSB1bmlvbiAqLwo+ICsJaWYgKGRzc2Rldi0+b3V0cHV0X3R5 cGUgIT0gT01BUF9ESVNQTEFZX1RZUEVfSERNSSkKPiArCQlyZXR1cm47CgpJZiB5b3Ugc2FmZWd1 YXJkIHRoZSBmdW5jdGlvbiwgaXQgd291bGQgbWFrZSBzZW5zZSB0byBkbyB0aGlzIGF0IHRoZQp2 ZXJ5IGJlZ2lubmluZyBvZiB0aGUgZnVuY3Rpb24uIEJ1dCB0byBiZSBob25lc3QsIEkgdGhpbmsg dGhpcyBpcyBqdXN0CmV4dHJhLiBJdCdzIGEgc3RhdGljIGZ1bmN0aW9uLCBuYW1lZCAiaGRtaSIs IHNvIEkgdGhpbmsgd2UgY2FuIHRydXN0CnRoYXQgd2UgY2FsbCBpdCBjb3JyZWN0bHkuCgpJZiB5 b3UncmUgb2sgd2l0aCBpdCwgSSBjYW4gcGljayB0aGlzIHBhdGNoIHVwIGFuZCBkcm9wIHRoZSBz YWZlZ3VhcmQuCk9yIHlvdSBjYW4gc2VuZCBhIG5ldyBvbmUuCgogVG9taQoKLS0gClRleGFzIElu c3RydW1lbnRzIEZpbmxhbmQgT3ksIFBvcmtrYWxhbmthdHUgMjIsIDAwMTgwIEhlbHNpbmtpLgpZ LXR1bm51cy9CdXNpbmVzcyBJRDogMDYxNTUyMS00LiBLb3RpcGFpa2thL0RvbWljaWxlOiBIZWxz aW5raQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK