From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH v3 2/4] asm-generic: Provide a fncpy() implementation Date: Mon, 19 Jun 2017 10:27:33 -0700 Message-ID: References: <20170617000744.22158-1-f.fainelli@gmail.com> <20170617000744.22158-3-f.fainelli@gmail.com> <20170618235108.peaxdi367jpkt542@yury-thinkpad> <20170619151818.pvjygbdvm6arvarq@yury-thinkpad> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170619151818.pvjygbdvm6arvarq@yury-thinkpad> Content-Language: en-US Sender: linux-arch-owner@vger.kernel.org To: Yury Norov , Florian Fainelli Cc: "open list:GENERIC INCLUDE/ASM HEADER FILES" , Keerthy J , Arnd Bergmann , Dave Gerlach , Tony Lindgren , Catalin Marinas , Will Deacon , Russell King , open list , bcm-kernel-feedback-list@broadcom.com, Greg Kroah-Hartman , Alexandre Belloni , linux-omap@vger.kernel.org, Shawn Guo , linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org On 06/19/2017 08:18 AM, Yury Norov wrote: > On Mon, Jun 19, 2017 at 02:51:08AM +0300, Yury Norov wrote: >> Hi Florian, >> >> Some questions and thoughts inline. >> >> Yury >> >> On Fri, Jun 16, 2017 at 05:07:42PM -0700, Florian Fainelli wrote: >>> Define a generic fncpy() implementation largely based on the ARM version >>> that requires an 8 bytes alignment for the destination address where to >>> copy this function as well as the function's own address. >>> >>> Signed-off-by: Florian Fainelli >>> --- >>> include/asm-generic/fncpy.h | 93 +++++++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 93 insertions(+) >>> create mode 100644 include/asm-generic/fncpy.h > > One else thing I forgot to ask - now you have the generic > implementation for fncpy(), so do you really need to save arm > version of it? Yes, it needs to deal with the Thumb bit, and there is no point in making the generic implementation extremely flexible to support that special case. Thanks -- Florian