From: "andrzej zaborowski" <balrog@zabor.org>
To: lamikr@cc.jyu.fi
Cc: Linux-OMAP <linux-omap-open-source@linux.omap.com>
Subject: Re: [PATCH] OMAP audio DMA changes for 310 CPUs
Date: Sat, 19 Aug 2006 02:12:03 +0200 [thread overview]
Message-ID: <fb249edb0608181712x4e5aedb2oce6946c2912bb811@mail.gmail.com> (raw)
In-Reply-To: <44E5F3CE.3010501@cc.jyu.fi>
Hi,
On 18/08/06, lamikr <lamikr@cc.jyu.fi> wrote:
> Hi andrzej
>
> I have couple of questions from your patch.
> Your patch has couple of these changes where cpu_is_omap1510() has been
> changed to cpu_is_omap15xx().
> - if (!cpu_is_omap1510())
> + if (!cpu_is_omap15xx())
>
> Do they affect to the sound in omap 310? (I mean is cpu_is_omap15xx()
> true for your omap310)
Yes, from what I've seen cpu_is_omap15xx() is always cpu_is_omap1510()
|| cpu_is_omap310() and it makes sense because the processors are
mostly compatible (with little exceptions). Similarly
CONFIG_ARCH_OMAP15XX.
> Or is following the only relevant omap310 specific change
>
> + } else if (cpu_is_omap310())
> + omap_start_dma(channel);
>
> Btw, your patch will not apply on top of all 5 patches I sent.
Oops. I will resend. (but can't do it now)
> Could you perhaps re-send it one more time? (I need also test whether
> your changes could work with omap1510/h6300)
They shouldn't affect omap1510.
>
> Mika
>
> andrzej zaborowski wrote:
> > Avoid restarting McBSP hardware after every DMA transfer to OMAP audio
> > devices on OMAP310, restart only DMA. Also avoid trying to link DMA
> > channels together as this feature isn't supported on 310 processors.
> > Apply on top of "[PATCH 1/5] Change all omap15xx devices to use
> > similar DMA handling than h6300 uses".
> >
> > Signed-off-by: Andrzej Zaborowski <balrog@zabor.org>
> > ------------------------------------------------------------------------
> >
> > _______________________________________________
> > Linux-omap-open-source mailing list
> > Linux-omap-open-source@linux.omap.com
> > http://linux.omap.com/mailman/listinfo/linux-omap-open-source
> >
>
>
--
balrog 2oo6
Dear Outlook users: Please remove me from your address books
http://www.newsforge.com/article.pl?sid=03/08/21/143258
next prev parent reply other threads:[~2006-08-19 0:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-18 8:20 [PATCH] OMAP audio DMA changes for 310 CPUs andrzej zaborowski
2006-08-18 17:07 ` lamikr
2006-08-19 0:12 ` andrzej zaborowski [this message]
2006-09-12 9:53 ` andrzej zaborowski
2006-09-12 12:05 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb249edb0608181712x4e5aedb2oce6946c2912bb811@mail.gmail.com \
--to=balrog@zabor.org \
--cc=balrogg@gmail.com \
--cc=lamikr@cc.jyu.fi \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox