From: "andrzej zaborowski" <balrogg@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Linux OMAP <linux-omap-open-source@linux.omap.com>
Subject: Re: [PATCH] ARM: OMAP: Fix omap1510-generic board compilation.
Date: Sun, 10 Jun 2007 13:52:57 +0200 [thread overview]
Message-ID: <fb249edb0706100452i479dcfft3ba050dfade880ff@mail.gmail.com> (raw)
In-Reply-To: <20070608103126.GM28556@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 671 bytes --]
On 08/06/07, Tony Lindgren <tony@atomide.com> wrote:
> * andrzej zaborowski <balrogg@gmail.com> [070606 19:46]:
> > Move an #endif so that it doesn't hide the mmc config declaration.
> > Minor formatting change.
> >
> > Signed-off-by: Andrzej Zaborowski <balrog@zabor.org>
>
[...]
> This one does not seem to apply, did you forget to send your patch
> 0006 that this depends on?
Sorry, forgot to update my tree before diffing. Attached is a version
that applies. Sorry for the noise.
0006 was the collective defconfig update which doesn't seem to have
made it to everyone's mailboxes because it was 200+ KB. Will resend
the update separated per board.
Cheers,
Andrzej
[-- Attachment #2: 0015-ARM-OMAP-Fix-omap1510-generic-board-compilation.txt --]
[-- Type: text/plain, Size: 1356 bytes --]
From 5a51d9d3480d9d6b1efe4e6dbf9c1efc75d75cad Mon Sep 17 00:00:00 2001
From: Andrzej Zaborowski <balrog@zabor.org>
Date: Sun, 10 Jun 2007 14:36:34 +0200
Subject: [PATCH] ARM: OMAP: Fix omap1510-generic board compilation
Move an #endif so that it doesn't hide the mmc config declaration.
Minor formatting change.
---
arch/arm/mach-omap1/board-generic.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-omap1/board-generic.c b/arch/arm/mach-omap1/board-generic.c
index 228fd00..4b35f16 100644
--- a/arch/arm/mach-omap1/board-generic.c
+++ b/arch/arm/mach-omap1/board-generic.c
@@ -55,6 +55,7 @@ static struct omap_usb_config generic1610_usb_config __initdata = {
.hmc_mode = 16,
.pins[0] = 6,
};
+#endif
static struct omap_mmc_config generic_mmc_config __initdata = {
.mmc [0] = {
@@ -73,15 +74,13 @@ static struct omap_mmc_config generic_mmc_config __initdata = {
},
};
-#endif
-
static struct omap_uart_config generic_uart_config __initdata = {
.enabled_uarts = ((1 << 0) | (1 << 1) | (1 << 2)),
};
static struct omap_board_config_kernel generic_config[] __initdata = {
- { OMAP_TAG_USB, NULL },
- { OMAP_TAG_MMC, &generic_mmc_config },
+ { OMAP_TAG_USB, NULL },
+ { OMAP_TAG_MMC, &generic_mmc_config },
{ OMAP_TAG_UART, &generic_uart_config },
};
--
1.4.4.3
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2007-06-10 11:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-07 2:45 [PATCH] ARM: OMAP: Fix omap1510-generic board compilation andrzej zaborowski
2007-06-08 10:31 ` Tony Lindgren
2007-06-10 11:52 ` andrzej zaborowski [this message]
2007-06-12 18:32 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb249edb0706100452i479dcfft3ba050dfade880ff@mail.gmail.com \
--to=balrogg@gmail.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox