From: Roger Quadros <rogerq@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, krzk@kernel.org
Cc: linux-omap@vger.kernel.org, nm@ti.com,
linux-kernel@vger.kernel.org, kishon@ti.com, tony@atomide.com,
miquel.raynal@bootlin.com, vigneshr@ti.com
Subject: Re: [PATCH v3 0/2] memory: omap-gpmc: Allow module build
Date: Wed, 13 Apr 2022 14:33:23 +0300 [thread overview]
Message-ID: <fdafb49b-9349-087b-f483-4da888193683@kernel.org> (raw)
In-Reply-To: <68d16fbb-4250-73bd-b55e-a14db91abe8f@linaro.org>
On 13/04/2022 14:05, Krzysztof Kozlowski wrote:
> On 13/04/2022 13:01, Roger Quadros wrote:
>>> https://krzk.eu/#/builders/63/builds/162
>>>
>>>
>>>> config OMAP_GPMC
>>>> - bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
>>>> - depends on OF_ADDRESS
>>>> + bool "Texas Instruments OMAP SoC GPMC driver"
>>>> + depends on OF_ADDRESS || COMPILE_TEST
>>
>>
>> Looks like include/linux/irqdomain.h does not have fallbacks if
>> CONFIG_IRQ_DOMAIN is not enabled.
>>
>> I'll have to drop COMPILE_TEST and add depends on IRQ_DOMAIN.
>> Is that OK?
>
> Previously it was building with COMPILE_TEST on sparc, so what else changed?
>
Previously it was like so
bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
depends on OF_ADDRESS
Means it won't build if OF_ADDRESS is not set even if COMPILE_TEST is set.
And OF_ADDRESS is not set for sparc
config OF_ADDRESS
def_bool y
depends on !SPARC && (HAS_IOMEM || UML)
cheers,
-roger
next prev parent reply other threads:[~2022-04-13 11:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 9:55 [PATCH v3 0/2] memory: omap-gpmc: Allow module build Roger Quadros
2022-04-11 9:55 ` [PATCH v3 1/2] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable Roger Quadros
2022-04-11 10:06 ` Miquel Raynal
2022-04-11 9:55 ` [PATCH v3 2/2] memory: omap-gpmc: Allow building as a module Roger Quadros
2022-04-13 9:43 ` [PATCH v3 0/2] memory: omap-gpmc: Allow module build Krzysztof Kozlowski
2022-04-13 9:50 ` Krzysztof Kozlowski
2022-04-13 10:20 ` Krzysztof Kozlowski
2022-04-13 10:42 ` Roger Quadros
2022-04-13 11:01 ` Roger Quadros
2022-04-13 11:05 ` Krzysztof Kozlowski
2022-04-13 11:33 ` Roger Quadros [this message]
2022-04-13 11:47 ` Krzysztof Kozlowski
2022-04-13 11:56 ` Roger Quadros
2022-04-13 12:31 ` Krzysztof Kozlowski
2022-04-13 12:56 ` Roger Quadros
2022-04-13 13:00 ` Krzysztof Kozlowski
2022-04-13 13:04 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdafb49b-9349-087b-f483-4da888193683@kernel.org \
--to=rogerq@kernel.org \
--cc=kishon@ti.com \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=nm@ti.com \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox