Re: [PATCH 11/19] omap3+: sr: call handler with interrupt disabled

Kevin Hilman
2011-03-03T00:11:05Z

Nishanth Menon <nm@ti.com> writes:

> Request the handler irq such that there is no nesting for calls.
> the notifiers are not expected to be nested, further the interrupt
> events for status change should be handled prior to the next event
> else there is a risk of loosing events.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>

IRQs disabled interrupt handlers are soon to disappear in the kernel.

This kind of thing should be handled using locking, most likely IRQs
disabled spinlocks.

Kevin

> ---
> arch/arm/mach-omap2/smartreflex.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
> index 1fe8b95..7931fcd 100644
> --- a/arch/arm/mach-omap2/smartreflex.c
> +++ b/arch/arm/mach-omap2/smartreflex.c
> @@ -278,7 +278,7 @@ static int sr_late_init(struct omap_sr *sr_info)
> goto error;
> }
> ret = request_irq(sr_info->irq, sr_interrupt,
> - 0, name, (void *)sr_info);
> + IRQF_DISABLED, name, (void *)sr_info);
> if (ret)
> goto error;
> }