Re: [RFC PATCH 0/1] Categorize ARM dts directory

Jonathan Neuschäfer
2022-03-28T13:35:54Z

[-- Attachment #1: Type: text/plain, Size: 1776 bytes --]

On Mon, Mar 28, 2022 at 03:27:13PM +0200, Ansuel Smith wrote:
> On Mon, Mar 28, 2022 at 03:21:08PM +0200, Jonathan Neuschäfer wrote:
> > On Mon, Mar 28, 2022 at 02:09:14AM +0200, Ansuel Smith wrote:
> > > Hi,
> > > as the title say, the intention of this ""series"" is to finally categorize
> > > the ARM dts directory in subdirectory for each oem.
> > [...]
> > > [1] https://gist.github.com/Ansuel/47c49925ee7ef4b1dd035afc74679ab5
> > > [2] https://gist.github.com/Ansuel/19f61f1e583c49407ce35c10e770fbe0
> >
> > Nice idea, thank you!
> >
> > A few notes on categorization below.
> >
> >
> > > create mode 100644 arch/arm/boot/dts/broadcom/Makefile
> > > rename arch/arm/boot/dts/{ => broadcom}/bcm-cygnus-clock.dtsi (100%)
> >
> > Or maybe bcm instead of broadcom. Not sure which is preferred by
> > Broadcom people.
> >
>
> In arm64 they used broadcom so i assume the full name looks correct.

Alright.

[...]
> > > create mode 120000 arch/arm/boot/dts/nxp/armv7-m.dtsi
> >
> > armv7-m.dtsi is a bit confusing, because it contains a few devices at
> > fixed addresses, so it looks vendor-specific at a first glance into the
> > file. However, if it is actually as vendor-neutral as the name implies,
> > I think it should live dts/ directly, rather than in vendor
> > subdirectories.
> >
>
> Considering it's really just 3 binding IMHO it should be just dropped
> and merged in other dtsi... But lets not extend this too much.
> This is really just a simplic link and armv7-m.dtsi is placed in dts/
> I create links in each oem that includes it to skip any changes to the
> dts.

Ah, I missed the link bit (hidden in the file permissions) :)
I agree, this is something that can be cleaned up later.

Jonathan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]