From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90567C76195 for ; Sun, 19 Mar 2023 18:07:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229747AbjCSSHb (ORCPT ); Sun, 19 Mar 2023 14:07:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbjCSSHa (ORCPT ); Sun, 19 Mar 2023 14:07:30 -0400 Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CA2813D53; Sun, 19 Mar 2023 11:07:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1679249099; i=deller@gmx.de; bh=+sWpEtXEvBr7yZDavGqNS6S62MukCM3hdjT7cESk55Q=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=UUGIovN46vt9TgOdaPgAvLvsLSNXOET7MXkLaaRiQZoG7Q506S7I8Vc5V6oCTi/5T deMNYyxgum71BuCjzjRw7RnfeZcBsKM5h8tMgnYVM9JKLwaDjg0ndHEbtehVU0pTRI MaslDy8EvaxvwfZ52Kun2imXulEPJXdErE7ZAyiBO5v3xW89xl3JsA2FHJt5X8O9U5 iiyWY6vmyrNEifqrQulry+kmKhyxOZCOFKxf9ZDdRTzdDIbJVxOH2eA08I0om0Asf0 szyCRz492e7ipC8swK1EJQfQ/iK6dJwlYELPXWwJ6jWliK1RY+XqR2n3zQTDrGlhPG JESt+H1fYlXhw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.20.60] ([94.134.150.189]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M9FnZ-1pXe0q0Vlv-006Kfn; Sun, 19 Mar 2023 19:04:59 +0100 Message-ID: Date: Sun, 19 Mar 2023 19:04:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 00/51] video: fbdev: Convert to platform remove callback returning void Content-Language: en-US To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Yihao Han , Javier Martinez Canillas , Thomas Zimmermann , Wolfram Sang , Alexander Shiyan , Dongliang Mu , Peter Jones , Gaosheng Cui , Timur Tabi , Xuezhi Zhang , Jiasheng Jiang , Ferenc Bakonyi , Sascha Hauer , Shawn Guo , Christophe Leroy , Stephen Kitt , Daniel Thompson , Mark Brown , Rob Herring , Bartlomiej Zolnierkiewicz , Arnd Bergmann , Tony Lindgren , Jiapeng Chong , Yu Zhe , Xu Panda , Zhang Qilong , Hyunwoo Kim , Yang Yingliang , Robert Jarzmik , Ulf Hansson , Wang Qing , Kristoffer Ericson , Jingoo Han , ye xingchen , Geert Uytterhoeven , Hans de Goede , Michal Januszewski , Daniel Vetter , Zeng Heng , Florian Tobias Schandinat , Michal Simek Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-nvidia@lists.surfsouth.com, Fabio Estevam , NXP Linux Team , linux-omap@vger.kernel.org References: <20230318235428.272091-1-u.kleine-koenig@pengutronix.de> From: Helge Deller In-Reply-To: <20230318235428.272091-1-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:S2Ob7Sb22mthOOeU6dil7PPjXBXP9Hc8SZkdR1IZ5YCor0QNNFb Nu8bRxHYLdivGl543yZgVLjUO58xBIYN0conq25vCzSEC8mZWr4KXgtfaYYqINDp7ht6hln oyJY47PaY6kDjKy8yO2b5EYKalvWq5EBLuxOIHH4cwAw/Aw4CEdwysVvnaH+XUO6xEkmzdu VwP+Wjc+VUJf+RLcDxySA== UI-OutboundReport: notjunk:1;M01:P0:3Bo1vY26v6w=;g0HelX/LmA1pdWkRqXNjNqFLTng I4hZSJeZsVg4w7L5suher9lzLDHD84hlh0YXowt6Vcuzj14y93KZHlHgngpKGI6SEWfEblTYQ rUEiiIFGN4axL1VjQcGrJuWleRolM6n/OCYb/sWzqhg5W9uaAlOAEjsLPV8tJuiXOHhO3DB7x 0zbZTKK4c1mzda0SesYh4ENrWu7silOSbJ9YaQzE0ttuJlmasM0exEL3Ne50wDac1zyJ4L5DF xGEmVUX65UqFRcSvdqs0Ob6l8RP9TJNjBcBBZXbioVyhG8x7yQNCLGMpCZnxQ/SS3sHIAq1dU E0tBTVwiMERPVTqPEyxYsWi3Rm68QBP7j88pu2/QrIUPb1SGYzbMRpbU1Ootc3oV4DdboU8BV yy4HSljKkNtUvQxo70AG3SUdvXGI1iulwzy8lIuqCiCIx/xwDG4QRwczmqDEyMW3tXhxSeRQ4 q7FBFipr+49dOASUvsVpB319tGq4QjySeRSQREItbHTU7s01FaZ5CiGf40KeTfQctpM93M/of mNZ44MfEvd9eeeffV9mJe0X6Gs2UIFojaCDYbNce3WKxc3FWYk0tRFJeEINvvWddB4kAAeBiB Wl9zNAuxvdRqljryGRqqcGmGdrlv+sMnQ+BuW+HR7CNWOJd2Dt9WoAcYmZLbT6HMrRsIYMPi4 jV/CGERNXNkC/7ntJdBgeAOS6oJiByNbssoTa3kU28fQH+pMXWFMn3omTiusI7zOLFzm3nEEr 7zw7Lr7mwPStqplU68n02z8s2SZgOCGCIFkHWteAAgGWJHs3pW1IdsUl2mAVqdDaTxjdyNbXB mpy3h0ov6YLbD59NRHaFcZBhseokVh0MFyYy0TSLQ/MXOxWkb5JEuMu4hVYseDI8CSLoMYeh6 Z+LMqX8pRf1a4YcVhg7ncYNUVscKAA4PvugjkDnBp5pOQee3aNTj+fZGO0IGQ6VEAvdEqj/m8 Tf3KE4zBBR0NI9B6aeEGjWe1Icw= Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hello Uwe, On 3/19/23 00:53, Uwe Kleine-K=C3=B6nig wrote: > this series adapts the platform drivers below drivers/video/fbdev to use= the > .remove_new() callback. Compared to the traditional .remove() callback > .remove_new() returns no value. This is a good thing because the driver = core > doesn't (and cannot) cope for errors during remove. The only effect of a > non-zero return value in .remove() is that the driver core emits a warni= ng. The > device is removed anyhow and an early return from .remove() usually yiel= ds a > resource leak. > > By changing the remove callback to return void driver authors cannot > reasonably assume any more that there is some kind of cleanup later. > > The first patch simplifies the remove callback of one driver to obviousl= y > always return zero. After that all drivers are converted trivially to > .remove_new(). Thanks for that patch series. It's a nice cleanup. I've applied it to the fbdev "for-next" git tree for now to get some compi= le testing. I hope that's ok for you. Regarding the new "remove_new" struct member I'd prefer a better name but = don't have any idea yet... Helge > > Best regards > Uwe > > Uwe Kleine-K=C3=B6nig (51): > video: fbdev: au1100fb: Drop if with an always false condition > video: fbdev: arcfb: Convert to platform remove callback returning > void > video: fbdev: au1100fb: Convert to platform remove callback returning > void > video: fbdev: au1200fb: Convert to platform remove callback returning > void > video: fbdev: broadsheetfb: Convert to platform remove callback > returning void > video: fbdev: bw2: Convert to platform remove callback returning void > video: fbdev: cg14: Convert to platform remove callback returning voi= d > video: fbdev: cg3: Convert to platform remove callback returning void > video: fbdev: cg6: Convert to platform remove callback returning void > video: fbdev: clps711x-fb: Convert to platform remove callback > returning void > video: fbdev: cobalt_lcdfb: Convert to platform remove callback > returning void > video: fbdev: da8xx-fb: Convert to platform remove callback returning > void > video: fbdev: efifb: Convert to platform remove callback returning > void > video: fbdev: ep93xx-fb: Convert to platform remove callback returnin= g > void > video: fbdev: ffb: Convert to platform remove callback returning void > video: fbdev: fsl-diu-fb: Convert to platform remove callback > returning void > video: fbdev: gbefb: Convert to platform remove callback returning > void > video: fbdev: goldfishfb: Convert to platform remove callback > returning void > video: fbdev: grvga: Convert to platform remove callback returning > void > video: fbdev: hecubafb: Convert to platform remove callback returning > void > video: fbdev: hgafb: Convert to platform remove callback returning > void > video: fbdev: hitfb: Convert to platform remove callback returning > void > video: fbdev: imxfb: Convert to platform remove callback returning > void > video: fbdev: leo: Convert to platform remove callback returning void > video: fbdev: mb862xx: Convert to platform remove callback returning > void > video: fbdev: metronomefb: Convert to platform remove callback > returning void > video: fbdev: mx3fb: Convert to platform remove callback returning > void > video: fbdev: ocfb: Convert to platform remove callback returning voi= d > video: fbdev: offb: Convert to platform remove callback returning voi= d > video: fbdev: omapfb: Convert to platform remove callback returning > void > video: fbdev: p9100: Convert to platform remove callback returning > void > video: fbdev: platinumfb: Convert to platform remove callback > returning void > video: fbdev: pxa168fb: Convert to platform remove callback returning > void > video: fbdev: pxa3xx-gcu: Convert to platform remove callback > returning void > video: fbdev: pxafb: Convert to platform remove callback returning > void > video: fbdev: s1d13xxxfb: Convert to platform remove callback > returning void > video: fbdev: s3c-fb: Convert to platform remove callback returning > void > video: fbdev: sh7760fb: Convert to platform remove callback returning > void > video: fbdev: sh_mobile_lcdcfb: Convert to platform remove callback > returning void > video: fbdev: simplefb: Convert to platform remove callback returning > void > video: fbdev: sm501fb: Convert to platform remove callback returning > void > video: fbdev: tcx: Convert to platform remove callback returning void > video: fbdev: uvesafb: Convert to platform remove callback returning > void > video: fbdev: vesafb: Convert to platform remove callback returning > void > video: fbdev: vfb: Convert to platform remove callback returning void > video: fbdev: vga16fb: Convert to platform remove callback returning > void > video: fbdev: via: Convert to platform remove callback returning void > video: fbdev: vt8500lcdfb: Convert to platform remove callback > returning void > video: fbdev: wm8505fb: Convert to platform remove callback returning > void > video: fbdev: wmt_ge_rops: Convert to platform remove callback > returning void > video: fbdev: xilinxfb: Convert to platform remove callback returning > void > > drivers/video/fbdev/arcfb.c | 5 ++--- > drivers/video/fbdev/au1100fb.c | 11 +++-------- > drivers/video/fbdev/au1200fb.c | 6 ++---- > drivers/video/fbdev/broadsheetfb.c | 5 ++--- > drivers/video/fbdev/bw2.c | 6 ++---- > drivers/video/fbdev/cg14.c | 6 ++---- > drivers/video/fbdev/cg3.c | 6 ++---- > drivers/video/fbdev/cg6.c | 6 ++---- > drivers/video/fbdev/clps711x-fb.c | 6 ++---- > drivers/video/fbdev/cobalt_lcdfb.c | 6 ++---- > drivers/video/fbdev/da8xx-fb.c | 6 ++---- > drivers/video/fbdev/efifb.c | 6 ++---- > drivers/video/fbdev/ep93xx-fb.c | 6 ++---- > drivers/video/fbdev/ffb.c | 6 ++---- > drivers/video/fbdev/fsl-diu-fb.c | 6 ++---- > drivers/video/fbdev/gbefb.c | 6 ++---- > drivers/video/fbdev/goldfishfb.c | 5 ++--- > drivers/video/fbdev/grvga.c | 6 ++---- > drivers/video/fbdev/hecubafb.c | 5 ++--- > drivers/video/fbdev/hgafb.c | 6 ++---- > drivers/video/fbdev/hitfb.c | 6 ++---- > drivers/video/fbdev/imxfb.c | 6 ++---- > drivers/video/fbdev/leo.c | 6 ++---- > drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 5 ++--- > drivers/video/fbdev/metronomefb.c | 5 ++--- > drivers/video/fbdev/mx3fb.c | 5 ++--- > drivers/video/fbdev/ocfb.c | 6 ++---- > drivers/video/fbdev/offb.c | 8 +++----- > drivers/video/fbdev/omap/omapfb_main.c | 6 ++---- > drivers/video/fbdev/omap2/omapfb/dss/core.c | 6 ++---- > drivers/video/fbdev/omap2/omapfb/dss/dispc.c | 5 ++--- > drivers/video/fbdev/omap2/omapfb/dss/dpi.c | 5 ++--- > drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 5 ++--- > drivers/video/fbdev/omap2/omapfb/dss/dss.c | 5 ++--- > drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c | 5 ++--- > drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c | 5 ++--- > drivers/video/fbdev/omap2/omapfb/dss/sdi.c | 5 ++--- > drivers/video/fbdev/omap2/omapfb/dss/venc.c | 5 ++--- > drivers/video/fbdev/omap2/omapfb/omapfb-main.c | 6 ++---- > drivers/video/fbdev/p9100.c | 6 ++---- > drivers/video/fbdev/platinumfb.c | 6 ++---- > drivers/video/fbdev/pxa168fb.c | 8 +++----- > drivers/video/fbdev/pxa3xx-gcu.c | 6 ++---- > drivers/video/fbdev/pxafb.c | 8 +++----- > drivers/video/fbdev/s1d13xxxfb.c | 5 ++--- > drivers/video/fbdev/s3c-fb.c | 6 ++---- > drivers/video/fbdev/sh7760fb.c | 6 ++---- > drivers/video/fbdev/sh_mobile_lcdcfb.c | 5 ++--- > drivers/video/fbdev/simplefb.c | 6 ++---- > drivers/video/fbdev/sm501fb.c | 6 ++---- > drivers/video/fbdev/tcx.c | 6 ++---- > drivers/video/fbdev/uvesafb.c | 6 ++---- > drivers/video/fbdev/vesafb.c | 6 ++---- > drivers/video/fbdev/vfb.c | 5 ++--- > drivers/video/fbdev/vga16fb.c | 6 ++---- > drivers/video/fbdev/via/via-gpio.c | 5 ++--- > drivers/video/fbdev/via/via_i2c.c | 5 ++--- > drivers/video/fbdev/vt8500lcdfb.c | 6 ++---- > drivers/video/fbdev/wm8505fb.c | 6 ++---- > drivers/video/fbdev/wmt_ge_rops.c | 5 ++--- > drivers/video/fbdev/xilinxfb.c | 6 ++---- > 61 files changed, 126 insertions(+), 230 deletions(-) > > base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6