From: kishore kadiyala <kishorek.kadiyala@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: kishore kadiyala <kishore.kadiyala@ti.com>,
linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org,
madhu.cr@ti.com, jarkko.lavinen@nokia.com,
rmk+lkml@arm.linux.org.uk, santosh.shilimkar@ti.com
Subject: Re: [PATCH 2/7] OMAP4-HSMMC: Adding HSMMC support for OMAP4430 Board file
Date: Tue, 4 May 2010 11:31:11 +0530 [thread overview]
Message-ID: <k2q7f9d1ffb1005032301ob6071114j363af2a67fa1b157@mail.gmail.com> (raw)
In-Reply-To: <20100421184751.GG18272@atomide.com>
On Thu, Apr 22, 2010 at 12:17 AM, Tony Lindgren <tony@atomide.com> wrote:
> * kishore kadiyala <kishore.kadiyala@ti.com> [100421 11:15]:
>> This patch adds MMC1 and MMC2 Controller support for OMAP4430 Board
>> file.
>>
>> Signed-off-by: Kishore Kadiyala <kishore.kadiyala@ti.com>
>> ---
>> arch/arm/mach-omap2/Makefile | 3 +-
>> arch/arm/mach-omap2/board-4430sdp.c | 39 +++++++++++++++++++++++++++-------
>> 2 files changed, 33 insertions(+), 9 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
>> index 4b9fc57..40b291a 100644
>> --- a/arch/arm/mach-omap2/Makefile
>> +++ b/arch/arm/mach-omap2/Makefile
>> @@ -140,7 +140,8 @@ obj-$(CONFIG_MACH_IGEP0020) += board-igep0020.o \
>> hsmmc.o
>> obj-$(CONFIG_MACH_OMAP3_TOUCHBOOK) += board-omap3touchbook.o \
>> hsmmc.o
>> -obj-$(CONFIG_MACH_OMAP_4430SDP) += board-4430sdp.o
>> +obj-$(CONFIG_MACH_OMAP_4430SDP) += board-4430sdp.o \
>> + hsmmc.o
>>
>> obj-$(CONFIG_MACH_OMAP3517EVM) += board-am3517evm.o
>>
>> diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c
>> index 32cbd72..eae7c80 100644
>> --- a/arch/arm/mach-omap2/board-4430sdp.c
>> +++ b/arch/arm/mach-omap2/board-4430sdp.c
>> @@ -33,6 +33,7 @@
>> #include <plat/usb.h>
>> #include <asm/hardware/gic.h>
>> #include <asm/hardware/cache-l2x0.h>
>> +#include "hsmmc.h"
>>
>> static struct platform_device sdp4430_lcd_device = {
>> .name = "sdp4430_lcd",
>> @@ -80,17 +81,27 @@ static int __init omap_l2_cache_init(void)
>> early_initcall(omap_l2_cache_init);
>> #endif
>>
>> -
>> -static struct regulator_consumer_supply sdp4430_vmmc_supply[] = {
>> - {
>> - .supply = "vmmc",
>> - },
>> +static struct omap2_hsmmc_info mmc[] = {
>> {
>> - .supply = "vmmc",
>> + .mmc = 1,
>> + .wires = 8,
>> + /* "mmc0_cd" is not a gpio interrupt
>> + * but is a phoenix interrupt
>> + */
>> + .gpio_cd = 384,
>
> You can't use hardcoded irq numbers for twl interrupts. They can change.
> See sdp3430_twl_gpio_setup() for example.
I am working on it and will avoid hard coding .
Regards,
Kishore
next prev parent reply other threads:[~2010-05-04 6:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 18:19 [PATCH 2/7] OMAP4-HSMMC: Adding HSMMC support for OMAP4430 Board file kishore kadiyala
2010-04-21 18:47 ` Tony Lindgren
2010-05-04 6:01 ` kishore kadiyala [this message]
2010-04-22 6:35 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=k2q7f9d1ffb1005032301ob6071114j363af2a67fa1b157@mail.gmail.com \
--to=kishorek.kadiyala@gmail.com \
--cc=jarkko.lavinen@nokia.com \
--cc=kishore.kadiyala@ti.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=madhu.cr@ti.com \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).