From: Vimal Singh <vimal.newwork@gmail.com>
To: Artem.Bityutskiy@nokia.com
Cc: Tony Lindgren <tony@atomide.com>,
Sukumar Ghorai <s-ghorai@ti.com>,
Steve Sakoman <sakoman@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: Upcoming merge window and omap NAND patches
Date: Wed, 5 May 2010 11:41:39 +0530 [thread overview]
Message-ID: <l2wce9ab5791005042311lf1c1a15fu891457f4e0863d6@mail.gmail.com> (raw)
In-Reply-To: <1273034943.3702.19.camel@localhost>
On Wed, May 5, 2010 at 10:19 AM, Artem Bityutskiy
<Artem.Bityutskiy@nokia.com> wrote:
> On Wed, 2010-05-05 at 00:08 +0200, ext Tony Lindgren wrote:
>> Hi all,
>>
>> There are several omap NAND patches pending, but some basic things
>> should be fixed first.
>>
>> 1. The NAND driver needs to stop tinkering with the GPMC registers
>>
>> The omap General Purpose Memory Controller (GPMC) registers are omap
>> specific, and not driver specific. Tinkering with these registers
>> can cause issues with the other devices on the GPMC.
>>
>> To find out what needs to disappear fomr the NAND driver, just do:
>>
>> $ grep baseaddr drivers/mtd/nand/omap2.c
>>
>> Any GPMC register tinkering needs to happen in arch/arm/mach-omap2/gpmc.c.
>> If there are not currently GPMC functions to do something in gpmc.c, then
>> let's add the necessary support there.
>>
>> 2. Passing hardcoded GPMC_CS0_BASE needs to go from the board files
>>
>> Passing hardcoded GPMC virtual addressess is sure way to mess up
>> things. This should all become unnecessary once the NAND drivers
>> stops messing with the GPMC registers directly.
>>
>> So, as a result, I'm not planning on pushing any omap NAND related
>> patches until these basic issues are fixed. I'll mark these patches
>> as "Changes requested" in patchwork.kernel.org even if these patches
>> don't have anything else wrong with them.
>>
>> Let's fix the basic things for good, and put the other patches on
>> hold for a while. Sorry if this causes problems!
>
> Hi,
>
> fair enough. I guess Vimal should address this, as he seems to be the TI
> mr. NAND, right? :-)
Hi All,
Sorry again. I am no more with TI and I don't have any board with me
too. So, I'm unable to fix these. :(
I hope someone else from TI can take care of it.
--
Regards,
Vimal Singh
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2010-05-05 6:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 22:08 Upcoming merge window and omap NAND patches Tony Lindgren
2010-05-05 4:49 ` Artem Bityutskiy
2010-05-05 6:11 ` Vimal Singh [this message]
2010-05-05 12:33 ` Ghorai, Sukumar
2010-05-05 12:55 ` Mike Rapoport
2010-05-05 15:11 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=l2wce9ab5791005042311lf1c1a15fu891457f4e0863d6@mail.gmail.com \
--to=vimal.newwork@gmail.com \
--cc=Artem.Bityutskiy@nokia.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=s-ghorai@ti.com \
--cc=sakoman@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).