* [patch 2.6.29-rc3-omap-git] omap3: gpio pin config bugfixes
@ 2009-02-09 4:55 David Brownell
2009-02-09 12:24 ` Kim Kyuwon
2009-02-27 22:46 ` Tony Lindgren
0 siblings, 2 replies; 6+ messages in thread
From: David Brownell @ 2009-02-09 4:55 UTC (permalink / raw)
To: OMAP; +Cc: Manikandan Pillai
From: David Brownell <dbrownell@users.sourceforge.net>
Bugfix several GPIO mux configurations which didn't enable the
input drivers, but weren't named as e.g. ..._GPIO141_OUT.
These bugs were added quite recently, for OMAP3 EVM support.
To help avoid such bugs in the future, update the comment to
clarify the rule: always use PIN_INPUT, unless the name uses
that name suffix, to be crystal-clear on the signal's use as
output-only.
(Also adds GPIO-63, for the EVM's MMC-1 writeprotect switch.
Presumably that works right...)
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
---
arch/arm/mach-omap2/mux.c | 13 ++++++++-----
arch/arm/plat-omap/include/mach/mux.h | 1 +
2 files changed, 9 insertions(+), 5 deletions(-)
--- a/arch/arm/mach-omap2/mux.c
+++ b/arch/arm/mach-omap2/mux.c
@@ -453,6 +453,7 @@ MUX_CFG_34XX("AC1_3430_USB3FS_PHY_MM3_TX
/* 34XX GPIO - bidirectional, unless the name has an "_OUT" suffix.
+ * (Always specify PIN_INPUT, except for names suffixed by "_OUT".)
* No internal pullup/pulldown without "_UP" or "_DOWN" suffix.
*/
MUX_CFG_34XX("AH8_34XX_GPIO29", 0x5fa,
@@ -460,17 +461,19 @@ MUX_CFG_34XX("AH8_34XX_GPIO29", 0x5fa,
MUX_CFG_34XX("J25_34XX_GPIO170", 0x1c6,
OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
MUX_CFG_34XX("AF26_34XX_GPIO0", 0x1e0,
- OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
MUX_CFG_34XX("AF22_34XX_GPIO9", 0xa18,
- OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
+MUX_CFG_34XX("L8_34XX_GPIO63", 0x0ce,
+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
MUX_CFG_34XX("AF6_34XX_GPIO140_UP", 0x16c,
OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT_PULLUP)
MUX_CFG_34XX("AE6_34XX_GPIO141", 0x16e,
- OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
MUX_CFG_34XX("AF5_34XX_GPIO142", 0x170,
- OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
MUX_CFG_34XX("AE5_34XX_GPIO143", 0x172,
- OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
};
--- a/arch/arm/plat-omap/include/mach/mux.h
+++ b/arch/arm/plat-omap/include/mach/mux.h
@@ -792,6 +792,7 @@ enum omap34xx_index {
J25_34XX_GPIO170,
AF26_34XX_GPIO0,
AF22_34XX_GPIO9,
+ L8_34XX_GPIO63,
AF6_34XX_GPIO140_UP,
AE6_34XX_GPIO141,
AF5_34XX_GPIO142,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch 2.6.29-rc3-omap-git] omap3: gpio pin config bugfixes
2009-02-09 4:55 [patch 2.6.29-rc3-omap-git] omap3: gpio pin config bugfixes David Brownell
@ 2009-02-09 12:24 ` Kim Kyuwon
2009-02-12 0:45 ` Tony Lindgren
2009-02-27 22:46 ` Tony Lindgren
1 sibling, 1 reply; 6+ messages in thread
From: Kim Kyuwon @ 2009-02-09 12:24 UTC (permalink / raw)
To: David Brownell; +Cc: OMAP, Manikandan Pillai
Hi,
On Mon, Feb 9, 2009 at 1:55 PM, David Brownell <david-b@pacbell.net> wrote:
> From: David Brownell <dbrownell@users.sourceforge.net>
>
> Bugfix several GPIO mux configurations which didn't enable the
> input drivers, but weren't named as e.g. ..._GPIO141_OUT.
> These bugs were added quite recently, for OMAP3 EVM support.
>
> To help avoid such bugs in the future, update the comment to
> clarify the rule: always use PIN_INPUT, unless the name uses
> that name suffix, to be crystal-clear on the signal's use as
> output-only.
>
> (Also adds GPIO-63, for the EVM's MMC-1 writeprotect switch.
> Presumably that works right...)
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
>
> arch/arm/mach-omap2/mux.c | 13 ++++++++-----
> arch/arm/plat-omap/include/mach/mux.h | 1 +
> 2 files changed, 9 insertions(+), 5 deletions(-)
>
> --- a/arch/arm/mach-omap2/mux.c
> +++ b/arch/arm/mach-omap2/mux.c
> @@ -453,6 +453,7 @@ MUX_CFG_34XX("AC1_3430_USB3FS_PHY_MM3_TX
>
>
> /* 34XX GPIO - bidirectional, unless the name has an "_OUT" suffix.
> + * (Always specify PIN_INPUT, except for names suffixed by "_OUT".)
> * No internal pullup/pulldown without "_UP" or "_DOWN" suffix.
> */
> MUX_CFG_34XX("AH8_34XX_GPIO29", 0x5fa,
> @@ -460,17 +461,19 @@ MUX_CFG_34XX("AH8_34XX_GPIO29", 0x5fa,
> MUX_CFG_34XX("J25_34XX_GPIO170", 0x1c6,
> OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
> MUX_CFG_34XX("AF26_34XX_GPIO0", 0x1e0,
> - OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
> + OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
> MUX_CFG_34XX("AF22_34XX_GPIO9", 0xa18,
> - OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
> + OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
> +MUX_CFG_34XX("L8_34XX_GPIO63", 0x0ce,
> + OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
> MUX_CFG_34XX("AF6_34XX_GPIO140_UP", 0x16c,
> OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT_PULLUP)
> MUX_CFG_34XX("AE6_34XX_GPIO141", 0x16e,
> - OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
> + OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
> MUX_CFG_34XX("AF5_34XX_GPIO142", 0x170,
> - OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
> + OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
> MUX_CFG_34XX("AE5_34XX_GPIO143", 0x172,
> - OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
> + OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
>
> };
>
So the thing is, OMAP34XX_PIN_INPUT doens't mean input-only, but
input-and-output. And OMAP34XX_PIN_OUTPUT doen't mean output, but output-only.
Names of macros are really confusing me. Shouldn't we change names of these
macros first? For example,
OMAP34XX_PIN_INPUT -> OMAP34XX_PIN_INPUT_EN
OMAP34XX_PIN_OUTPUT -> OMAP34XX_PIN_OUTPUT_ONLY
> --- a/arch/arm/plat-omap/include/mach/mux.h
> +++ b/arch/arm/plat-omap/include/mach/mux.h
> @@ -792,6 +792,7 @@ enum omap34xx_index {
> J25_34XX_GPIO170,
> AF26_34XX_GPIO0,
> AF22_34XX_GPIO9,
> + L8_34XX_GPIO63,
> AF6_34XX_GPIO140_UP,
> AE6_34XX_GPIO141,
> AF5_34XX_GPIO142,
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Kim Kyuwon
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch 2.6.29-rc3-omap-git] omap3: gpio pin config bugfixes
2009-02-09 12:24 ` Kim Kyuwon
@ 2009-02-12 0:45 ` Tony Lindgren
2009-02-12 1:51 ` David Brownell
0 siblings, 1 reply; 6+ messages in thread
From: Tony Lindgren @ 2009-02-12 0:45 UTC (permalink / raw)
To: Kim Kyuwon; +Cc: David Brownell, OMAP, Manikandan Pillai
* Kim Kyuwon <chammoru@gmail.com> [090209 04:25]:
> Hi,
>
> On Mon, Feb 9, 2009 at 1:55 PM, David Brownell <david-b@pacbell.net> wrote:
> > From: David Brownell <dbrownell@users.sourceforge.net>
> >
> > Bugfix several GPIO mux configurations which didn't enable the
> > input drivers, but weren't named as e.g. ..._GPIO141_OUT.
> > These bugs were added quite recently, for OMAP3 EVM support.
> >
> > To help avoid such bugs in the future, update the comment to
> > clarify the rule: always use PIN_INPUT, unless the name uses
> > that name suffix, to be crystal-clear on the signal's use as
> > output-only.
> >
> > (Also adds GPIO-63, for the EVM's MMC-1 writeprotect switch.
> > Presumably that works right...)
> >
> > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> > ---
> >
> > arch/arm/mach-omap2/mux.c | 13 ++++++++-----
> > arch/arm/plat-omap/include/mach/mux.h | 1 +
> > 2 files changed, 9 insertions(+), 5 deletions(-)
> >
> > --- a/arch/arm/mach-omap2/mux.c
> > +++ b/arch/arm/mach-omap2/mux.c
> > @@ -453,6 +453,7 @@ MUX_CFG_34XX("AC1_3430_USB3FS_PHY_MM3_TX
> >
> >
> > /* 34XX GPIO - bidirectional, unless the name has an "_OUT" suffix.
> > + * (Always specify PIN_INPUT, except for names suffixed by "_OUT".)
> > * No internal pullup/pulldown without "_UP" or "_DOWN" suffix.
> > */
> > MUX_CFG_34XX("AH8_34XX_GPIO29", 0x5fa,
> > @@ -460,17 +461,19 @@ MUX_CFG_34XX("AH8_34XX_GPIO29", 0x5fa,
> > MUX_CFG_34XX("J25_34XX_GPIO170", 0x1c6,
> > OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
> > MUX_CFG_34XX("AF26_34XX_GPIO0", 0x1e0,
> > - OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
> > + OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
> > MUX_CFG_34XX("AF22_34XX_GPIO9", 0xa18,
> > - OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
> > + OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
> > +MUX_CFG_34XX("L8_34XX_GPIO63", 0x0ce,
> > + OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
> > MUX_CFG_34XX("AF6_34XX_GPIO140_UP", 0x16c,
> > OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT_PULLUP)
> > MUX_CFG_34XX("AE6_34XX_GPIO141", 0x16e,
> > - OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
> > + OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
> > MUX_CFG_34XX("AF5_34XX_GPIO142", 0x170,
> > - OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
> > + OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
> > MUX_CFG_34XX("AE5_34XX_GPIO143", 0x172,
> > - OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
> > + OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
> >
> > };
> >
>
> So the thing is, OMAP34XX_PIN_INPUT doens't mean input-only, but
> input-and-output. And OMAP34XX_PIN_OUTPUT doen't mean output, but output-only.
> Names of macros are really confusing me. Shouldn't we change names of these
> macros first? For example,
> OMAP34XX_PIN_INPUT -> OMAP34XX_PIN_INPUT_EN
> OMAP34XX_PIN_OUTPUT -> OMAP34XX_PIN_OUTPUT_ONLY
I like this idea to cut down on confusion.
Tony
> > --- a/arch/arm/plat-omap/include/mach/mux.h
> > +++ b/arch/arm/plat-omap/include/mach/mux.h
> > @@ -792,6 +792,7 @@ enum omap34xx_index {
> > J25_34XX_GPIO170,
> > AF26_34XX_GPIO0,
> > AF22_34XX_GPIO9,
> > + L8_34XX_GPIO63,
> > AF6_34XX_GPIO140_UP,
> > AE6_34XX_GPIO141,
> > AF5_34XX_GPIO142,
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>
>
>
> --
> Kim Kyuwon
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch 2.6.29-rc3-omap-git] omap3: gpio pin config bugfixes
2009-02-12 0:45 ` Tony Lindgren
@ 2009-02-12 1:51 ` David Brownell
0 siblings, 0 replies; 6+ messages in thread
From: David Brownell @ 2009-02-12 1:51 UTC (permalink / raw)
To: Tony Lindgren; +Cc: Kim Kyuwon, OMAP, Manikandan Pillai
On Wednesday 11 February 2009, Tony Lindgren wrote:
> > >
> >
> > So the thing is, OMAP34XX_PIN_INPUT doens't mean input-only, but
> > input-and-output. And OMAP34XX_PIN_OUTPUT doen't mean output, but output-only.
> > Names of macros are really confusing me. Shouldn't we change names of these
> > macros first? For example,
> > OMAP34XX_PIN_INPUT -> OMAP34XX_PIN_INPUT_EN
> > OMAP34XX_PIN_OUTPUT -> OMAP34XX_PIN_OUTPUT_ONLY
>
> I like this idea to cut down on confusion.
Makes sense to me. Though I suggest merging this first,
and then changing everything in the tree ... instead of
changing everything first, and then redoing this patch. :)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch 2.6.29-rc3-omap-git] omap3: gpio pin config bugfixes
2009-02-09 4:55 [patch 2.6.29-rc3-omap-git] omap3: gpio pin config bugfixes David Brownell
2009-02-09 12:24 ` Kim Kyuwon
@ 2009-02-27 22:46 ` Tony Lindgren
2009-02-27 22:48 ` [APPLIED] " Tony Lindgren
1 sibling, 1 reply; 6+ messages in thread
From: Tony Lindgren @ 2009-02-27 22:46 UTC (permalink / raw)
To: David Brownell; +Cc: OMAP, Manikandan Pillai
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
* David Brownell <david-b@pacbell.net> [090208 20:55]:
> From: David Brownell <dbrownell@users.sourceforge.net>
>
> Bugfix several GPIO mux configurations which didn't enable the
> input drivers, but weren't named as e.g. ..._GPIO141_OUT.
> These bugs were added quite recently, for OMAP3 EVM support.
>
> To help avoid such bugs in the future, update the comment to
> clarify the rule: always use PIN_INPUT, unless the name uses
> that name suffix, to be crystal-clear on the signal's use as
> output-only.
>
> (Also adds GPIO-63, for the EVM's MMC-1 writeprotect switch.
> Presumably that works right...)
Here's this refreshed to apply against l-o.
Tony
[-- Attachment #2: apply --]
[-- Type: text/plain, Size: 2653 bytes --]
From: David Brownell <david-b@pacbell.net>
To: OMAP <linux-omap@vger.kernel.org>
Subject: [patch 2.6.29-rc3-omap-git] omap3: gpio pin config bugfixes
From: David Brownell <dbrownell@users.sourceforge.net>
Bugfix several GPIO mux configurations which didn't enable the
input drivers, but weren't named as e.g. ..._GPIO141_OUT.
These bugs were added quite recently, for OMAP3 EVM support.
To help avoid such bugs in the future, update the comment to
clarify the rule: always use PIN_INPUT, unless the name uses
that name suffix, to be crystal-clear on the signal's use as
output-only.
(Also adds GPIO-63, for the EVM's MMC-1 writeprotect switch.
Presumably that works right...)
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
---
arch/arm/mach-omap2/mux.c | 13 ++++++++-----
arch/arm/plat-omap/include/mach/mux.h | 1 +
2 files changed, 9 insertions(+), 5 deletions(-)
--- a/arch/arm/mach-omap2/mux.c
+++ b/arch/arm/mach-omap2/mux.c
@@ -453,6 +453,7 @@ MUX_CFG_34XX("AC1_3430_USB3FS_PHY_MM3_TX
/* 34XX GPIO - bidirectional, unless the name has an "_OUT" suffix.
+ * (Always specify PIN_INPUT, except for names suffixed by "_OUT".)
* No internal pullup/pulldown without "_UP" or "_DOWN" suffix.
*/
MUX_CFG_34XX("AH8_34XX_GPIO29", 0x5fa,
@@ -460,17 +461,19 @@ MUX_CFG_34XX("AH8_34XX_GPIO29", 0x5fa,
MUX_CFG_34XX("J25_34XX_GPIO170", 0x1c6,
OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
MUX_CFG_34XX("AF26_34XX_GPIO0", 0x1e0,
- OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
MUX_CFG_34XX("AF22_34XX_GPIO9", 0xa18,
- OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
+MUX_CFG_34XX("L8_34XX_GPIO63", 0x0ce,
+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
MUX_CFG_34XX("AF6_34XX_GPIO140_UP", 0x16c,
OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT_PULLUP)
MUX_CFG_34XX("AE6_34XX_GPIO141", 0x16e,
- OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
MUX_CFG_34XX("AF5_34XX_GPIO142", 0x170,
- OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
MUX_CFG_34XX("AE5_34XX_GPIO143", 0x172,
- OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
MUX_CFG_34XX("AG4_34XX_GPIO134", 0x160,
OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
MUX_CFG_34XX("U8_34XX_GPIO54", 0x0b4,
--- a/arch/arm/plat-omap/include/mach/mux.h
+++ b/arch/arm/plat-omap/include/mach/mux.h
@@ -792,6 +792,7 @@ enum omap34xx_index {
J25_34XX_GPIO170,
AF26_34XX_GPIO0,
AF22_34XX_GPIO9,
+ L8_34XX_GPIO63,
AF6_34XX_GPIO140_UP,
AE6_34XX_GPIO141,
AF5_34XX_GPIO142,
^ permalink raw reply [flat|nested] 6+ messages in thread
* [APPLIED] [patch 2.6.29-rc3-omap-git] omap3: gpio pin config bugfixes
2009-02-27 22:46 ` Tony Lindgren
@ 2009-02-27 22:48 ` Tony Lindgren
0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2009-02-27 22:48 UTC (permalink / raw)
To: linux-omap
This patch has been applied to the linux-omap
by youw fwiendly patch wobot.
Commit: a81ceea04499e24a6397ecd47aa7316b5d165e82
PatchWorks
http://patchwork.kernel.org/patch/9249/
Git
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=a81ceea04499e24a6397ecd47aa7316b5d165e82
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-02-27 22:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-09 4:55 [patch 2.6.29-rc3-omap-git] omap3: gpio pin config bugfixes David Brownell
2009-02-09 12:24 ` Kim Kyuwon
2009-02-12 0:45 ` Tony Lindgren
2009-02-12 1:51 ` David Brownell
2009-02-27 22:46 ` Tony Lindgren
2009-02-27 22:48 ` [APPLIED] " Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox