[PATCH] ARM: OMAP: Fix tusb6010 init error and compilation warning

[PATCH] ARM: OMAP: Fix tusb6010 init error and compilation warning

[Jarkko Nikula]

Fix "tusb6010 init error 5, -19" and compilation warning from function
tusb6010_platform_retime "warning: 'sysclk_ps' is used uninitialized in this
function".

I suppose commit c094ba34b8f780885d029ce3c2715a194b780e5d was meant to test
for zero fclk_ps instead of sysclk_ps.

Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
Cc: Roel Kluin <roel.kluin@gmail.com>
---
 arch/arm/mach-omap2/usb-tusb6010.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/usb-tusb6010.c b/arch/arm/mach-omap2/usb-tusb6010.c
index 59c1d57..c05df28 100644
--- a/arch/arm/mach-omap2/usb-tusb6010.c
+++ b/arch/arm/mach-omap2/usb-tusb6010.c
@@ -185,7 +185,7 @@ int tusb6010_platform_retime(unsigned is_refclk)
 	unsigned	sysclk_ps;
 	int		status;
 
-	if (!refclk_psec || sysclk_ps == 0)
+	if (!refclk_psec || fclk_ps == 0)
 		return -ENODEV;
 
 	sysclk_ps = is_refclk ? refclk_psec : TUSB6010_OSCCLK_60;
-- 
1.6.2.1

Re: [PATCH] ARM: OMAP: Fix tusb6010 init error and compilation warning

[Kalle Valo]

Jarkko Nikula <jarkko.nikula@nokia.com> writes:

> Fix "tusb6010 init error 5, -19" and compilation warning from function
> tusb6010_platform_retime "warning: 'sysclk_ps' is used uninitialized in this
> function".
>
> I suppose commit c094ba34b8f780885d029ce3c2715a194b780e5d was meant to test
> for zero fclk_ps instead of sysclk_ps.

I was suffering exactly this problem and this patch fixed it. Now usb
network works again, thanks a lot for fixing this!

> Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
> Cc: Roel Kluin <roel.kluin@gmail.com>

Tested-by: Kalle Valo <kalle.valo@iki.fi>

-- 
Kalle Valo

Re: [PATCH] ARM: OMAP: Fix tusb6010 init error and compilation warning

[Jarkko Nikula]

On Thu, 23 Apr 2009 20:06:39 +0300
Kalle Valo <kalle.valo@iki.fi> wrote:

> Jarkko Nikula <jarkko.nikula@nokia.com> writes:
> 
> > Fix "tusb6010 init error 5, -19" and compilation warning from
> > function tusb6010_platform_retime "warning: 'sysclk_ps' is used
> > uninitialized in this function".
> >
> > I suppose commit c094ba34b8f780885d029ce3c2715a194b780e5d was meant
> > to test for zero fclk_ps instead of sysclk_ps.
> 
> I was suffering exactly this problem and this patch fixed it. Now usb
> network works again, thanks a lot for fixing this!
> 
> > Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
> > Cc: Roel Kluin <roel.kluin@gmail.com>
> 
> Tested-by: Kalle Valo <kalle.valo@iki.fi>
> 
Ping? This patch was a fix for 2.6.30-rcX.


-- 
Jarkko

[APPLIED] [PATCH] ARM: OMAP: Fix tusb6010 init error and compilation warning

[Tony Lindgren]

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Initial commit ID (Likely to change): 17178f265cbe2220fc437e93128fb0feea54c3fc

PatchWorks
http://patchwork.kernel.org/patch/19477/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=17178f265cbe2220fc437e93128fb0feea54c3fc

Re: [PATCH] ARM: OMAP: Fix tusb6010 init error and compilation warning

[Tony Lindgren]

* Jarkko Nikula <jhnikula@gmail.com> [090506 22:16]:
> On Thu, 23 Apr 2009 20:06:39 +0300
> Kalle Valo <kalle.valo@iki.fi> wrote:
> 
> > Jarkko Nikula <jarkko.nikula@nokia.com> writes:
> > 
> > > Fix "tusb6010 init error 5, -19" and compilation warning from
> > > function tusb6010_platform_retime "warning: 'sysclk_ps' is used
> > > uninitialized in this function".
> > >
> > > I suppose commit c094ba34b8f780885d029ce3c2715a194b780e5d was meant
> > > to test for zero fclk_ps instead of sysclk_ps.
> > 
> > I was suffering exactly this problem and this patch fixed it. Now usb
> > network works again, thanks a lot for fixing this!
> > 
> > > Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
> > > Cc: Roel Kluin <roel.kluin@gmail.com>
> > 
> > Tested-by: Kalle Valo <kalle.valo@iki.fi>
> > 
> Ping? This patch was a fix for 2.6.30-rcX.

Sorry for the delay. Pushed and added to omap-fixes, so we should
still get this in.

Regards,

Tony