[PATCH 1/1] IOMMU: function flush_iotlb_page is not flushing correct entry

[PATCH 1/1] IOMMU: function flush_iotlb_page is not flushing correct entry

[Hiroshi DOYU]

From: Fernando Guzman Lugo <x0095840@ti.com>

From: Fernando Guzman Lugo <x0095840@ti.com>

The function flush_iotlb_page is not loading the CAM register with
the correct entry to be flushed, so it is flushing other entry

Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com>
Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
---
 arch/arm/plat-omap/iommu.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
 mode change 100644 => 100755 arch/arm/plat-omap/iommu.c

diff --git a/arch/arm/plat-omap/iommu.c b/arch/arm/plat-omap/iommu.c
old mode 100644
new mode 100755
index 4cf449f..4a03013
--- a/arch/arm/plat-omap/iommu.c
+++ b/arch/arm/plat-omap/iommu.c
@@ -298,7 +298,7 @@ void flush_iotlb_page(struct iommu *obj, u32 da)
 		if ((start <= da) && (da < start + bytes)) {
 			dev_dbg(obj->dev, "%s: %08x<=%08x(%x)\n",
 				__func__, start, da, bytes);
-
+			iotlb_load_cr(obj, &cr);
 			iommu_write_reg(obj, 1, MMU_FLUSH_ENTRY);
 		}
 	}
-- 
1.6.0.4

[APPLIED] [PATCH 1/1] IOMMU: function flush_iotlb_page is not flushing

[Tony Lindgren]

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Initial commit ID (Likely to change): aef217b87726a17282c975e9281e9f698ff2b8e6

PatchWorks
http://patchwork.kernel.org/patch/30288/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=aef217b87726a17282c975e9281e9f698ff2b8e6

Re: [PATCH 1/1] IOMMU: function flush_iotlb_page is not flushing correct entry

[Tony Lindgren]

* Hiroshi DOYU <Hiroshi.DOYU@nokia.com> [090615 12:39]:
> From: Fernando Guzman Lugo <x0095840@ti.com>
> 
> From: Fernando Guzman Lugo <x0095840@ti.com>
> 
> The function flush_iotlb_page is not loading the CAM register with
> the correct entry to be flushed, so it is flushing other entry
> 
> Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com>
> Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
> ---
>  arch/arm/plat-omap/iommu.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>  mode change 100644 => 100755 arch/arm/plat-omap/iommu.c
> 
> diff --git a/arch/arm/plat-omap/iommu.c b/arch/arm/plat-omap/iommu.c
> old mode 100644
> new mode 100755

This made some bad mode changes as noted by Paul, will fix in l-o master
and in omap-fixes. But please check your repos too!

Tony

> index 4cf449f..4a03013
> --- a/arch/arm/plat-omap/iommu.c
> +++ b/arch/arm/plat-omap/iommu.c
> @@ -298,7 +298,7 @@ void flush_iotlb_page(struct iommu *obj, u32 da)
>  		if ((start <= da) && (da < start + bytes)) {
>  			dev_dbg(obj->dev, "%s: %08x<=%08x(%x)\n",
>  				__func__, start, da, bytes);
> -
> +			iotlb_load_cr(obj, &cr);
>  			iommu_write_reg(obj, 1, MMU_FLUSH_ENTRY);
>  		}
>  	}
> -- 
> 1.6.0.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] IOMMU: function flush_iotlb_page is not flushing correct entry

[Hiroshi DOYU]

From: ext Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 1/1] IOMMU: function flush_iotlb_page is not flushing correct entry
Date: Thu, 18 Jun 2009 07:05:56 +0200

> * Hiroshi DOYU <Hiroshi.DOYU@nokia.com> [090615 12:39]:
> > From: Fernando Guzman Lugo <x0095840@ti.com>
> > 
> > From: Fernando Guzman Lugo <x0095840@ti.com>
> > 
> > The function flush_iotlb_page is not loading the CAM register with
> > the correct entry to be flushed, so it is flushing other entry
> > 
> > Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com>
> > Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
> > ---
> >  arch/arm/plat-omap/iommu.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >  mode change 100644 => 100755 arch/arm/plat-omap/iommu.c
> > 
> > diff --git a/arch/arm/plat-omap/iommu.c b/arch/arm/plat-omap/iommu.c
> > old mode 100644
> > new mode 100755
> 
> This made some bad mode changes as noted by Paul, will fix in l-o master
> and in omap-fixes. But please check your repos too!

Will check. Maybe I did something wrong in my emacs dired-mode...:(

> 
> Tony
> 
> > index 4cf449f..4a03013
> > --- a/arch/arm/plat-omap/iommu.c
> > +++ b/arch/arm/plat-omap/iommu.c
> > @@ -298,7 +298,7 @@ void flush_iotlb_page(struct iommu *obj, u32 da)
> >  		if ((start <= da) && (da < start + bytes)) {
> >  			dev_dbg(obj->dev, "%s: %08x<=%08x(%x)\n",
> >  				__func__, start, da, bytes);
> > -
> > +			iotlb_load_cr(obj, &cr);
> >  			iommu_write_reg(obj, 1, MMU_FLUSH_ENTRY);
> >  		}
> >  	}
> > -- 
> > 1.6.0.4
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html