public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: OMAP: McBSP: Fix incorrect receiver stop in omap_mcbsp_stop
@ 2009-10-11 15:22 Jarkko Nikula
  2009-10-13 18:07 ` [APPLIED] [PATCH] ARM: OMAP: McBSP: Fix incorrect receiver stop in Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: Jarkko Nikula @ 2009-10-11 15:22 UTC (permalink / raw)
  To: linux-omap; +Cc: Jarkko Nikula

This small typo written by author causes that McBSP receiver is disabled on
OMAP2430 and OMAP3430 even if only transmitter is stopped. This was noted
with ALSA SoC where simultaneous recording halted if playback was stopped
first.

Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
---
 arch/arm/plat-omap/mcbsp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c
index 88ac976..e664b91 100644
--- a/arch/arm/plat-omap/mcbsp.c
+++ b/arch/arm/plat-omap/mcbsp.c
@@ -595,7 +595,7 @@ void omap_mcbsp_stop(unsigned int id, int tx, int rx)
 	rx &= 1;
 	if (cpu_is_omap2430() || cpu_is_omap34xx()) {
 		w = OMAP_MCBSP_READ(io_base, RCCR);
-		w |= (tx ? RDISABLE : 0);
+		w |= (rx ? RDISABLE : 0);
 		OMAP_MCBSP_WRITE(io_base, RCCR, w);
 	}
 	w = OMAP_MCBSP_READ(io_base, SPCR1);
-- 
1.6.3.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [APPLIED] [PATCH] ARM: OMAP: McBSP: Fix incorrect receiver stop in
  2009-10-11 15:22 [PATCH] ARM: OMAP: McBSP: Fix incorrect receiver stop in omap_mcbsp_stop Jarkko Nikula
@ 2009-10-13 18:07 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2009-10-13 18:07 UTC (permalink / raw)
  To: linux-omap

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Initial commit ID (Likely to change): 9fd9fe496604919d9d23f284ebd4a84cb2f97066

PatchWorks
http://patchwork.kernel.org/patch/53005/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=9fd9fe496604919d9d23f284ebd4a84cb2f97066



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-10-13 18:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-11 15:22 [PATCH] ARM: OMAP: McBSP: Fix incorrect receiver stop in omap_mcbsp_stop Jarkko Nikula
2009-10-13 18:07 ` [APPLIED] [PATCH] ARM: OMAP: McBSP: Fix incorrect receiver stop in Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox