[PATCH] OMAP1: AMS_DELTA: Fix DSP public peripherals support

[PATCH] OMAP1: AMS_DELTA: Fix DSP public peripherals support

[Janusz Krzysztofik]

DSP public peripherals used to work on OMAP1510 based (or all OMAP1 class?)
machines as long as old dspgateway code were present in the l-o tree. For
several months it is no longer included, breaking support for McBSP1 based
audio on Amstrad Delta, for example.

This patch, derived from the old dspgateway code, corrects the problem for the
board by simply taking the DSP out of reset state, I guess. That way, things
should not break when a new dsp code is added to the tree, and the change can
be reverted then.

If there are any reports on McBSP1 or other DSP public peripherals not working
for other OMAP1 machines (I've not heard of any for now), I can prepare a more
general patch providing an extra include file with a helper function defined.

Created and tested against linux-2.6.32-rc5

Signed-off-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>

---
--- linux-2.6.32-rc5/arch/arm/mach-omap1/board-ams-delta.c.orig	2009-10-22 
00:55:49.000000000 +0200
+++ linux-2.6.32-rc5/arch/arm/mach-omap1/board-ams-delta.c	2009-10-22 
01:46:39.000000000 +0200
@@ -235,6 +235,8 @@ static void __init ams_delta_init(void)
 
 	omap_usb_init(&ams_delta_usb_config);
 	platform_add_devices(ams_delta_devices, ARRAY_SIZE(ams_delta_devices));
+
+	omap_writew(omap_readw(ARM_RSTCT1) | 0x0004, ARM_RSTCT1);
 }
 
 static struct plat_serial8250_port ams_delta_modem_ports[] = {

[PATCH resend] OMAP1: AMS_DELTA: Fix DSP public peripherals support

[Janusz Krzysztofik]

DSP public peripherals used to work on OMAP1510 based (or all OMAP1 class?)
machines as long as old dspgateway code were present in the l-o tree. For
several months it is no longer included, breaking support for McBSP1 based
audio on Amstrad Delta, for example.

This patch, derived from the old dspgateway code, corrects the problem for the
board by simply taking the DSP out of reset state, I guess. That way, things
should not break when a new dsp code is added to the tree, and the change can
be reverted then.

If there are any reports on McBSP1 or other DSP public peripherals not working
for other OMAP1 machines (I've not heard of any for now), I can prepare a more
general patch providing an extra include file with a helper function defined.

Created and tested against linux-2.6.32-rc5

Signed-off-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>

---
Thursday 22 October 2009 02:22:53 Janusz Krzysztofik wrote:
> --- linux-2.6.32-rc5/arch/arm/mach-omap1/board-ams-delta.c.orig	2009-10-22 
> 00:55:49.000000000 +0200
> +++ linux-2.6.32-rc5/arch/arm/mach-omap1/board-ams-delta.c	2009-10-22 
> 01:46:39.000000000 +0200

Tony,
The above lines has been mangled by my mailer, that's why I resend for your
convenience.

--- linux-2.6.32-rc5/arch/arm/mach-omap1/board-ams-delta.c.orig	2009-10-22 00:55:49.000000000 +0200
+++ linux-2.6.32-rc5/arch/arm/mach-omap1/board-ams-delta.c	2009-10-22 01:46:39.000000000 +0200
@@ -235,6 +235,8 @@ static void __init ams_delta_init(void)
 
 	omap_usb_init(&ams_delta_usb_config);
 	platform_add_devices(ams_delta_devices, ARRAY_SIZE(ams_delta_devices));
+
+	omap_writew(omap_readw(ARM_RSTCT1) | 0x0004, ARM_RSTCT1);
 }
 
 static struct plat_serial8250_port ams_delta_modem_ports[] = {

Re: [PATCH resend] OMAP1: AMS_DELTA: Fix DSP public peripherals support

[Tony Lindgren]

* Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> [091022 05:22]:
> DSP public peripherals used to work on OMAP1510 based (or all OMAP1 class?)
> machines as long as old dspgateway code were present in the l-o tree. For
> several months it is no longer included, breaking support for McBSP1 based
> audio on Amstrad Delta, for example.
> 
> This patch, derived from the old dspgateway code, corrects the problem for the
> board by simply taking the DSP out of reset state, I guess. That way, things
> should not break when a new dsp code is added to the tree, and the change can
> be reverted then.
> 
> If there are any reports on McBSP1 or other DSP public peripherals not working
> for other OMAP1 machines (I've not heard of any for now), I can prepare a more
> general patch providing an extra include file with a helper function defined.

Seems like a good fix. Of course it would be nice to also idle the DSP for
some power savings, but maybe we can add something for that this coming merge
window.

Regards,

Tony
 
> Created and tested against linux-2.6.32-rc5
> 
> Signed-off-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
> 
> ---
> Thursday 22 October 2009 02:22:53 Janusz Krzysztofik wrote:
> > --- linux-2.6.32-rc5/arch/arm/mach-omap1/board-ams-delta.c.orig	2009-10-22 
> > 00:55:49.000000000 +0200
> > +++ linux-2.6.32-rc5/arch/arm/mach-omap1/board-ams-delta.c	2009-10-22 
> > 01:46:39.000000000 +0200
> 
> Tony,
> The above lines has been mangled by my mailer, that's why I resend for your
> convenience.
> 
> --- linux-2.6.32-rc5/arch/arm/mach-omap1/board-ams-delta.c.orig	2009-10-22 00:55:49.000000000 +0200
> +++ linux-2.6.32-rc5/arch/arm/mach-omap1/board-ams-delta.c	2009-10-22 01:46:39.000000000 +0200
> @@ -235,6 +235,8 @@ static void __init ams_delta_init(void)
>  
>  	omap_usb_init(&ams_delta_usb_config);
>  	platform_add_devices(ams_delta_devices, ARRAY_SIZE(ams_delta_devices));
> +
> +	omap_writew(omap_readw(ARM_RSTCT1) | 0x0004, ARM_RSTCT1);
>  }
>  
>  static struct plat_serial8250_port ams_delta_modem_ports[] = {

Re: [PATCH resend] OMAP1: AMS_DELTA: Fix DSP public peripherals support

[Janusz Krzysztofik]

Thursday 22 October 2009 20:06:59 Tony Lindgren napisał(a):
> * Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> [091022 05:22]:
> > DSP public peripherals used to work on OMAP1510 based (or all OMAP1 class?)
> > machines as long as old dspgateway code were present in the l-o tree. For
> > several months it is no longer included, breaking support for McBSP1 based
> > audio on Amstrad Delta, for example.
> > 
> > This patch, derived from the old dspgateway code, corrects the problem for the
> > board by simply taking the DSP out of reset state, I guess. That way, things
> > should not break when a new dsp code is added to the tree, and the change can
> > be reverted then.
> 
> Seems like a good fix.

Tony,
Does it mean that you can push it as a fix for 2.6.32? That would be great if my successfull efforts on getting audio support for Amstrad Delta included in the mainline tree would result in a fully functional solution!

I start preparing a new ams_delta_defconfig then.

Thanks,
Janusz
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH resend] OMAP1: AMS_DELTA: Fix DSP public peripherals support

[Tony Lindgren]

* Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> [091022 12:15]:
> Thursday 22 October 2009 20:06:59 Tony Lindgren napisał(a):
> > * Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> [091022 05:22]:
> > > DSP public peripherals used to work on OMAP1510 based (or all OMAP1 class?)
> > > machines as long as old dspgateway code were present in the l-o tree. For
> > > several months it is no longer included, breaking support for McBSP1 based
> > > audio on Amstrad Delta, for example.
> > > 
> > > This patch, derived from the old dspgateway code, corrects the problem for the
> > > board by simply taking the DSP out of reset state, I guess. That way, things
> > > should not break when a new dsp code is added to the tree, and the change can
> > > be reverted then.
> > 
> > Seems like a good fix.
> 
> Tony,
> Does it mean that you can push it as a fix for 2.6.32? That would be great if my successfull efforts on getting audio support for Amstrad Delta included in the mainline tree would result in a fully functional solution!

Yeah we should be able to merge those as fixes.
 
> I start preparing a new ams_delta_defconfig then.

Cool :)

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[APPLIED] [PATCH resend] OMAP1: AMS_DELTA: Fix DSP public peripherals support

[Tony Lindgren]

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Initial commit ID (Likely to change): e672f57540ddd030f52aa14a03aa5745e97da406

PatchWorks
http://patchwork.kernel.org/patch/55312/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=e672f57540ddd030f52aa14a03aa5745e97da406