public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix include problem. Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
@ 2009-12-03 13:28 Belisko Marek
  2009-12-03 15:29 ` Cory Maccarrone
  2009-12-04 22:57 ` [APPLIED] [PATCH] Fix include problem. Signed-off-by: Marek Belisko Tony Lindgren
  0 siblings, 2 replies; 5+ messages in thread
From: Belisko Marek @ 2009-12-03 13:28 UTC (permalink / raw)
  To: linux-omap

Hi,

when make htcherald_defconfig on current linux-omap tree
(82f1d8f22f2c65e70206e40a6f17688bf64a892c) compilation fails
in drivers/video/omap/lcd_htcherald.c.

Following patch fixed this problem.

---
 drivers/video/omap/lcd_htcherald.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/omap/lcd_htcherald.c
b/drivers/video/omap/lcd_htcherald.c
index 2e0c81e..a9007c5 100644
--- a/drivers/video/omap/lcd_htcherald.c
+++ b/drivers/video/omap/lcd_htcherald.c
@@ -29,7 +29,7 @@
 #include <linux/module.h>
 #include <linux/platform_device.h>

-#include <plat/omapfb.h>
+#include "omapfb.h"

 static int htcherald_panel_init(struct lcd_panel *panel,
 					struct omapfb_device *fbdev)
-- 
1.6.4.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] Fix include problem. Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
  2009-12-03 13:28 [PATCH] Fix include problem. Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Belisko Marek
@ 2009-12-03 15:29 ` Cory Maccarrone
  2009-12-04 23:00   ` Tony Lindgren
  2009-12-04 22:57 ` [APPLIED] [PATCH] Fix include problem. Signed-off-by: Marek Belisko Tony Lindgren
  1 sibling, 1 reply; 5+ messages in thread
From: Cory Maccarrone @ 2009-12-03 15:29 UTC (permalink / raw)
  To: Belisko Marek; +Cc: linux-omap

On Thu, Dec 3, 2009 at 5:28 AM, Belisko Marek <marek.belisko@gmail.com> wrote:
>
> Hi,
>
> when make htcherald_defconfig on current linux-omap tree
> (82f1d8f22f2c65e70206e40a6f17688bf64a892c) compilation fails
> in drivers/video/omap/lcd_htcherald.c.
>
> Following patch fixed this problem.

Marek and I talked on IRC about this, and it turns out this is true on
the linux-omap master branch, but for-next compiles without issue,
possibly due to the header changes not having been done on the master
branch yet.

- Cory

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [APPLIED] [PATCH] Fix include problem. Signed-off-by: Marek Belisko
  2009-12-03 13:28 [PATCH] Fix include problem. Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Belisko Marek
  2009-12-03 15:29 ` Cory Maccarrone
@ 2009-12-04 22:57 ` Tony Lindgren
  1 sibling, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2009-12-04 22:57 UTC (permalink / raw)
  To: linux-omap

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: master

Initial commit ID (Likely to change): 3929b04e6e48d1294376eac04e47bb7cdf6a085d

PatchWorks
http://patchwork.kernel.org/patch/64520/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=3929b04e6e48d1294376eac04e47bb7cdf6a085d



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Fix include problem. Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
  2009-12-03 15:29 ` Cory Maccarrone
@ 2009-12-04 23:00   ` Tony Lindgren
  2009-12-07  9:11     ` Tomi Valkeinen
  0 siblings, 1 reply; 5+ messages in thread
From: Tony Lindgren @ 2009-12-04 23:00 UTC (permalink / raw)
  To: Cory Maccarrone, Tomi Valkeinen; +Cc: Belisko Marek, linux-omap

* Cory Maccarrone <darkstar6262@gmail.com> [091203 07:28]:
> On Thu, Dec 3, 2009 at 5:28 AM, Belisko Marek <marek.belisko@gmail.com> wrote:
> >
> > Hi,
> >
> > when make htcherald_defconfig on current linux-omap tree
> > (82f1d8f22f2c65e70206e40a6f17688bf64a892c) compilation fails
> > in drivers/video/omap/lcd_htcherald.c.
> >
> > Following patch fixed this problem.
> 
> Marek and I talked on IRC about this, and it turns out this is true on
> the linux-omap master branch, but for-next compiles without issue,
> possibly due to the header changes not having been done on the master
> branch yet.

Looks like Tomi's DSS2 moved this around. The DSS2 code is merged
into linux-omap master branch, but is not in omap for-next branch.

I've applied this to linux-omap master branch for now. 

Tomi, can you please add this to your fixes queue?

The patch in question is at:

http://patchwork.kernel.org/patch/64520/

Regards,

Tony

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Fix include problem. Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
  2009-12-04 23:00   ` Tony Lindgren
@ 2009-12-07  9:11     ` Tomi Valkeinen
  0 siblings, 0 replies; 5+ messages in thread
From: Tomi Valkeinen @ 2009-12-07  9:11 UTC (permalink / raw)
  To: ext Tony Lindgren
  Cc: Cory Maccarrone, Belisko Marek, linux-omap@vger.kernel.org

On Sat, 2009-12-05 at 00:00 +0100, ext Tony Lindgren wrote:
> * Cory Maccarrone <darkstar6262@gmail.com> [091203 07:28]:
> > On Thu, Dec 3, 2009 at 5:28 AM, Belisko Marek <marek.belisko@gmail.com> wrote:
> > >
> > > Hi,
> > >
> > > when make htcherald_defconfig on current linux-omap tree
> > > (82f1d8f22f2c65e70206e40a6f17688bf64a892c) compilation fails
> > > in drivers/video/omap/lcd_htcherald.c.
> > >
> > > Following patch fixed this problem.
> > 
> > Marek and I talked on IRC about this, and it turns out this is true on
> > the linux-omap master branch, but for-next compiles without issue,
> > possibly due to the header changes not having been done on the master
> > branch yet.
> 
> Looks like Tomi's DSS2 moved this around. The DSS2 code is merged
> into linux-omap master branch, but is not in omap for-next branch.
> 
> I've applied this to linux-omap master branch for now. 
> 
> Tomi, can you please add this to your fixes queue?
> 
> The patch in question is at:
> 
> http://patchwork.kernel.org/patch/64520/

Yes, I'll take it. And I actually anyway need to re-check before sending
pull request that all includes are correct, as there may have been new
LCDs/board files.

 Tomi



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2009-12-07  9:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-03 13:28 [PATCH] Fix include problem. Signed-off-by: Marek Belisko <marek.belisko@gmail.com> Belisko Marek
2009-12-03 15:29 ` Cory Maccarrone
2009-12-04 23:00   ` Tony Lindgren
2009-12-07  9:11     ` Tomi Valkeinen
2009-12-04 22:57 ` [APPLIED] [PATCH] Fix include problem. Signed-off-by: Marek Belisko Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox