[PATCH 2/2] usb: ehci: Allow EHCI to be built on OMAP3

[PATCH 2/2] usb: ehci: Allow EHCI to be built on OMAP3

[Anand Gadiyar]

usb: ehci: Allow EHCI to be built on OMAP3

OMAP3 chips have a built-in EHCI controller.
The recently introduced omap ehci-hcd driver missed
out on selecting USB_ARCH_HAS_EHCI in Kconfig.

Without this, the driver cannot be built.

Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
Cc: Vikram Pandita <vikram.pandita@ti.com>
Cc: Ajay Kumar Gupta <ajay.gupta@ti.com>
Acked-by: Felipe Balbi <felipe.balbi@nokia.com>
---
I've based this on current Linus' tree plus your usb
patch queue (gregkh-07-usb-2.6.32-rc6.patch).

 drivers/usb/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Index: linux-2.6/drivers/usb/Kconfig
===================================================================
--- linux-2.6.orig/drivers/usb/Kconfig	2009-11-06 04:03:39.000000000 -0800
+++ linux-2.6/drivers/usb/Kconfig	2009-11-06 04:04:08.000000000 -0800
@@ -61,6 +61,7 @@ config USB_ARCH_HAS_EHCI
 	default y if ARCH_W90X900
 	default y if ARCH_AT91SAM9G45
 	default y if ARCH_MXC
+	default y if ARCH_OMAP34XX
 	default PCI
 
 # ARM SA1111 chips have a non-PCI based "OHCI-compatible" USB host interface.

Re: [PATCH 2/2] usb: ehci: Allow EHCI to be built on OMAP3

[Olof Johansson]

OMAP34XX has EHCI, so select USB_ARCH_HAS_EHCI.

Signed-off-by: Olof Johansson <olof@lixom.net>

---

On Sat, Nov 07, 2009 at 01:16:32AM +0530, Anand Gadiyar wrote:
> usb: ehci: Allow EHCI to be built on OMAP3
> 
> OMAP3 chips have a built-in EHCI controller.
> The recently introduced omap ehci-hcd driver missed
> out on selecting USB_ARCH_HAS_EHCI in Kconfig.
> 
> Without this, the driver cannot be built.

This is a losing battle. It scales much better to select the option
from OMAP34XX, instead of starting to enumerate the various platforms
in drivers/usb.


diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index 034d990..a913b05 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -18,6 +18,7 @@ config ARCH_OMAP2430
 config ARCH_OMAP34XX
 	bool "OMAP34xx Based System"
 	depends on ARCH_OMAP3
+	select USB_ARCH_HAS_EHCI
 
 config ARCH_OMAP3430
 	bool "OMAP3430 support"

RE: [PATCH 2/2] usb: ehci: Allow EHCI to be built on OMAP3

[Gadiyar, Anand]

Olof Johansson wrote:
> 
> OMAP34XX has EHCI, so select USB_ARCH_HAS_EHCI.
> 
> Signed-off-by: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>

Acked-by: Anand Gadiyar <gadiyar-l0cyMroinI0@public.gmane.org>

> 
> ---
> 
> On Sat, Nov 07, 2009 at 01:16:32AM +0530, Anand Gadiyar wrote:
> > usb: ehci: Allow EHCI to be built on OMAP3
> > 
> > OMAP3 chips have a built-in EHCI controller.
> > The recently introduced omap ehci-hcd driver missed
> > out on selecting USB_ARCH_HAS_EHCI in Kconfig.
> > 
> > Without this, the driver cannot be built.
> 
> This is a losing battle. It scales much better to select the option
> from OMAP34XX, instead of starting to enumerate the various platforms
> in drivers/usb.
> 

Yes, I agree. Okay with me to drop my patch and use this one instead.

- Anand

> 
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index 034d990..a913b05 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -18,6 +18,7 @@ config ARCH_OMAP2430
>  config ARCH_OMAP34XX
>  	bool "OMAP34xx Based System"
>  	depends on ARCH_OMAP3
> +	select USB_ARCH_HAS_EHCI
>  
>  config ARCH_OMAP3430
>  	bool "OMAP3430 support"
> --
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[APPLIED] [PATCH 2/2] usb: ehci: Allow EHCI to be built on OMAP3

[Tony Lindgren]

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: for-next-vol2

Initial commit ID (Likely to change): caeaa2f4d7e3c8a2576bff1ca1b58e104e8f0266

PatchWorks
http://patchwork.kernel.org/patch/62727/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=caeaa2f4d7e3c8a2576bff1ca1b58e104e8f0266

Re: [APPLIED] [PATCH 2/2] usb: ehci: Allow EHCI to be built on OMAP3

[Sid Boyce]

On 07/12/09 22:11, Tony Lindgren wrote:
> This patch has been applied to the linux-omap
> by youw fwiendly patch wobot.
> 
> Branch in linux-omap: for-next-vol2
> 
> Initial commit ID (Likely to change): caeaa2f4d7e3c8a2576bff1ca1b58e104e8f0266
> 
> PatchWorks
> http://patchwork.kernel.org/patch/62727/
> 
> Git (Likely to change, and takes a while to get mirrored)
> http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=caeaa2f4d7e3c8a2576bff1ca1b58e104e8f0266
> 
> 
Thanks Tony,
It seemed these patches were somehow lost upstream.
Regards
Sid.
-- 
Sid Boyce ... Hamradio License G3VBV, Licensed Private Pilot
Emeritus IBM/Amdahl Mainframes and Sun/Fujitsu Servers Tech Support
Specialist, Cricket Coach
Microsoft Windows Free Zone - Linux used for all Computing Tasks