[PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM board file

[PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM board file

[hvaibhav]

From: Vaibhav Hiremath <hvaibhav@ti.com>

With recent changes happened in OMAP2/3 DSS library for regulator interface, it
is required to define DSI regulator supply, without this DSS (in turn Fbdev)
fails to get regulator.

Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
---
 arch/arm/mach-omap2/board-omap3evm.c |   16 +++++++++++-----
 1 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-omap2/board-omap3evm.c
index 017bb2f..a05de10 100644
--- a/arch/arm/mach-omap2/board-omap3evm.c
+++ b/arch/arm/mach-omap2/board-omap3evm.c
@@ -514,9 +514,15 @@ static struct regulator_init_data omap3_evm_vdac = {
 };

 /* VPLL2 for digital video outputs */
-static struct regulator_consumer_supply omap3_evm_vpll2_supply = {
-	.supply		= "vdvi",
-	.dev		= &omap3_evm_lcd_device.dev,
+static struct regulator_consumer_supply omap3_evm_vpll2_supplies[] = {
+	{
+		.supply		= "vdvi",
+		.dev		= &omap3_evm_lcd_device.dev,
+	},
+	{
+		.supply		= "vdds_dsi",
+		.dev		= &omap3_evm_dss_device.dev,
+	},
 };

 static struct regulator_init_data omap3_evm_vpll2 = {
@@ -530,8 +536,8 @@ static struct regulator_init_data omap3_evm_vpll2 = {
 		.valid_ops_mask		= REGULATOR_CHANGE_MODE
 					| REGULATOR_CHANGE_STATUS,
 	},
-	.num_consumer_supplies	= 1,
-	.consumer_supplies	= &omap3_evm_vpll2_supply,
+	.num_consumer_supplies	= ARRAY_SIZE(omap3_evm_vpll2_supplies),
+	.consumer_supplies	= omap3_evm_vpll2_supplies,
 };

 static struct twl4030_platform_data omap3evm_twldata = {
--
1.6.2.4

Re: [PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM board file

[Tomi Valkeinen]

Hi,

On Thu, 2010-03-11 at 09:55 +0100, ext hvaibhav@ti.com wrote:
> From: Vaibhav Hiremath <hvaibhav@ti.com>
> 
> With recent changes happened in OMAP2/3 DSS library for regulator interface, it
> is required to define DSI regulator supply, without this DSS (in turn Fbdev)
> fails to get regulator.
> 
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> ---
>  arch/arm/mach-omap2/board-omap3evm.c |   16 +++++++++++-----
>  1 files changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-omap2/board-omap3evm.c
> index 017bb2f..a05de10 100644
> --- a/arch/arm/mach-omap2/board-omap3evm.c
> +++ b/arch/arm/mach-omap2/board-omap3evm.c
> @@ -514,9 +514,15 @@ static struct regulator_init_data omap3_evm_vdac = {
>  };
> 
>  /* VPLL2 for digital video outputs */
> -static struct regulator_consumer_supply omap3_evm_vpll2_supply = {
> -	.supply		= "vdvi",
> -	.dev		= &omap3_evm_lcd_device.dev,
> +static struct regulator_consumer_supply omap3_evm_vpll2_supplies[] = {
> +	{
> +		.supply		= "vdvi",
> +		.dev		= &omap3_evm_lcd_device.dev,
> +	},

Are you sure vdvi is required by the panel? At least the panel in
3430SDP doesn't require it.

 Tomi

RE: [PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM board file

[Hiremath, Vaibhav]

[-- Attachment #1: Type: text/plain, Size: 2185 bytes --]


> -----Original Message-----
> From: Tomi Valkeinen [mailto:tomi.valkeinen@nokia.com]
> Sent: Thursday, March 11, 2010 2:29 PM
> To: Hiremath, Vaibhav
> Cc: linux-omap@vger.kernel.org; tony@atomide.com
> Subject: Re: [PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM board
> file
> 
> Hi,
> 
> On Thu, 2010-03-11 at 09:55 +0100, ext hvaibhav@ti.com wrote:
> > From: Vaibhav Hiremath <hvaibhav@ti.com>
> >
> > With recent changes happened in OMAP2/3 DSS library for regulator
> interface, it
> > is required to define DSI regulator supply, without this DSS (in turn
> Fbdev)
> > fails to get regulator.
> >
> > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> > ---
> >  arch/arm/mach-omap2/board-omap3evm.c |   16 +++++++++++-----
> >  1 files changed, 11 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-
> omap2/board-omap3evm.c
> > index 017bb2f..a05de10 100644
> > --- a/arch/arm/mach-omap2/board-omap3evm.c
> > +++ b/arch/arm/mach-omap2/board-omap3evm.c
> > @@ -514,9 +514,15 @@ static struct regulator_init_data omap3_evm_vdac = {
> >  };
> >
> >  /* VPLL2 for digital video outputs */
> > -static struct regulator_consumer_supply omap3_evm_vpll2_supply = {
> > -	.supply		= "vdvi",
> > -	.dev		= &omap3_evm_lcd_device.dev,
> > +static struct regulator_consumer_supply omap3_evm_vpll2_supplies[] = {
> > +	{
> > +		.supply		= "vdvi",
> > +		.dev		= &omap3_evm_lcd_device.dev,
> > +	},
> 
> Are you sure vdvi is required by the panel? At least the panel in
> 3430SDP doesn't require it.
[Hiremath, Vaibhav] As I mentioned before also, we don't need vdvi supply for OMAP3EVM. Infact there is no supply like vdvi coming out of TWL4030
Since it was being used in panel file I had defined it. But now I can see that we are no longer using vdvi supply, so I can safely remove this supply. Thanks for pointing me to this.

I have created another patch which will replace the vdvi with vdds_dsi regulator supply; I have tested it on OMAP3EVM.

Please merge this patch, without this OMAP3EVM DSS/Fbdev will fail in regulator_get.

Thanks,
Vaibhav


> 
>  Tomi
> 


[-- Attachment #2: 0001-OMAP-Replace-vdvi-with-vdds_dsi-regulator-supply-in.patch --]
[-- Type: application/octet-stream, Size: 1152 bytes --]

From 5ad73cda583b4fab5e33f955dd9e41cd725eef39 Mon Sep 17 00:00:00 2001
From: Vaibhav Hiremath <hvaibhav@ti.com>
Date: Thu, 11 Mar 2010 14:05:29 +0530
Subject: [PATCH] OMAP: Replace vdvi with vdds_dsi regulator supply in OMAP3EVM board file

With recent changes happened in OMAP2/3 DSS library for regulator interface, it
is required to define DSI regulator supply, and since we don't need VDVI
supply so remove it.

Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
---
 arch/arm/mach-omap2/board-omap3evm.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-omap2/board-omap3evm.c
index 017bb2f..ea1014b 100644
--- a/arch/arm/mach-omap2/board-omap3evm.c
+++ b/arch/arm/mach-omap2/board-omap3evm.c
@@ -515,8 +515,8 @@ static struct regulator_init_data omap3_evm_vdac = {
 
 /* VPLL2 for digital video outputs */
 static struct regulator_consumer_supply omap3_evm_vpll2_supply = {
-	.supply		= "vdvi",
-	.dev		= &omap3_evm_lcd_device.dev,
+	.supply		= "vdds_dsi",
+	.dev		= &omap3_evm_dss_device.dev,
 };
 
 static struct regulator_init_data omap3_evm_vpll2 = {
-- 
1.6.2.4

RE: [PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM board file

[Tomi Valkeinen]

> > Are you sure vdvi is required by the panel? At least the panel in
> > 3430SDP doesn't require it.
> [Hiremath, Vaibhav] As I mentioned before also, we don't need vdvi supply for OMAP3EVM. Infact there is no supply like vdvi coming out of TWL4030
> Since it was being used in panel file I had defined it. But now I can see that we are no longer using vdvi supply, so I can safely remove this supply. Thanks for pointing me to this.
> 
> I have created another patch which will replace the vdvi with vdds_dsi regulator supply; I have tested it on OMAP3EVM.
> 
> Please merge this patch, without this OMAP3EVM DSS/Fbdev will fail in regulator_get.

Acked-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>

Board file changes will go through Tony. And you should generally send
the patches as inline patches, not attachments.

 Tomi

RE: [PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM board file

[Hiremath, Vaibhav]

> -----Original Message-----
> From: Tomi Valkeinen [mailto:tomi.valkeinen@nokia.com]
> Sent: Thursday, March 11, 2010 2:58 PM
> To: Hiremath, Vaibhav
> Cc: linux-omap@vger.kernel.org; tony@atomide.com
> Subject: RE: [PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM board
> file
> 
> 
> > > Are you sure vdvi is required by the panel? At least the panel in
> > > 3430SDP doesn't require it.
> > [Hiremath, Vaibhav] As I mentioned before also, we don't need vdvi supply
> for OMAP3EVM. Infact there is no supply like vdvi coming out of TWL4030
> > Since it was being used in panel file I had defined it. But now I can see
> that we are no longer using vdvi supply, so I can safely remove this supply.
> Thanks for pointing me to this.
> >
> > I have created another patch which will replace the vdvi with vdds_dsi
> regulator supply; I have tested it on OMAP3EVM.
> >
> > Please merge this patch, without this OMAP3EVM DSS/Fbdev will fail in
> regulator_get.
> 
> Acked-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
> 
> Board file changes will go through Tony. And you should generally send
> the patches as inline patches, not attachments.
[Hiremath, Vaibhav] Done, sent again.

Thanks,
Vaibhav

> 
>  Tomi
> 

RE: [PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM board file

[Hiremath, Vaibhav]

> -----Original Message-----
> From: Hiremath, Vaibhav
> Sent: Thursday, March 11, 2010 2:49 PM
> To: 'Tomi Valkeinen'
> Cc: linux-omap@vger.kernel.org; tony@atomide.com
> Subject: RE: [PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM board
> file
> 
> 
> > -----Original Message-----
> > From: Tomi Valkeinen [mailto:tomi.valkeinen@nokia.com]
> > Sent: Thursday, March 11, 2010 2:29 PM
> > To: Hiremath, Vaibhav
> > Cc: linux-omap@vger.kernel.org; tony@atomide.com
> > Subject: Re: [PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM board
> > file
> >
> > Hi,
> >
> > On Thu, 2010-03-11 at 09:55 +0100, ext hvaibhav@ti.com wrote:
> > > From: Vaibhav Hiremath <hvaibhav@ti.com>
> > >
> > > With recent changes happened in OMAP2/3 DSS library for regulator
> > interface, it
> > > is required to define DSI regulator supply, without this DSS (in turn
> > Fbdev)
> > > fails to get regulator.
> > >
> > > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> > > ---
> > >  arch/arm/mach-omap2/board-omap3evm.c |   16 +++++++++++-----
> > >  1 files changed, 11 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-
> > omap2/board-omap3evm.c
> > > index 017bb2f..a05de10 100644
> > > --- a/arch/arm/mach-omap2/board-omap3evm.c
> > > +++ b/arch/arm/mach-omap2/board-omap3evm.c
> > > @@ -514,9 +514,15 @@ static struct regulator_init_data omap3_evm_vdac =
> {
> > >  };
> > >
> > >  /* VPLL2 for digital video outputs */
> > > -static struct regulator_consumer_supply omap3_evm_vpll2_supply = {
> > > -	.supply		= "vdvi",
> > > -	.dev		= &omap3_evm_lcd_device.dev,
> > > +static struct regulator_consumer_supply omap3_evm_vpll2_supplies[] = {
> > > +	{
> > > +		.supply		= "vdvi",
> > > +		.dev		= &omap3_evm_lcd_device.dev,
> > > +	},
> >
> > Are you sure vdvi is required by the panel? At least the panel in
> > 3430SDP doesn't require it.
> [Hiremath, Vaibhav] As I mentioned before also, we don't need vdvi supply
> for OMAP3EVM. Infact there is no supply like vdvi coming out of TWL4030
> Since it was being used in panel file I had defined it. But now I can see
> that we are no longer using vdvi supply, so I can safely remove this supply.
> Thanks for pointing me to this.
> 
> I have created another patch which will replace the vdvi with vdds_dsi
> regulator supply; I have tested it on OMAP3EVM.
> 
> Please merge this patch, without this OMAP3EVM DSS/Fbdev will fail in
> regulator_get.
> 
> Thanks,
> Vaibhav
> 
[Hiremath, Vaibhav] Tomi,

Also, there are few patches which still are not merged to main-line, like

commit 98d31bf6566be9e716f6dfdce8eb39d1c1097b7c
Author: Vaibhav Hiremath <hvaibhav@ti.com>
Date:   Wed Jan 13 17:17:10 2010 +0530

    OMAP: AM3517: Enable DSS2 for AM3517EVM board

    Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
    [tomi.valkeinen@nokia.com: removed the board file changes]
    Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>

commit bb8a88ac57564e2e7ccc813be1d74c45bb467549
Author: Vaibhav Hiremath <hvaibhav@ti.com>
Date:   Mon Jan 4 15:34:16 2010 +0100

    OMAP: Enable DSS2 for OMAP3EVM board

    Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
    [tomi.valkeinen@nokia.com: removed the board file changes]
    Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>


Any specific reason why are holding this back?

Thanks,
Vaibhav

> 
> >
> >  Tomi
> >

RE: [PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM board file

[Tomi Valkeinen]

> [Hiremath, Vaibhav] Tomi,
> 
> Also, there are few patches which still are not merged to main-line, like
> 
> commit 98d31bf6566be9e716f6dfdce8eb39d1c1097b7c
> Author: Vaibhav Hiremath <hvaibhav@ti.com>
> Date:   Wed Jan 13 17:17:10 2010 +0530
> 
>     OMAP: AM3517: Enable DSS2 for AM3517EVM board
> 
>     Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
>     [tomi.valkeinen@nokia.com: removed the board file changes]
>     Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
> 
> commit bb8a88ac57564e2e7ccc813be1d74c45bb467549
> Author: Vaibhav Hiremath <hvaibhav@ti.com>
> Date:   Mon Jan 4 15:34:16 2010 +0100
> 
>     OMAP: Enable DSS2 for OMAP3EVM board
> 
>     Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
>     [tomi.valkeinen@nokia.com: removed the board file changes]
>     Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
> 
> 
> Any specific reason why are holding this back?

Board file patches go through linux-omap. Those patches seem to be in
linux-omap/master, so I guess they'll go through at some point soon.

 Tomi

RE: [PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM board file

[Hiremath, Vaibhav]

> -----Original Message-----
> From: Tomi Valkeinen [mailto:tomi.valkeinen@nokia.com]
> Sent: Thursday, March 11, 2010 3:01 PM
> To: Hiremath, Vaibhav
> Cc: linux-omap@vger.kernel.org; tony@atomide.com
> Subject: RE: [PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM board
> file
> 
> > [Hiremath, Vaibhav] Tomi,
> >
> > Also, there are few patches which still are not merged to main-line, like
> >
> > commit 98d31bf6566be9e716f6dfdce8eb39d1c1097b7c
> > Author: Vaibhav Hiremath <hvaibhav@ti.com>
> > Date:   Wed Jan 13 17:17:10 2010 +0530
> >
> >     OMAP: AM3517: Enable DSS2 for AM3517EVM board
> >
> >     Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> >     [tomi.valkeinen@nokia.com: removed the board file changes]
> >     Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
> >
> > commit bb8a88ac57564e2e7ccc813be1d74c45bb467549
> > Author: Vaibhav Hiremath <hvaibhav@ti.com>
> > Date:   Mon Jan 4 15:34:16 2010 +0100
> >
> >     OMAP: Enable DSS2 for OMAP3EVM board
> >
> >     Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> >     [tomi.valkeinen@nokia.com: removed the board file changes]
> >     Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
> >
> >
> > Any specific reason why are holding this back?
> 
> Board file patches go through linux-omap. Those patches seem to be in
> linux-omap/master, so I guess they'll go through at some point soon.
> 
[Hiremath, Vaibhav] No, they are not part of linux-omap/master. 

Thanks,
Vaibhav

>  Tomi
> 

RE: [PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM board file

[Tomi Valkeinen]

On Thu, 2010-03-11 at 10:39 +0100, ext Hiremath, Vaibhav wrote:
> > -----Original Message-----
> > From: Tomi Valkeinen [mailto:tomi.valkeinen@nokia.com]
> > Sent: Thursday, March 11, 2010 3:01 PM
> > To: Hiremath, Vaibhav
> > Cc: linux-omap@vger.kernel.org; tony@atomide.com
> > Subject: RE: [PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM board
> > file
> > 
> > > [Hiremath, Vaibhav] Tomi,
> > >
> > > Also, there are few patches which still are not merged to main-line, like
> > >
> > > commit 98d31bf6566be9e716f6dfdce8eb39d1c1097b7c
> > > Author: Vaibhav Hiremath <hvaibhav@ti.com>
> > > Date:   Wed Jan 13 17:17:10 2010 +0530
> > >
> > >     OMAP: AM3517: Enable DSS2 for AM3517EVM board
> > >
> > >     Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> > >     [tomi.valkeinen@nokia.com: removed the board file changes]
> > >     Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
> > >
> > > commit bb8a88ac57564e2e7ccc813be1d74c45bb467549
> > > Author: Vaibhav Hiremath <hvaibhav@ti.com>
> > > Date:   Mon Jan 4 15:34:16 2010 +0100
> > >
> > >     OMAP: Enable DSS2 for OMAP3EVM board
> > >
> > >     Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> > >     [tomi.valkeinen@nokia.com: removed the board file changes]
> > >     Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
> > >
> > >
> > > Any specific reason why are holding this back?
> > 
> > Board file patches go through linux-omap. Those patches seem to be in
> > linux-omap/master, so I guess they'll go through at some point soon.
> > 
> [Hiremath, Vaibhav] No, they are not part of linux-omap/master. 

Yes, they are =)

http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=c3d33329f400587976613c0224ffa2e266677cfb

 Tomi

RE: [PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM board file

[Hiremath, Vaibhav]

> -----Original Message-----
> From: Tomi Valkeinen [mailto:tomi.valkeinen@nokia.com]
> Sent: Thursday, March 11, 2010 3:14 PM
> To: Hiremath, Vaibhav
> Cc: linux-omap@vger.kernel.org; tony@atomide.com
> Subject: RE: [PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM board
> file
> 
> On Thu, 2010-03-11 at 10:39 +0100, ext Hiremath, Vaibhav wrote:
> > > -----Original Message-----
> > > From: Tomi Valkeinen [mailto:tomi.valkeinen@nokia.com]
> > > Sent: Thursday, March 11, 2010 3:01 PM
> > > To: Hiremath, Vaibhav
> > > Cc: linux-omap@vger.kernel.org; tony@atomide.com
> > > Subject: RE: [PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM
> board
> > > file
> > >
> > > > [Hiremath, Vaibhav] Tomi,
> > > >
> > > > Also, there are few patches which still are not merged to main-line,
> like
> > > >
> > > > commit 98d31bf6566be9e716f6dfdce8eb39d1c1097b7c
> > > > Author: Vaibhav Hiremath <hvaibhav@ti.com>
> > > > Date:   Wed Jan 13 17:17:10 2010 +0530
> > > >
> > > >     OMAP: AM3517: Enable DSS2 for AM3517EVM board
> > > >
> > > >     Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> > > >     [tomi.valkeinen@nokia.com: removed the board file changes]
> > > >     Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
> > > >
> > > > commit bb8a88ac57564e2e7ccc813be1d74c45bb467549
> > > > Author: Vaibhav Hiremath <hvaibhav@ti.com>
> > > > Date:   Mon Jan 4 15:34:16 2010 +0100
> > > >
> > > >     OMAP: Enable DSS2 for OMAP3EVM board
> > > >
> > > >     Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> > > >     [tomi.valkeinen@nokia.com: removed the board file changes]
> > > >     Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
> > > >
> > > >
> > > > Any specific reason why are holding this back?
> > >
> > > Board file patches go through linux-omap. Those patches seem to be in
> > > linux-omap/master, so I guess they'll go through at some point soon.
> > >
> > [Hiremath, Vaibhav] No, they are not part of linux-omap/master.
> 
> Yes, they are =)
> 
> http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-
> 2.6.git;a=commit;h=c3d33329f400587976613c0224ffa2e266677cfb
> 
[Hiremath, Vaibhav] Tomi, the above patch has already present in main-line. The patch I am talking about is defconfig update for DSS on both OMAP3EVM and AM3517EVM.
It happened to be the same commit description at your repository when you split it.

Thanks,
Vaibhav


>  Tomi
> 

RE: [PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM board file

[Tomi Valkeinen]

On Thu, 2010-03-11 at 11:03 +0100, ext Hiremath, Vaibhav wrote:
> > 
> [Hiremath, Vaibhav] Tomi, the above patch has already present in main-line. The patch I am talking about is defconfig update for DSS on both OMAP3EVM and AM3517EVM.
> It happened to be the same commit description at your repository when you split it.

Yes, you are right. I seem to have confused the patch with board changes
and defconf changes. I'll take the defconfig changes to my next pull
request.

I also changed the patch descriptions a bit, so that I won't mix them up
again =).

 Tomi

Re: [PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM board file

[Mark Brown]

On Thu, Mar 11, 2010 at 02:25:17PM +0530, hvaibhav@ti.com wrote:

> +static struct regulator_consumer_supply omap3_evm_vpll2_supplies[] = {
> +	{
> +		.supply		= "vdvi",
> +		.dev		= &omap3_evm_lcd_device.dev,
> +	},

Please use dev_name for new code.

RE: [PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM board file

[Hiremath, Vaibhav]

> -----Original Message-----
> From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
> Sent: Thursday, March 11, 2010 6:18 PM
> To: Hiremath, Vaibhav
> Cc: linux-omap@vger.kernel.org; tony@atomide.com; Tomi.Valkeinen@nokia.com
> Subject: Re: [PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM board
> file
> 
> On Thu, Mar 11, 2010 at 02:25:17PM +0530, hvaibhav@ti.com wrote:
> 
> > +static struct regulator_consumer_supply omap3_evm_vpll2_supplies[] = {
> > +	{
> > +		.supply		= "vdvi",
> > +		.dev		= &omap3_evm_lcd_device.dev,
> > +	},
> 
> Please use dev_name for new code.
[Hiremath, Vaibhav] Ok, will change and submit it again shortly.

Thanks,
Vaibhav

[APPLIED] [PATCH-Fix] OMAP: Add DSI regulator supply to OMAP3EVM board

[Tony Lindgren]

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Initial commit ID (Likely to change): 6ae6dad6e6da9cc46c3272aeff62d28c6348ace7

PatchWorks
http://patchwork.kernel.org/patch/84823/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=6ae6dad6e6da9cc46c3272aeff62d28c6348ace7