From: Tony Lindgren <tony@atomide.com>
To: soc@kernel.org
Cc: arm@kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Tony Lindgren" <tony@atomide.com>,
Lee Jones <lee.jones@linaro.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Pavel Machek <pavel@ucw.cz>
Subject: [GIT PULL] Fix LCD backlight issue for droid4
Date: Fri, 21 Feb 2020 08:55:55 -0800 [thread overview]
Message-ID: <pull-1582303901-96693@atomide.com> (raw)
From: "Tony Lindgren" <tony@atomide.com>
The following changes since commit bb6d3fb354c5ee8d6bde2d576eb7220ea09862b9:
Linux 5.6-rc1 (2020-02-09 16:08:48 -0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap tags/omap-for-v5.6/droid4-lcd-fix-signed
for you to fetch changes up to 10dc62d0ae4167770e9ab150fc1ab55baa82e010:
ARM: dts: droid4: Configure LED backlight for lm3532 (2020-02-20 06:51:13 -0800)
----------------------------------------------------------------
Fix LCD backlight issue for droid4 for v5.6
There was a bit of an integration glitch with the LED backlight series.
The LED related parts got merged into v5.6-rc1, but the actual backlight
driver got left out.
This caused an issue on at least droid4 where the LCD backlight can not
yet be enabled automatically. And the LCD backlight can no longer be
enabled manually either via sysfs.
The integration glitch happened because some pending comments from me.
There was some confusion on which device tree property we should use for
the default brightness property.
After discussing how to fix this on the mailing lists, we came to the
conclusion that it's best to fix this issue properly by adding the
missing driver.
The other solutions would mean backpedaling and try to come up with some
temporary solution that really does not solve the issue for users. The
patch for led_bl.c has been around for quite a while and tested by many
users and was assumed to be merged as part of the LED backlight series.
For the brightness property to use, we ended up using the more common
"default-brightness-level" rather than "default-brightness" used by
some backlight drivers.
----------------------------------------------------------------
Tomi Valkeinen (1):
backlight: add led-backlight driver
Tony Lindgren (1):
ARM: dts: droid4: Configure LED backlight for lm3532
arch/arm/boot/dts/motorola-mapphone-common.dtsi | 13 +-
arch/arm/configs/omap2plus_defconfig | 1 +
drivers/video/backlight/Kconfig | 7 +
drivers/video/backlight/Makefile | 1 +
drivers/video/backlight/led_bl.c | 260 ++++++++++++++++++++++++
5 files changed, 280 insertions(+), 2 deletions(-)
create mode 100644 drivers/video/backlight/led_bl.c
reply other threads:[~2020-02-21 16:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull-1582303901-96693@atomide.com \
--to=tony@atomide.com \
--cc=arm@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=soc@kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).