* [PATCH 5/7] OMAP4-HSMMC: Adds Dummy Interface clock's for MMC controllers
@ 2010-04-21 18:20 kishore kadiyala
2010-04-22 1:14 ` Paul Walmsley
2010-04-22 6:39 ` Russell King
0 siblings, 2 replies; 5+ messages in thread
From: kishore kadiyala @ 2010-04-21 18:20 UTC (permalink / raw)
To: linux-mmc, linux-omap
Cc: madhu.cr, jarkko.lavinen, tony, rmk+lkml, santosh.shilimkar
This patch adds dummy Interface clocks for MMC controllers
Signed-off-by: Kishore Kadiyala <kishore.kadiyala@ti.com>
---
arch/arm/mach-omap2/clock44xx_data.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c
index 1dd7dc8..6177a89 100644
--- a/arch/arm/mach-omap2/clock44xx_data.c
+++ b/arch/arm/mach-omap2/clock44xx_data.c
@@ -2675,11 +2675,11 @@ static struct omap_clk omap44xx_clks[] = {
CLK("omap-mcspi.2", "ick", &dummy_ck, CK_443X),
CLK("omap-mcspi.3", "ick", &dummy_ck, CK_443X),
CLK("omap-mcspi.4", "ick", &dummy_ck, CK_443X),
- CLK("mmci-omap-hs.0", "ick", &dummy_ck, CK_443X),
- CLK("mmci-omap-hs.1", "ick", &dummy_ck, CK_443X),
- CLK("mmci-omap-hs.2", "ick", &dummy_ck, CK_443X),
- CLK("mmci-omap-hs.3", "ick", &dummy_ck, CK_443X),
- CLK("mmci-omap-hs.4", "ick", &dummy_ck, CK_443X),
+ CLK("mmci-omap-hs.0", "ick", &dummy_ck, CK_443X),
+ CLK("mmci-omap-hs.1", "ick", &dummy_ck, CK_443X),
+ CLK("mmci-omap-hs.2", "ick", &dummy_ck, CK_443X),
+ CLK("mmci-omap-hs.3", "ick", &dummy_ck, CK_443X),
+ CLK("mmci-omap-hs.4", "ick", &dummy_ck, CK_443X),
CLK(NULL, "uart1_ick", &dummy_ck, CK_443X),
CLK(NULL, "uart2_ick", &dummy_ck, CK_443X),
CLK(NULL, "uart3_ick", &dummy_ck, CK_443X),
--
1.6.3.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 5/7] OMAP4-HSMMC: Adds Dummy Interface clock's for MMC controllers
2010-04-21 18:20 [PATCH 5/7] OMAP4-HSMMC: Adds Dummy Interface clock's for MMC controllers kishore kadiyala
@ 2010-04-22 1:14 ` Paul Walmsley
2010-04-22 4:11 ` kishore kadiyala
2010-04-22 6:39 ` Russell King
1 sibling, 1 reply; 5+ messages in thread
From: Paul Walmsley @ 2010-04-22 1:14 UTC (permalink / raw)
To: kishore kadiyala
Cc: linux-mmc, linux-omap, madhu.cr, jarkko.lavinen, tony, rmk+lkml,
santosh.shilimkar
Kishore,
On Wed, 21 Apr 2010, kishore kadiyala wrote:
> This patch adds dummy Interface clocks for MMC controllers
Um, your patch removes the existing dummy interface clocks and adds them
back again. Or is there some other point?
> Signed-off-by: Kishore Kadiyala <kishore.kadiyala@ti.com>
> ---
> arch/arm/mach-omap2/clock44xx_data.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c
> index 1dd7dc8..6177a89 100644
> --- a/arch/arm/mach-omap2/clock44xx_data.c
> +++ b/arch/arm/mach-omap2/clock44xx_data.c
> @@ -2675,11 +2675,11 @@ static struct omap_clk omap44xx_clks[] = {
> CLK("omap-mcspi.2", "ick", &dummy_ck, CK_443X),
> CLK("omap-mcspi.3", "ick", &dummy_ck, CK_443X),
> CLK("omap-mcspi.4", "ick", &dummy_ck, CK_443X),
> - CLK("mmci-omap-hs.0", "ick", &dummy_ck, CK_443X),
> - CLK("mmci-omap-hs.1", "ick", &dummy_ck, CK_443X),
> - CLK("mmci-omap-hs.2", "ick", &dummy_ck, CK_443X),
> - CLK("mmci-omap-hs.3", "ick", &dummy_ck, CK_443X),
> - CLK("mmci-omap-hs.4", "ick", &dummy_ck, CK_443X),
> + CLK("mmci-omap-hs.0", "ick", &dummy_ck, CK_443X),
> + CLK("mmci-omap-hs.1", "ick", &dummy_ck, CK_443X),
> + CLK("mmci-omap-hs.2", "ick", &dummy_ck, CK_443X),
> + CLK("mmci-omap-hs.3", "ick", &dummy_ck, CK_443X),
> + CLK("mmci-omap-hs.4", "ick", &dummy_ck, CK_443X),
> CLK(NULL, "uart1_ick", &dummy_ck, CK_443X),
> CLK(NULL, "uart2_ick", &dummy_ck, CK_443X),
> CLK(NULL, "uart3_ick", &dummy_ck, CK_443X),
> --
> 1.6.3.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
- Paul
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 5/7] OMAP4-HSMMC: Adds Dummy Interface clock's for MMC controllers
2010-04-22 1:14 ` Paul Walmsley
@ 2010-04-22 4:11 ` kishore kadiyala
0 siblings, 0 replies; 5+ messages in thread
From: kishore kadiyala @ 2010-04-22 4:11 UTC (permalink / raw)
To: Paul Walmsley
Cc: kishore kadiyala, linux-mmc, linux-omap, madhu.cr, jarkko.lavinen,
tony, rmk+lkml, santosh.shilimkar
On Thu, Apr 22, 2010 at 6:44 AM, Paul Walmsley <paul@pwsan.com> wrote:
> Kishore,
>
> On Wed, 21 Apr 2010, kishore kadiyala wrote:
>
>> This patch adds dummy Interface clocks for MMC controllers
>
> Um, your patch removes the existing dummy interface clocks and adds them
> back again. Or is there some other point?
My bad , will repost in New series.
Regards,
Kishore
>
>> Signed-off-by: Kishore Kadiyala <kishore.kadiyala@ti.com>
>> ---
>> arch/arm/mach-omap2/clock44xx_data.c | 10 +++++-----
>> 1 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c
>> index 1dd7dc8..6177a89 100644
>> --- a/arch/arm/mach-omap2/clock44xx_data.c
>> +++ b/arch/arm/mach-omap2/clock44xx_data.c
>> @@ -2675,11 +2675,11 @@ static struct omap_clk omap44xx_clks[] = {
>> CLK("omap-mcspi.2", "ick", &dummy_ck, CK_443X),
>> CLK("omap-mcspi.3", "ick", &dummy_ck, CK_443X),
>> CLK("omap-mcspi.4", "ick", &dummy_ck, CK_443X),
>> - CLK("mmci-omap-hs.0", "ick", &dummy_ck, CK_443X),
>> - CLK("mmci-omap-hs.1", "ick", &dummy_ck, CK_443X),
>> - CLK("mmci-omap-hs.2", "ick", &dummy_ck, CK_443X),
>> - CLK("mmci-omap-hs.3", "ick", &dummy_ck, CK_443X),
>> - CLK("mmci-omap-hs.4", "ick", &dummy_ck, CK_443X),
>> + CLK("mmci-omap-hs.0", "ick", &dummy_ck, CK_443X),
>> + CLK("mmci-omap-hs.1", "ick", &dummy_ck, CK_443X),
>> + CLK("mmci-omap-hs.2", "ick", &dummy_ck, CK_443X),
>> + CLK("mmci-omap-hs.3", "ick", &dummy_ck, CK_443X),
>> + CLK("mmci-omap-hs.4", "ick", &dummy_ck, CK_443X),
>> CLK(NULL, "uart1_ick", &dummy_ck, CK_443X),
>> CLK(NULL, "uart2_ick", &dummy_ck, CK_443X),
>> CLK(NULL, "uart3_ick", &dummy_ck, CK_443X),
>> --
>> 1.6.3.3
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
>
> - Paul
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 5/7] OMAP4-HSMMC: Adds Dummy Interface clock's for MMC controllers
2010-04-21 18:20 [PATCH 5/7] OMAP4-HSMMC: Adds Dummy Interface clock's for MMC controllers kishore kadiyala
2010-04-22 1:14 ` Paul Walmsley
@ 2010-04-22 6:39 ` Russell King
2010-05-04 6:21 ` kishore kadiyala
1 sibling, 1 reply; 5+ messages in thread
From: Russell King @ 2010-04-22 6:39 UTC (permalink / raw)
To: kishore kadiyala
Cc: linux-mmc, linux-omap, madhu.cr, jarkko.lavinen, tony,
santosh.shilimkar
On Wed, Apr 21, 2010 at 11:50:56PM +0530, kishore kadiyala wrote:
> This patch adds dummy Interface clocks for MMC controllers
Looks to me as if it changes the formatting; it doesn't seem to be adding
anything.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 5/7] OMAP4-HSMMC: Adds Dummy Interface clock's for MMC controllers
2010-04-22 6:39 ` Russell King
@ 2010-05-04 6:21 ` kishore kadiyala
0 siblings, 0 replies; 5+ messages in thread
From: kishore kadiyala @ 2010-05-04 6:21 UTC (permalink / raw)
To: Russell King
Cc: kishore kadiyala, linux-mmc, linux-omap, madhu.cr, jarkko.lavinen,
tony, santosh.shilimkar
On Thu, Apr 22, 2010 at 12:09 PM, Russell King <rmk@arm.linux.org.uk> wrote:
> On Wed, Apr 21, 2010 at 11:50:56PM +0530, kishore kadiyala wrote:
>> This patch adds dummy Interface clocks for MMC controllers
>
> Looks to me as if it changes the formatting; it doesn't seem to be adding
> anything.
I have already asked to drop this patch will be posting next version soon
Regards,
Kishore
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-05-04 6:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-21 18:20 [PATCH 5/7] OMAP4-HSMMC: Adds Dummy Interface clock's for MMC controllers kishore kadiyala
2010-04-22 1:14 ` Paul Walmsley
2010-04-22 4:11 ` kishore kadiyala
2010-04-22 6:39 ` Russell King
2010-05-04 6:21 ` kishore kadiyala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).