From: "Arnd Bergmann" <arnd@arndb.de>
To: "Thomas Zimmermann" <tzimmermann@suse.de>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Sam Ravnborg" <sam@ravnborg.org>
Cc: Linux-Arch <linux-arch@vger.kernel.org>,
linux-fbdev@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-parisc@vger.kernel.org, "Helge Deller" <deller@gmx.de>,
"Huacai Chen" <chenhuacai@kernel.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
"James E . J . Bottomley" <James.Bottomley@hansenpartnership.com>,
linux-m68k@lists.linux-m68k.org,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
loongarch@lists.linux.dev, "Vineet Gupta" <vgupta@kernel.org>,
sparclinux@vger.kernel.org, "WANG Xuerui" <kernel@xen0n.name>,
linux-snps-arc@lists.infradead.org,
"David S . Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 4/6] fbdev: Include <linux/io.h> via <asm/fb.h>
Date: Wed, 03 May 2023 10:52:34 +0200 [thread overview]
Message-ID: <0ecbc92c-7e42-4958-988b-abc265f039bf@app.fastmail.com> (raw)
In-Reply-To: <97bbdb2f-6245-caf2-c0f6-d628873bd6db@suse.de>
On Wed, May 3, 2023, at 10:12, Thomas Zimmermann wrote:
> Am 03.05.23 um 09:19 schrieb Javier Martinez Canillas:
>> Thomas Zimmermann <tzimmermann@suse.de> writes:
>>>>
>>>> There are countless examples where the above are not followed,
>>>> but to my best understanding the above it the preferred way to do it.
>>>
>>> Where did youher this? I only know about this in the case of asm/io.h
>>> vs. linux/io.h.
>>>
>>
>> I understand that's the case too. I believe even checkpatch.pl complains
>> about it? (not that the script always get right, but just as an example).
>
> Do you know if that's the general rule? If so, we might want to
> repurpose <asm/fbio.h> for the framebuffer I/O functions.
It's certainly the general trend across all of the kernel to have
drivers prefer including linux/*.h, and to move stuff from asm/*.h
to linux/*.h as it gets generalized across architectures.
Arnd
next prev parent reply other threads:[~2023-05-03 8:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 13:02 [PATCH v3 0/6] fbdev: Move framebuffer I/O helpers to <asm/fb.h> Thomas Zimmermann
2023-05-02 13:02 ` [PATCH v3 1/6] fbdev/matrox: Remove trailing whitespaces Thomas Zimmermann
2023-05-02 13:02 ` [PATCH v3 2/6] ipu-v3: Include <linux/io.h> Thomas Zimmermann
2023-05-02 13:02 ` [PATCH v3 3/6] fbdev: Include <linux/io.h> in various drivers Thomas Zimmermann
2023-05-02 13:02 ` [PATCH v3 4/6] fbdev: Include <linux/io.h> via <asm/fb.h> Thomas Zimmermann
2023-05-02 19:54 ` Sam Ravnborg
2023-05-03 7:09 ` Thomas Zimmermann
2023-05-03 7:19 ` Javier Martinez Canillas
2023-05-03 8:09 ` Geert Uytterhoeven
2023-05-03 8:12 ` Thomas Zimmermann
2023-05-03 8:52 ` Arnd Bergmann [this message]
2023-05-02 13:02 ` [PATCH v3 5/6] fbdev: Move framebuffer I/O helpers into <asm/fb.h> Thomas Zimmermann
2023-05-02 20:03 ` Sam Ravnborg
2023-05-03 6:58 ` Thomas Zimmermann
2023-05-03 19:03 ` Sam Ravnborg
2023-05-02 20:06 ` Arnd Bergmann
2023-05-03 14:55 ` Thomas Zimmermann
2023-05-03 15:06 ` Arnd Bergmann
2023-05-02 13:02 ` [PATCH v3 6/6] fbdev: Rename fb_mem*() helpers Thomas Zimmermann
2023-05-02 20:08 ` Sam Ravnborg
2023-05-03 8:15 ` Thomas Zimmermann
2023-05-03 19:06 ` Sam Ravnborg
2023-05-03 8:21 ` [PATCH v3 0/6] fbdev: Move framebuffer I/O helpers to <asm/fb.h> Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ecbc92c-7e42-4958-988b-abc265f039bf@app.fastmail.com \
--to=arnd@arndb.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=chenhuacai@kernel.org \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=javierm@redhat.com \
--cc=kernel@xen0n.name \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=loongarch@lists.linux.dev \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
--cc=tzimmermann@suse.de \
--cc=vgupta@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox