From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH] drop superfluous .align 16 Date: Sun, 24 Aug 2008 13:57:38 -0500 Message-ID: <1219604258.4550.3.camel@localhost.localdomain> References: <200808242026.06295.deller@gmx.de> <200808242051.12202.deller@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Cc: linux-parisc , Kyle McMartin To: Helge Deller Return-path: In-Reply-To: <200808242051.12202.deller@gmx.de> List-ID: List-Id: linux-parisc.vger.kernel.org On Sun, 2008-08-24 at 20:51 +0200, Helge Deller wrote: > This .align 16 is misplaced and should be in front of the ENTRY(lws_lock_start). > Works because of pure luck since we have a .align PAGE_SIZE before it instead. > > Signed-off-by: Helge Deller > > diff --git a/arch/parisc/kernel/syscall.S b/arch/parisc/kernel/syscall.S > index 69b6eeb..c6ff81f 100644 > --- a/arch/parisc/kernel/syscall.S > +++ b/arch/parisc/kernel/syscall.S > @@ -640,7 +640,6 @@ END(sys_call_table64) > .align PAGE_SIZE > ENTRY(lws_lock_start) > /* lws locks */ > - .align 16 > .rept 16 > /* Keep locks aligned at 16-bytes */ > .word 1 I think I'd really rather keep this. It may be technically superfluous because of the .align PAGE_SIZE above it, but that belongs to the syscall table. If anyone ever moved this section in head.S, the align 16 ensures nothing goes wrong. James