From: Harvey Harrison <harvey.harrison@gmail.com>
To: Kyle McMartin <kyle@infradead.org>
Cc: Kyle McMartin <kyle@mcmartin.ca>, linux-parisc@vger.kernel.org
Subject: Re: parisc: fix io accessors for generic byteorder.h
Date: Sun, 07 Dec 2008 22:09:55 -0800 [thread overview]
Message-ID: <1228716595.5998.3.camel@brick> (raw)
In-Reply-To: <20081208045829.GF9092@bombadil.infradead.org>
On Sun, 2008-12-07 at 23:58 -0500, Kyle McMartin wrote:
> On Sun, Dec 07, 2008 at 08:55:59PM -0800, Harvey Harrison wrote:
> > On Sun, 2008-12-07 at 23:43 -0500, Kyle McMartin wrote:
> > > These were using __fswabX which is marooned in <linux/byteorder/swab.h>
> > > instead we'll just use the __arch_swabX defines from <asm/byteorder.h>
> > >
> >
> > Sorry I missed this usage :-/
> >
> > Any reason not to just use __swab16 __swab32 __swab64? I'd like to keep
> > the __arch helpers confined to swab.h only.
> >
>
> Not particularly, I believe the idea of using fswabX was to Make Damned
> Sure(tm) that gcc wouldn't eliminate the expression by being too smart
> for its own good. It's probably fine now, though I have half a mind to
> just fold it in.
By fold it in, I take it to mean, write them as static inlines rather
than macros, if so, I definitely approve.
Harvey
prev parent reply other threads:[~2008-12-08 6:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 4:43 parisc: fix io accessors for generic byteorder.h Kyle McMartin
2008-12-08 4:55 ` Harvey Harrison
2008-12-08 4:58 ` Kyle McMartin
2008-12-08 6:09 ` Harvey Harrison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228716595.5998.3.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=kyle@infradead.org \
--cc=kyle@mcmartin.ca \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox