From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Kyle McMartin <kyle@infradead.org>
Cc: Helge Deller <deller@gmx.de>, Parisc List <linux-parisc@vger.kernel.org>
Subject: Re: [PATCH] remove klist iterators
Date: Tue, 13 Jan 2009 15:21:11 -0600 [thread overview]
Message-ID: <1231881671.21012.2.camel@localhost.localdomain> (raw)
In-Reply-To: <20090113205816.GC25103@bombadil.infradead.org>
On Tue, 2009-01-13 at 15:58 -0500, Kyle McMartin wrote:
> On Tue, Jan 13, 2009 at 09:54:15PM +0100, Helge Deller wrote:
> > James Bottomley wrote:
> > > commit 11c3b5c3e08f4d855cbef52883c266b9ab9df879
> > > Author: Greg Kroah-Hartman <gregkh@suse.de>
> > > Date: Tue Dec 16 12:24:56 2008 -0800
> > >
> > > driver core: move klist_children into private structure
> > >
> > > Broke our parisc build pretty badly because we touch the klists directly
> > > in three cases (AGP, SBA and GSC). Although GregKH will revert this
> > > patch, there's no reason we should be using the iterators directly, we
> > > can just move to the standard device_for_each_child() API.
> > >
> > > Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
> >
> > I just tested this patch on my 715/64 and c3000 with 2.6.29-rc1. Everything OK.
> >
> > Tested-by: Helge Deller <deller@gmx.de>
> >
>
> Thanks. Applied.
So you think I'd send an untested and uncompiled patch to the list? ...
Hey, I strongly resemble that allegation!
The quicksilver AGP will need testing on a c8000 system, I think.
James
next prev parent reply other threads:[~2009-01-13 21:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-10 0:57 [PATCH] remove klist iterators James Bottomley
2009-01-13 20:54 ` Helge Deller
2009-01-13 20:58 ` Kyle McMartin
2009-01-13 21:21 ` James Bottomley [this message]
2009-01-13 21:35 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231881671.21012.2.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=deller@gmx.de \
--cc=kyle@infradead.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox