From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Grant Grundler <grundler@parisc-linux.org>,
kyle@mcmartin.ca, akpm@linux-foundation.org,
linux-parisc@vger.kernel.org
Subject: Re: [PATCH] parisc: convert /proc/pdc/{lcd,led} to seq_file
Date: Sat, 28 Nov 2009 08:45:08 -0600 [thread overview]
Message-ID: <1259419508.4081.2.camel@mulgrave.site> (raw)
In-Reply-To: <20091128092509.GA4375@x200.malnet.ru>
On Sat, 2009-11-28 at 12:25 +0300, Alexey Dobriyan wrote:
> On Fri, Nov 27, 2009 at 11:13:54PM -0700, Grant Grundler wrote:
> > On Fri, Nov 27, 2009 at 09:51:12AM +0300, Alexey Dobriyan wrote:
> > > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> >
> > No commit comment?
>
> No, subject says it's all.
He means rationale ... the output of the files you are altering is fixed
size and atomic, so we don't need seq_file for fear of running off the
fixed buffer and the data is reasonably fast changing, so anyone looking
to seek within the file because they can't read the data in one go isn't
going to get sensible results. Given that, why bother with the
conversion?
James
next prev parent reply other threads:[~2009-11-28 14:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-27 6:51 [PATCH] parisc: convert /proc/pdc/{lcd,led} to seq_file Alexey Dobriyan
2009-11-28 6:13 ` Grant Grundler
2009-11-28 9:25 ` Alexey Dobriyan
2009-11-28 14:45 ` James Bottomley [this message]
2009-11-29 5:17 ` Grant Grundler
2009-12-01 22:07 ` Andrew Morton
2009-12-05 0:39 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259419508.4081.2.camel@mulgrave.site \
--to=james.bottomley@hansenpartnership.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=grundler@parisc-linux.org \
--cc=kyle@mcmartin.ca \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).