From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Meelis Roos <mroos@linux.ee>
Cc: linux-parisc@vger.kernel.org
Subject: Re: [PARISC] fix pacache .size with new binutils
Date: Mon, 21 Mar 2011 15:31:53 -0500 [thread overview]
Message-ID: <1300739513.10634.39.camel@mulgrave.site> (raw)
In-Reply-To: <alpine.SOC.1.00.1103212212040.27981@math.ut.ee>
On Mon, 2011-03-21 at 22:18 +0200, Meelis Roos wrote:
> Currently, 2.6.38 compile fails on parisc64 because binutils complains
> that .size expression does not evaluate to a constant. The problem is
> confusion between flush_alias_page and flush_user_dcache_range_asm.
>
> This patch fixes pacache.s compilation by adding ENDPROC to flush_alias
> page and ENTRY and correct ENDPROC to flush_user_dcache_range_asm.
>
> Signed-off-by: Meelis Roos <mroos@linux.ee>
>
> diff --git a/arch/parisc/kernel/pacache.S b/arch/parisc/kernel/pacache.S
> index 09b77b2..f3d7da6 100644
> --- a/arch/parisc/kernel/pacache.S
> +++ b/arch/parisc/kernel/pacache.S
> @@ -842,11 +842,10 @@ ENTRY(flush_alias_page)
> .exit
>
> .procend
> +ENDPROC(flush_alias_page)
> #endif
>
> - .export flush_user_dcache_range_asm
> -
> -flush_user_dcache_range_asm:
> +ENTRY(flush_user_dcache_range_asm)
> .proc
> .callinfo NO_CALLS
> .entry
> @@ -865,7 +864,7 @@ flush_user_dcache_range_asm:
> .exit
>
> .procend
> -ENDPROC(flush_alias_page)
> +ENDPROC(flush_user_dcache_range_asm)
>
> ENTRY(flush_kernel_dcache_range_asm)
> .proc
This won't apply because of upstream changes to the file
(flush_alias_page got removed) ... does the problem even still exist
upstream?
James
next prev parent reply other threads:[~2011-03-21 20:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 20:18 [PARISC] fix pacache .size with new binutils Meelis Roos
2011-03-21 20:31 ` James Bottomley [this message]
2011-03-21 20:47 ` Meelis Roos
2011-03-21 20:49 ` Meelis Roos
2011-03-21 20:51 ` James Bottomley
2011-03-22 1:21 ` John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300739513.10634.39.camel@mulgrave.site \
--to=james.bottomley@hansenpartnership.com \
--cc=linux-parisc@vger.kernel.org \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox