Re: [PATCH] parisc: unbreak automounter support on 64-bit kernel with 32-bit userspace

Rolf Eike Beer
2013-01-31T21:00:48Z

[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]

James Bottomley wrote:
> [adding autofs list and maintainer for their perusal and ack, although
> this is an obvious fix to me
>
> James]
>
> On Thu, 2013-01-31 at 21:01 +0100, Helge Deller wrote:
> > Similiar to other 64 bit Linux targets autofs_wqt_t needs to be of type
> > int
> > which has a size of 32 bits on 32- and 64-bit parisc kernels.
> >
> > Signed-off-by: Helge Deller <deller@gmx.de>
> >
> > diff --git a/include/uapi/linux/auto_fs.h b/include/uapi/linux/auto_fs.h
> > index 77cdba9..d551754 100644
> > --- a/include/uapi/linux/auto_fs.h
> > +++ b/include/uapi/linux/auto_fs.h
> > @@ -43,7 +43,7 @@
> >
> > */
> >
> > #if defined(__sparc__) || defined(__mips__) || defined(__x86_64__) \
> >
> > - || defined(__powerpc__) || defined(__s390__)
> > + || defined(__powerpc__) || defined(__s390__) || defined(__hppa__)
> >
> > typedef unsigned int autofs_wqt_t;
> > #else
> > typedef unsigned long autofs_wqt_t;

Wouldn't it make sense to make it an unsigned int on all platforms? This
wouldn't make any difference on 32 bit platforms and would prevent that to
happen on the next 32-on-64 bit platform again.

Eike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]