From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Helge Deller <deller@gmx.de>
Cc: linux-parisc@vger.kernel.org, John David Anglin <dave.anglin@bell.net>
Subject: Re: [PATCH] parisc: increase kernel stack size to 32k
Date: Wed, 24 Apr 2013 13:41:15 -0700 [thread overview]
Message-ID: <1366836075.1971.22.camel@dabdike> (raw)
In-Reply-To: <51778ADE.4010906@gmx.de>
On Wed, 2013-04-24 at 09:33 +0200, Helge Deller wrote:
> On 04/23/2013 10:22 PM, Helge Deller wrote:
> > commit e4e1e78facf7565cada909a69c7fb6415b6e7b83
> > Author: Helge Deller <deller@gmx.de>
> > Date: Tue Apr 23 17:19:37 2013 +0200
> >
> > parisc: increase kernel stack size to 32k
> >
> > --- a/arch/parisc/include/asm/thread_info.h
> > +++ b/arch/parisc/include/asm/thread_info.h
> > -#define THREAD_SIZE_ORDER 2
> > +#define THREAD_SIZE_ORDER 3 /* 32k stack */
>
> I tested again, and it actually needs to be 64k stacks to not crash any longer.
> So, the right temporary fix is:
>
> > +#define THREAD_SIZE_ORDER 4 /* 64k stack */
>
> Will send updated patch soon.
This is an indicator of something seriously wrong somewhere. We've
always had the 16k stack just because of our large frames. In theory,
the IRQ stack should only be the same size as the kernel stack, so if we
have both in the same place, we should only need at max 32k ... if we're
still seeing problems related to stack overrun, then it might be we have
an IRQ recursion where we shouldn't have. To be honest, I have a hard
time explaining why our stacks should be over 8k.
James
next prev parent reply other threads:[~2013-04-24 20:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 20:22 [PATCH] parisc: increase kernel stack size to 32k Helge Deller
2013-04-24 7:33 ` Helge Deller
2013-04-24 20:41 ` James Bottomley [this message]
2013-04-26 22:30 ` Helge Deller
2013-04-27 21:53 ` Helge Deller
2013-04-27 23:09 ` John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366836075.1971.22.camel@dabdike \
--to=james.bottomley@hansenpartnership.com \
--cc=dave.anglin@bell.net \
--cc=deller@gmx.de \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox