Linux PARISC architecture development
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: <trivial@kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-parisc@vger.kernel.org>
Subject: Re: [PATCH 14/22] parisc: %pF is only for function pointers
Date: Thu, 12 Mar 2015 11:14:29 -0500	[thread overview]
Message-ID: <1426176869.30327.113.camel@freescale.com> (raw)
In-Reply-To: <1426162282.2146.77.camel@HansenPartnership.com>

On Thu, 2015-03-12 at 08:11 -0400, James Bottomley wrote:
> On Wed, 2015-03-11 at 22:13 -0500, Scott Wood wrote:
> > Use %pS for actual addresses, otherwise you'll get bad output
> > on arches like ppc64 where %pF expects a function descriptor.  Even on
> > other architectures, refrain from setting a bad example that people
> > copy.
> 
> Are you sure about this?  Parisc64 is a function description
> architecture.  There may be a misunderstanding about what
> __builtin_return_address(0) is supposed to return, but I'm certain the
> person who added the code thought it returned a function pointer, which
> on parisc64 would be a descriptor.

I wasn't aware that parisc64 used descriptors, but I don't see how you'd
get one out of __builtin_return_address(0) since it's not usually a
function entry point (plus, GCC documents it as returning void *).

-Scott

  parent reply	other threads:[~2015-03-12 16:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1426130037-17956-1-git-send-email-scottwood@freescale.com>
2015-03-12  3:13 ` [PATCH 14/22] parisc: %pF is only for function pointers Scott Wood
2015-03-12 12:11   ` James Bottomley
2015-03-12 14:43     ` John David Anglin
2015-03-12 16:14     ` Scott Wood [this message]
2015-03-12 18:04       ` James Bottomley
2015-03-12 19:48         ` Aaro Koskinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426176869.30327.113.camel@freescale.com \
    --to=scottwood@freescale.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox