* [PATCH] ipmi_si: fix crash on parisc
@ 2017-12-06 9:25 Mikulas Patocka
2017-12-06 10:59 ` Rolf Eike Beer
2017-12-06 13:19 ` Corey Minyard
0 siblings, 2 replies; 4+ messages in thread
From: Mikulas Patocka @ 2017-12-06 9:25 UTC (permalink / raw)
To: Corey Minyard; +Cc: openipmi-developer, linux-parisc
This patch fixes ipmi crash on parisc introduced in the kernel 4.15-rc.
The pointer io.io_setup is not initialized and thus it causes crash in
try_smi_init when attempting to call new_smi->io.io_setup.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
---
drivers/char/ipmi/ipmi_si_parisc.c | 2 ++
1 file changed, 2 insertions(+)
Index: linux-4.15-rc2/drivers/char/ipmi/ipmi_si_parisc.c
===================================================================
--- linux-4.15-rc2.orig/drivers/char/ipmi/ipmi_si_parisc.c 2017-12-06 01:19:49.000000000 +0100
+++ linux-4.15-rc2/drivers/char/ipmi/ipmi_si_parisc.c 2017-12-06 06:40:12.000000000 +0100
@@ -10,6 +10,8 @@ static int __init ipmi_parisc_probe(stru
{
struct si_sm_io io;
+ memset(&io, 0, sizeof(io));
+
io.si_type = SI_KCS;
io.addr_source = SI_DEVICETREE;
io.addr_type = IPMI_MEM_ADDR_SPACE;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ipmi_si: fix crash on parisc
2017-12-06 9:25 [PATCH] ipmi_si: fix crash on parisc Mikulas Patocka
@ 2017-12-06 10:59 ` Rolf Eike Beer
2017-12-06 16:08 ` Mikulas Patocka
2017-12-06 13:19 ` Corey Minyard
1 sibling, 1 reply; 4+ messages in thread
From: Rolf Eike Beer @ 2017-12-06 10:59 UTC (permalink / raw)
To: Mikulas Patocka; +Cc: Corey Minyard, openipmi-developer, linux-parisc
Mikulas Patocka wrote:
> This patch fixes ipmi crash on parisc introduced in the kernel 4.15-rc.
> The pointer io.io_setup is not initialized and thus it causes crash in
> try_smi_init when attempting to call new_smi->io.io_setup.
>
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
>
> ---
> drivers/char/ipmi/ipmi_si_parisc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> Index: linux-4.15-rc2/drivers/char/ipmi/ipmi_si_parisc.c
> ===================================================================
> --- linux-4.15-rc2.orig/drivers/char/ipmi/ipmi_si_parisc.c 2017-12-06
> 01:19:49.000000000 +0100
> +++ linux-4.15-rc2/drivers/char/ipmi/ipmi_si_parisc.c 2017-12-06
> 06:40:12.000000000 +0100
> @@ -10,6 +10,8 @@ static int __init ipmi_parisc_probe(stru
> {
> struct si_sm_io io;
>
> + memset(&io, 0, sizeof(io));
> +
> io.si_type = SI_KCS;
> io.addr_source = SI_DEVICETREE;
> io.addr_type = IPMI_MEM_ADDR_SPACE;
Can't this be a C99 initializer for the whole struct? AFAIK this would
set all remaining members to 0 anyway.
Eike
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ipmi_si: fix crash on parisc
2017-12-06 10:59 ` Rolf Eike Beer
@ 2017-12-06 16:08 ` Mikulas Patocka
0 siblings, 0 replies; 4+ messages in thread
From: Mikulas Patocka @ 2017-12-06 16:08 UTC (permalink / raw)
To: Rolf Eike Beer; +Cc: Corey Minyard, openipmi-developer, linux-parisc
On Wed, 6 Dec 2017, Rolf Eike Beer wrote:
> Mikulas Patocka wrote:
> > This patch fixes ipmi crash on parisc introduced in the kernel 4.15-rc.
> > The pointer io.io_setup is not initialized and thus it causes crash in
> > try_smi_init when attempting to call new_smi->io.io_setup.
> >
> > Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
> >
> > ---
> > drivers/char/ipmi/ipmi_si_parisc.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > Index: linux-4.15-rc2/drivers/char/ipmi/ipmi_si_parisc.c
> > ===================================================================
> > --- linux-4.15-rc2.orig/drivers/char/ipmi/ipmi_si_parisc.c 2017-12-06
> > 01:19:49.000000000 +0100
> > +++ linux-4.15-rc2/drivers/char/ipmi/ipmi_si_parisc.c 2017-12-06
> > 06:40:12.000000000 +0100
> > @@ -10,6 +10,8 @@ static int __init ipmi_parisc_probe(stru
> > {
> > struct si_sm_io io;
> >
> > + memset(&io, 0, sizeof(io));
> > +
> > io.si_type = SI_KCS;
> > io.addr_source = SI_DEVICETREE;
> > io.addr_type = IPMI_MEM_ADDR_SPACE;
>
> Can't this be a C99 initializer for the whole struct? AFAIK this would set all
> remaining members to 0 anyway.
>
> Eike
It can - but all the other functions that call ipmi_si_add_smi also use
memset.
Mikulas
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ipmi_si: fix crash on parisc
2017-12-06 9:25 [PATCH] ipmi_si: fix crash on parisc Mikulas Patocka
2017-12-06 10:59 ` Rolf Eike Beer
@ 2017-12-06 13:19 ` Corey Minyard
1 sibling, 0 replies; 4+ messages in thread
From: Corey Minyard @ 2017-12-06 13:19 UTC (permalink / raw)
To: Mikulas Patocka; +Cc: openipmi-developer, linux-parisc
On 12/06/2017 03:25 AM, Mikulas Patocka wrote:
> This patch fixes ipmi crash on parisc introduced in the kernel 4.15-rc.
> The pointer io.io_setup is not initialized and thus it causes crash in
> try_smi_init when attempting to call new_smi->io.io_setup.
Thanks, I'll get this in for 4.15.
-corey
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
>
> ---
> drivers/char/ipmi/ipmi_si_parisc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> Index: linux-4.15-rc2/drivers/char/ipmi/ipmi_si_parisc.c
> ===================================================================
> --- linux-4.15-rc2.orig/drivers/char/ipmi/ipmi_si_parisc.c 2017-12-06 01:19:49.000000000 +0100
> +++ linux-4.15-rc2/drivers/char/ipmi/ipmi_si_parisc.c 2017-12-06 06:40:12.000000000 +0100
> @@ -10,6 +10,8 @@ static int __init ipmi_parisc_probe(stru
> {
> struct si_sm_io io;
>
> + memset(&io, 0, sizeof(io));
> +
> io.si_type = SI_KCS;
> io.addr_source = SI_DEVICETREE;
> io.addr_type = IPMI_MEM_ADDR_SPACE;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-06 16:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-06 9:25 [PATCH] ipmi_si: fix crash on parisc Mikulas Patocka
2017-12-06 10:59 ` Rolf Eike Beer
2017-12-06 16:08 ` Mikulas Patocka
2017-12-06 13:19 ` Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).