From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "Leonardo Brás" <leobras.c@gmail.com>, lkcamp@lists.libreplanetbr.org
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Finn Thain <fthain@telegraphics.com.au>,
Robert Richter <rric@kernel.org>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
Helge Deller <deller@gmx.de>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
oprofile-list@lists.sf.net, linux-parisc@vger.kernel.org,
linux-s390@vger.kernel.org
Subject: Re: [PATCH v3 3/7] drivers: parisc: Avoids building driver if CONFIG_PARISC is disabled
Date: Fri, 28 Sep 2018 09:15:15 +0200 [thread overview]
Message-ID: <1538118915.3593.4.camel@HansenPartnership.com> (raw)
In-Reply-To: <20180928020816.11251-4-leobras.c@gmail.com>
On Thu, 2018-09-27 at 23:08 -0300, Leonardo Brás wrote:
> Avoids building driver if 'make drivers/parisc/' is called and
> CONFIG_PARISC is disabled.
Is that really a problem? The drivers/Makefile has this:
obj-$(CONFIG_PARISC) += parisc/
And you just overrode that by forcing the build. It's not even clear
we should refuse the build in that case; how would we know you don't
have a legitimate reason for the override?
Signed-off-by: Leonardo Brás <leobras.c@gmail.com>
> ---
> drivers/parisc/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/parisc/Makefile b/drivers/parisc/Makefile
> index 3cd5e6cb8478..80049d763aa0 100644
> --- a/drivers/parisc/Makefile
> +++ b/drivers/parisc/Makefile
> @@ -24,5 +24,5 @@ obj-$(CONFIG_EISA) += eisa.o
> eisa_enumerator.o eisa_eeprom.o
> obj-$(CONFIG_SUPERIO) += superio.o
> obj-$(CONFIG_CHASSIS_LCD_LED) += led.o
> obj-$(CONFIG_PDC_STABLE) += pdc_stable.o
> -obj-y += power.o
> +obj-$(CONFIG_PARISC) += power.o
If we conclude the use case is legitimate, that's not enough: the two
inner symbols are PARISC only but CONFIG_EISA isn't.
James
next prev parent reply other threads:[~2018-09-28 7:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 2:08 [PATCH v3 0/7] Remove errors building drivers/DRIVERNAME Leonardo Brás
2018-09-28 2:08 ` [PATCH v3 1/7] drivers: dio: Avoids building driver if CONFIG_DIO is disabled Leonardo Brás
2018-09-28 2:08 ` [PATCH v3 2/7] drivers: nubus: Avoids building driver if CONFIG_NUBUS " Leonardo Brás
2018-09-28 2:08 ` [PATCH v3 3/7] drivers: parisc: Avoids building driver if CONFIG_PARISC " Leonardo Brás
2018-09-28 7:15 ` James Bottomley [this message]
2018-10-04 0:31 ` Leonardo Bras
2018-10-04 4:41 ` James Bottomley
2018-10-05 2:16 ` Leonardo Bras
2018-10-05 4:10 ` Finn Thain
2018-10-06 4:28 ` Michael Schmitz
2018-10-10 1:01 ` Leonardo Bras
2018-09-28 2:08 ` [PATCH v3 4/7] drivers: zorro: Avoids building proc.o if CONFIG_ZORRO " Leonardo Brás
2018-09-28 2:08 ` [PATCH v3 5/7] drivers: s390: Avoids building drivers if ARCH is not s390 Leonardo Brás
2018-10-01 12:46 ` Heiko Carstens
2018-10-04 1:00 ` Leonardo Bras
2018-09-28 2:08 ` [PATCH v3 6/7] drivers: oprofile: Avoids building driver from direct make command Leonardo Brás
2018-09-28 2:08 ` [PATCH v3 7/7] drivers: hwtracing: Adds Makefile to enable building from directory Leonardo Brás
2018-10-01 7:56 ` [PATCH v3 0/7] Remove errors building drivers/DRIVERNAME Robert Richter
2018-10-03 15:46 ` Leonardo Bras
2018-10-03 23:27 ` Finn Thain
2018-10-04 1:37 ` Leonardo Bras
2018-10-04 2:00 ` Finn Thain
2018-10-10 1:04 ` Leonardo Bras
-- strict thread matches above, loose matches on Subject: below --
2018-09-28 1:48 [PATCH v3 3/7] drivers: parisc: Avoids building driver if CONFIG_PARISC is disabled Leonardo Brás
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1538118915.3593.4.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=deller@gmx.de \
--cc=fthain@telegraphics.com.au \
--cc=geert@linux-m68k.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jejb@parisc-linux.org \
--cc=leobras.c@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lkcamp@lists.libreplanetbr.org \
--cc=oprofile-list@lists.sf.net \
--cc=rric@kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox