From: Paul Moore <paul@paul-moore.com>
To: libseccomp@googlegroups.com
Cc: Helge Deller <deller@gmx.de>,
linux-parisc@vger.kernel.org,
James Bottomley <James.Bottomley@hansenpartnership.com>,
John David Anglin <dave.anglin@bell.net>,
Mike Frysinger <vapier@gentoo.org>
Subject: Re: [PATCH] libseccomp/tests: Report if test was skipped because of missing valgrind
Date: Mon, 18 Apr 2016 18:37:28 -0400 [thread overview]
Message-ID: <1765217.3d9ZDVQ0iE@sifl> (raw)
In-Reply-To: <20160415150941.GA11180@ls3530.dhcp.wdf.sap.corp>
On Friday, April 15, 2016 05:09:41 PM Helge Deller wrote:
> Print a message if a regression test was skipped just because valgrind isn't
> installed.
>
> This additional info is useful for architectures (e.g. parisc) which aren't
> as fast as x86_64. On parisc it seemed that the whole testcase was hanging,
> now people know what's actually happening.
>
> Signed-off-by: Helge Deller <deller@gmx.de>
Merged, thanks!
> diff --git a/tests/regression b/tests/regression
> index 53d26b2..5949459 100755
> --- a/tests/regression
> +++ b/tests/regression
> @@ -772,6 +773,7 @@ function run_test() {
> if check_deps valgrind; then
> run_test_bpf_valgrind "$testnumstr" "$3"
> else
> + print_result $testnumstr "SKIPPED" "(valgrind not installed)"
> stats_skipped=$(($stats_skipped+1))
> fi
> elif [[ "$4" == "live" ]]; then
--
paul moore
www.paul-moore.com
--
You received this message because you are subscribed to the Google Groups "libseccomp" group.
To unsubscribe from this group and stop receiving emails from it, send an email to libseccomp+unsubscribe@googlegroups.com.
To post to this group, send email to libseccomp@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2016-04-18 22:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160213200731.GA18161@ls3530.box>
[not found] ` <3673666.V2ZqGazvLY@sifl>
[not found] ` <56C24911.8000200@gmx.de>
[not found] ` <1907254.cBdVSxntFv@sifl>
2016-04-09 7:05 ` [PATCH] libseccomp: Add parisc architecture support (v2) Helge Deller
2016-04-14 23:14 ` Paul Moore
2016-04-15 15:07 ` Helge Deller
2016-04-15 15:09 ` [PATCH] libseccomp/tests: Report if test was skipped because of missing valgrind Helge Deller
2016-04-18 22:37 ` Paul Moore [this message]
2016-04-15 15:11 ` [PATCH] libseccomp: Add parisc architecture support (v3) Helge Deller
2016-04-30 20:51 ` Helge Deller
2016-05-24 19:09 ` Paul Moore
2016-05-25 14:53 ` Re: [PATCH] libseccomp: Add parisc architecture support (v4) Helge Deller
2016-05-25 19:49 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1765217.3d9ZDVQ0iE@sifl \
--to=paul@paul-moore.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dave.anglin@bell.net \
--cc=deller@gmx.de \
--cc=libseccomp@googlegroups.com \
--cc=linux-parisc@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox