From: Rolf Eike Beer <eike@sf-mail.de>
To: linux-parisc List <linux-parisc@vger.kernel.org>
Subject: [PATCH 2/2] HIL: remove one goto
Date: Mon, 16 Jan 2012 20:13:42 +0100 [thread overview]
Message-ID: <1907306.0Ne3j968CE@eto> (raw)
In-Reply-To: <6637509.yTD8q5zPsI@eto>
>From 71de9e0407870c980e57335a5bc555f24d90683b Mon Sep 17 00:00:00 2001
From: Rolf Eike Beer <eike-kernel@sf-tec.de>
Date: Mon, 16 Jan 2012 19:44:01 +0100
Subject: [PATCH 2/2] HIL: remove one goto
This goto is only used to skip the next instruction, which can easily be done
without a goto.
Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
---
drivers/input/serio/hil_mlc.c | 11 +++++------
1 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/input/serio/hil_mlc.c b/drivers/input/serio/hil_mlc.c
index bfd3865..0280167 100644
--- a/drivers/input/serio/hil_mlc.c
+++ b/drivers/input/serio/hil_mlc.c
@@ -686,13 +686,12 @@ static int hilse_donode(hil_mlc *mlc)
write_lock_irqsave(&mlc->lock, flags);
pack = node->object.packet;
out:
- if (mlc->istarted)
- goto out2;
- /* Prepare to receive input */
- if ((node + 1)->act & HILSE_IN)
- hilse_setup_input(mlc, node + 1);
+ if (!mlc->istarted) {
+ /* Prepare to receive input */
+ if ((node + 1)->act & HILSE_IN)
+ hilse_setup_input(mlc, node + 1);
+ }
- out2:
write_unlock_irqrestore(&mlc->lock, flags);
if (down_trylock(&mlc->osem)) {
--
1.7.7
next prev parent reply other threads:[~2012-01-16 19:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 19:12 [PATCH 0/2] Random PARISC patches Rolf Eike Beer
2012-01-16 19:13 ` [PATCH 1/2] parisc: fix compile without CONFIG_PCI Rolf Eike Beer
2012-01-30 10:13 ` Rolf Eike Beer
2012-01-16 19:13 ` Rolf Eike Beer [this message]
2012-01-16 19:38 ` [PATCH 2/2] HIL: remove one goto John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1907306.0Ne3j968CE@eto \
--to=eike@sf-mail.de \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).