From: Grant Grundler <grundler@cup.hp.com>
To: Parisc Linux <parisc-linux@thepuffingroup.com>
Subject: Re: [parisc-linux] Missing directories from CVS
Date: Thu, 23 Sep 1999 09:59:42 -0700 [thread overview]
Message-ID: <199909231659.JAA29335@milano.cup.hp.com> (raw)
In-Reply-To: Your message of "Thu, 23 Sep 1999 08:30:21 PDT." <199909231530.IAA29217@milano.cup.hp.com>
Grant Grundler wrote:
...
> I did a checkout, make config (for 715), make dep.
> (make vmlinux is still running)
vmlinux built shortly after I posted...
> gcc is used to build scripts/mkdep, scripts/split-include and bin2hex.
Add one more to the list: arch/parisc/boot/mkImage
And on this one "cc" gets picky about pointer math.
Here's my diff for mkImage.c:
118c118
< *entry_point = *(unsigned long*)(ptr + 6*sizeof(long));
---
> *entry_point = *(unsigned long*)((char *)ptr + 6*sizeof(long));
131,132c131,132
< short magic = *(short *)(ptr+sizeof(short));
< long *arr = (unsigned long *)ptr;
---
> short magic = *(short *)((char *)ptr+sizeof(short));
> long *arr = (long *)ptr;
Any objections to committing this change?
On second thought, both changes should be written as:
*entry_point = ((unsigned long *)ptr)[6];
and
short magic = ((short *)ptr)[1];
thanks,
grant
next prev parent reply other threads:[~1999-09-23 16:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-09-23 3:13 [parisc-linux] Missing directories from CVS Ryan Bradetich
1999-09-23 15:30 ` Grant Grundler
1999-09-23 16:59 ` Grant Grundler [this message]
1999-09-23 18:58 ` LaMont Jones
1999-09-24 8:13 ` Helge Deller
1999-09-24 14:44 ` LaMont Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199909231659.JAA29335@milano.cup.hp.com \
--to=grundler@cup.hp.com \
--cc=parisc-linux@thepuffingroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox