Linux PARISC architecture development
 help / color / mirror / Atom feed
From: Richard Hirst <rhirst@linuxcare.com>
To: Andries Brouwer <aeb@cwi.nl>
Cc: parisc-linux@thepuffingroup.com, util-linux@math.uio.no
Subject: [parisc-linux] Bug in more
Date: Thu, 11 Jan 2001 22:09:17 +0000	[thread overview]
Message-ID: <20010111220917.J18838@linuxcare.com> (raw)

Hi,
  I have found a bug in 'more', util-linux-2.10r source.
At startup tailequ() is called to match the last component of argv[0]
against "page".  tailequ() is broken because it accesses one location
below the start of argv[0].  This causes a crash on parisc, where the
stack grows upwards and argv[0] is the first element on the stack.

Richard

--- util-linux-2.10r/text-utils/more.c-	Thu Jan 11 15:00:59 2001
+++ util-linux-2.10r/text-utils/more.c	Thu Jan 11 15:02:52 2001
@@ -815,8 +815,8 @@
 	register char *tail;
 
 	tail = path + strlen(path);
-	while (tail >= path)
-		if (*(--tail) == '/')
+	while (--tail >= path)
+		if (*tail == '/')
 			break;
 	++tail;
 	while (*tail++ == *string++)

                 reply	other threads:[~2001-01-11 22:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010111220917.J18838@linuxcare.com \
    --to=rhirst@linuxcare.com \
    --cc=aeb@cwi.nl \
    --cc=parisc-linux@thepuffingroup.com \
    --cc=util-linux@math.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox