From: Matthew Wilcox <matthew@wil.cx>
To: Ryan Bradetich <rbradetich@uswest.net>
Cc: parisc-linux@thepuffingroup.com
Subject: Re: [parisc-linux] RFC: I/O tree design
Date: Sat, 3 Feb 2001 17:57:51 +0000 [thread overview]
Message-ID: <20010203175751.C12985@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <3A7BB0A0.D478911A@uswest.net>; from rbradetich@uswest.net on Sat, Feb 03, 2001 at 12:17:52AM -0700
On Sat, Feb 03, 2001 at 12:17:52AM -0700, Ryan Bradetich wrote:
> Currently all the "discovered" I/O devices are stored in a
> fixed size array which contains up to 64 devices. This fixed
> size array has already been established and is known to work,
> so this proposal does not attempt to replace the fixed size
> array, but instead uses indexes within the struct hp_device
> to create the logical I/O tree.
I think you need to be braver. Kill the fixed size array. kmalloc each
struct and use pointers to reference between them. If you want, you
can use the doubly-linked-list macros in <linux/list.h>, but i suspect
self-managed singly-linked-lists will be more appropriate for this.
After all, it's not like the tree gets modified on a regular basis.
> Child: This index is only set to a valid node if the
> current node is the Central bus, a Bus Converter, or
> a Bus adapter. When this index is set to a valid node,
> it points to the head of the sibling list containing all
> valid nodes for the given bus.
One advantage of doing this is that `Child' could be a pointer to a
PCI bus.
> This proposal also calls for a special "root" node at
And you don't ned a root node, just siblings.
--
Revolutions do not require corporate support.
next prev parent reply other threads:[~2001-02-03 17:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-03 7:17 [parisc-linux] RFC: I/O tree design Ryan Bradetich
2001-02-03 17:57 ` Matthew Wilcox [this message]
2001-02-05 4:04 ` Ryan Bradetich
2001-02-05 18:34 ` Grant Grundler
2001-02-06 6:02 ` Matthew Wilcox
2001-02-06 7:10 ` Grant Grundler
2001-02-06 8:07 ` Grant Grundler
2001-02-05 18:22 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010203175751.C12985@parcelfarce.linux.theplanet.co.uk \
--to=matthew@wil.cx \
--cc=parisc-linux@thepuffingroup.com \
--cc=rbradetich@uswest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox