From: Matthew Wilcox <matthew@wil.cx>
To: Bjorn Helgaas <bjorn_helgaas@hp.com>
Cc: rbradetich@uswest.net, Ryan Bradetich <rbrad@beavis.ybsoft.com>,
parisc-linux@lists.parisc-linux.org
Subject: Re: [parisc-linux] [PATCH] PDC cleanup and encapsulation
Date: Wed, 4 Apr 2001 18:20:16 +0100 [thread overview]
Message-ID: <20010404182016.D11435@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <0104041057250C.19560@eeyore.fc.hp.com>; from bjorn_helgaas@hp.com on Wed, Apr 04, 2001 at 09:57:25AM -0700
On Wed, Apr 04, 2001 at 09:57:25AM -0700, Bjorn Helgaas wrote:
> - What are the guidelines for #ifdef __LP64__ vs CONFIG_PA20? You
> replaced __LP64__ with CONFIG_PA20 in some places but not others and I'm
> not clear on the difference.
Not all PA-2.0 processors are run in 64-bit mode. For example, a C3000
can be run in either 32 or 64 bit mode. At compile-time you can choose
to optimise for a particular processor (and risk it not working on
other machines).
> - In firmware.c, the "yes 'int', not 'long' -- IODC I/O is always 32-bit
> stuff" comment moved from pdc.h seems obsolete, or at least, I can't
> figure out what the 'int' refers to. I'd remove the "This means Cxxx
> boxes can't run wide kernels right now." comment, since CONFIG_PDC_NARROW
> addresses that issue.
yup, some of the comments are definitely stale.
see linus' comments about disliking comments because of this issue :-)
--
Revolutions do not require corporate support.
next prev parent reply other threads:[~2001-04-04 17:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-04 0:03 [parisc-linux] [PATCH] PDC cleanup and encapsulation Ryan Bradetich
2001-04-04 16:57 ` Bjorn Helgaas
2001-04-04 17:20 ` Matthew Wilcox [this message]
2001-04-04 23:04 ` Bjorn Helgaas
2001-04-05 0:01 ` Matthew Wilcox
2001-04-09 21:47 ` Grant Grundler
2001-04-05 2:14 ` Ryan Bradetich
-- strict thread matches above, loose matches on Subject: below --
2001-03-29 8:18 Ryan Bradetich
2001-03-29 17:48 ` Paul Bame
2001-03-29 22:05 ` Ryan Bradetich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010404182016.D11435@parcelfarce.linux.theplanet.co.uk \
--to=matthew@wil.cx \
--cc=bjorn_helgaas@hp.com \
--cc=parisc-linux@lists.parisc-linux.org \
--cc=rbrad@beavis.ybsoft.com \
--cc=rbradetich@uswest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox