From: Grant Grundler <grundler@puffin.external.hp.com>
To: Matthew Wilcox <willy@debian.org>
Cc: parisc-linux@parisc-linux.org
Subject: Re: [parisc-linux] pdc_add_valid
Date: Fri, 05 Oct 2001 18:26:58 -0600 [thread overview]
Message-ID: <200110060026.SAA05769@puffin.external.hp.com> (raw)
In-Reply-To: Message from Matthew Wilcox <willy@debian.org> of "Fri, 05 Oct 2001 17:22:22 BST." <20011005172222.D19206@parcelfarce.linux.theplanet.co.uk>
Matthew Wilcox wrote:
>
> The pdc_add_valid function really annoys me.
So you want a sane wrapper around it.
> For the moment, I've put it in <asm/io.h>, since it is for I/O addresses.
>
> +int valid_io_addr(unsigned long addr)
> +{
> + return (pdc_add_valid(addr) == PDC_OK);
> +}
I prefer asm/io.h not depend on pdc.h.
Why not just add whatever wrapper to pdc.h?
> But maybe we should replace pdc_add_valid with valid_io_addr?
> Or a different function? Suggestions appreciated.
sorry - no better ideas.
grant
prev parent reply other threads:[~2001-10-06 0:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-05 16:22 [parisc-linux] pdc_add_valid Matthew Wilcox
2001-10-05 21:58 ` Stan Sieler
2001-10-05 23:24 ` Matthew Wilcox
2001-10-06 0:26 ` Grant Grundler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200110060026.SAA05769@puffin.external.hp.com \
--to=grundler@puffin.external.hp.com \
--cc=parisc-linux@parisc-linux.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox