From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pizda.ninka.net (pizda.ninka.net [216.101.162.242]) by dsl2.external.hp.com (Postfix) with ESMTP id 148026120 for ; Fri, 16 Nov 2001 09:58:13 -0700 (MST) Date: Fri, 16 Nov 2001 08:57:54 -0800 (PST) Message-Id: <20011116.085754.00483458.davem@redhat.com> To: grundler@puffin.external.hp.com Cc: willy@debian.org, linux-mm@kvack.org, parisc-linux@lists.parisc-linux.org Subject: Re: [parisc-linux] Re: parisc scatterlist doesn't want page/offset From: "David S. Miller" In-Reply-To: <200111161632.JAA25977@puffin.external.hp.com> References: <200111161632.JAA25977@puffin.external.hp.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Sender: parisc-linux-admin@lists.parisc-linux.org Errors-To: parisc-linux-admin@lists.parisc-linux.org List-Help: List-Post: List-Subscribe: , List-Id: parisc-linux developers list List-Unsubscribe: , List-Archive: From: Grant Grundler Date: Fri, 16 Nov 2001 09:32:52 -0700 > I suggest you do this now, it is totally painless. I would almost > classify it as a mindless edit. Adding two members to a struct is not the problem. The problem is revisiting every usage of ->address in the DMA code and telling driver writers they should be using page+offset. Note the "should", nobody forces them to use page+offset in a driver and 2.4.x will NEVER require it. They just won't be able to DMA highmem pages, that's all. The DMA code is so simple to fix ("mindless edit" is still how I classify it) and you have _THREE_ (count them, 3) platform IOMMU code patch examples to work with (alpha, sparc64, ia64). Franks a lot, David S. Miller davem@redhat.com