Re: [parisc-linux] mem_pdc_call: how using it exactly.

[Grant Grundler <grundler@dsl2.external.hp.com>]

Bruno Vidal wrote:
> About the iodc_data_size, in the documentation it is describe as: "count byte
>   s in length".

Yes.  Gecko ERS says ARG6 is "size of memaddr in bytes".

> For example in drivers/scsi/zalon7xx.c:
> status = pdc_iodc_read(&pdc_result, hpa, 0, &iodc_data, 32 ); 
> -> it is 32.
> So If I want the 32 first bytes, it should be 32.

        status = pdc_iodc_read(&pdc_result, hpa, 0, &iodc_data, 32 );
	if (status == PDC_RET_OK) {
		clock = (int) pdc_result[16];
	} else {
	....

This looks wrong.  pdc_result[16] probably contains garbage.

> Now why doing it myself, because I don't want to use spinlock while
> dumping, and pdc_iodc_read use spinlock. Perhaps, it is not a good
> solution, what do you think about using spinlock while dumping ?

I would rather see the dump code avoid the spinlock and
replicate the pdc calls. ie assume PDC calls can crash the
system too. But if this is a PITA, re-initialize the lock and use the
regular calls.

grant