From: grundler@dsl2.external.hp.com (Grant Grundler)
To: paulus@samba.org
Cc: parisc-linux@lists.parisc-linux.org
Subject: [parisc-linux] [PATCH] 2.4.19 ppp_generic.c warning fixed
Date: Fri, 13 Sep 2002 00:00:49 -0600 (MDT) [thread overview]
Message-ID: <20020913060049.8A4974829@dsl2.external.hp.com> (raw)
Paul,
Wearing my other hat (parisc-linux), I've a fix for "used before
initialized" warning in ppp_generic.c.
The ret value might want to be something other than zero in
the "if (skb) break;" condition.
thanks,
grant
Index: drivers/net/ppp_generic.c
===================================================================
RCS file: /var/cvs/linux/drivers/net/ppp_generic.c,v
retrieving revision 1.11
diff -u -p -r1.11 ppp_generic.c
--- drivers/net/ppp_generic.c 4 Aug 2002 22:58:31 -0000 1.11
+++ drivers/net/ppp_generic.c 13 Sep 2002 05:57:15 -0000
@@ -387,9 +387,9 @@ static ssize_t ppp_read(struct file *fil
for (;;) {
set_current_state(TASK_INTERRUPTIBLE);
skb = skb_dequeue(&pf->rq);
+ ret = 0;
if (skb)
break;
- ret = 0;
if (pf->dead)
break;
ret = -EAGAIN;
reply other threads:[~2002-09-13 6:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020913060049.8A4974829@dsl2.external.hp.com \
--to=grundler@dsl2.external.hp.com \
--cc=parisc-linux@lists.parisc-linux.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox