From: Randolph Chung <randolph@tausq.org>
To: Ryan Bradetich <rbradetich@uswest.net>
Cc: parisc-linux@lists.parisc-linux.org
Subject: Re: [parisc-linux] Broken Cache Flushing in arch/parisc/kernel/signal.c.??
Date: Tue, 12 Nov 2002 23:52:34 -0800 [thread overview]
Message-ID: <20021113075234.GF8261@tausq.org> (raw)
In-Reply-To: <1037173492.9031.7.camel@beavis>
> +#if CACHE_FLUSHING_IS_NOT_BROKEN
> flush_icache_range((unsigned long) &frame->tramp[0],
> (unsigned long) &frame->tramp[4]);
> +#else
> + /* It should *always* be cache line-aligned, but the compiler
> + sometimes screws up. */
> + asm volatile("fdc 0(%%sr3,%0)\n\t"
> + "fdc %1(%%sr3,%0)\n\t"
> + "sync\n\t"
> + "fic 0(%%sr3,%0)\n\t"
> + "fic %1(%%sr3,%0)\n\t"
> + "sync\n\t"
> + : : "r" (frame->tramp), "r" (L1_CACHE_BYTES));
> +#endif
> +
<sigh>
this is partly my fault, since i thought we have unbroken cache flushing
and asked thibaut to check this in... now i see that the original code
flushes sr3 space, but flush_icache_range() flushes the kernel space...
oops!
perhaps we should just check the old code back in for now?
randolph
--
Randolph Chung
Debian GNU/Linux Developer, hppa/ia64 ports
http://www.tausq.org/
next prev parent reply other threads:[~2002-11-13 7:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-13 7:44 [parisc-linux] Broken Cache Flushing in arch/parisc/kernel/signal.c.?? Ryan Bradetich
2002-11-13 7:52 ` Randolph Chung [this message]
2002-11-13 12:28 ` Matthew Wilcox
2002-11-13 19:27 ` Thibaut VARENE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021113075234.GF8261@tausq.org \
--to=randolph@tausq.org \
--cc=parisc-linux@lists.parisc-linux.org \
--cc=rbradetich@uswest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox