From: willy@dsl2.external.hp.com (Matthew Wilcox)
To: parisc-linux@parisc-linux.org
Subject: [parisc-linux] Revert sr_hashing changes
Date: Sun, 9 Feb 2003 09:00:59 -0700 [thread overview]
Message-ID: <20030209160059.GA17385@dsl2.external.hp.com> (raw)
I've also taken the opportunity to do a little misc cleanup.
Just checking it compiles, then I'll commit.
Index: arch/parisc/kernel/processor.c
===================================================================
RCS file: /var/cvs/linux/arch/parisc/kernel/processor.c,v
retrieving revision 1.16
diff -u -p -r1.16 processor.c
--- arch/parisc/kernel/processor.c 8 Feb 2003 22:22:42 -0000 1.16
+++ arch/parisc/kernel/processor.c 9 Feb 2003 13:30:50 -0000
@@ -273,7 +273,6 @@ int __init init_per_cpu(int cpunum)
{
int ret;
struct pdc_coproc_cfg coproc_cfg;
- extern void disable_sr_hashing(void); /* from cache.c */
ret = pdc_coproc_cfg(&coproc_cfg);
@@ -310,8 +309,6 @@ int __init init_per_cpu(int cpunum)
/* FUTURE: Enable Performance Monitor : ccr bit 0x20 */
init_percpu_prof(cpunum);
-
- disable_sr_hashing();
return ret;
}
Index: arch/parisc/kernel/cache.c
===================================================================
RCS file: /var/cvs/linux/arch/parisc/kernel/cache.c,v
retrieving revision 1.23
diff -u -p -r1.23 cache.c
--- arch/parisc/kernel/cache.c 8 Feb 2003 22:22:42 -0000 1.23
+++ arch/parisc/kernel/cache.c 9 Feb 2003 13:30:50 -0000
@@ -194,33 +194,30 @@ cache_init(void)
void disable_sr_hashing(void)
{
- int srhash_type;
+ int srhash_type;
- if (boot_cpu_data.cpu_type == pcxl2)
- return; /* pcxl2 doesn't support space register hashing */
+ switch (boot_cpu_data.cpu_type) {
+ case pcx: /* We shouldn't get this far. setup.c should prevent it. */
+ BUG();
+ return;
+
+ case pcxs:
+ case pcxt:
+ case pcxt_:
+ srhash_type = SRHASH_PCXST;
+ break;
+
+ case pcxl:
+ srhash_type = SRHASH_PCXL;
+ break;
+
+ case pcxl2: /* pcxl2 doesn't support space register hashing */
+ return;
+
+ default: /* Currently all PA2.0 machines use the same ins. sequence */
+ srhash_type = SRHASH_PA20;
+ break;
+ }
- switch (boot_cpu_data.cpu_type) {
-
- case pcx:
- BUG(); /* We shouldn't get here. code in setup.c should prevent it */
- return;
-
- case pcxs:
- case pcxt:
- case pcxt_:
- srhash_type = SRHASH_PCXST;
- break;
-
- case pcxl:
- srhash_type = SRHASH_PCXL;
- break;
-
- default: /* Currently all PA2.0 machines use the same ins. sequence */
- srhash_type = SRHASH_PA20;
- break;
- }
-
- disable_sr_hashing_asm(srhash_type);
-
- mb();
+ disable_sr_hashing_asm(srhash_type);
}
Index: arch/parisc/kernel/smp.c
===================================================================
RCS file: /var/cvs/linux/arch/parisc/kernel/smp.c,v
retrieving revision 1.21
diff -u -p -r1.21 smp.c
--- arch/parisc/kernel/smp.c 8 Feb 2003 22:22:42 -0000 1.21
+++ arch/parisc/kernel/smp.c 9 Feb 2003 13:30:50 -0000
@@ -33,6 +33,7 @@
#include <linux/kernel_stat.h>
#include <linux/mm.h>
#include <linux/delay.h>
+#include <linux/reboot.h>
#include <asm/system.h>
#include <asm/atomic.h>
@@ -434,21 +435,21 @@ smp_cpu_init(int cpunum)
extern void init_IRQ(void); /* arch/parisc/kernel/irq.c */
/* Set modes and Enable floating point coprocessor */
- (void) init_per_cpu(cpunum);
+ init_per_cpu(cpunum);
- /* Well, support 2.4 linux scheme as well. */
- if (test_and_set_bit(cpunum, (unsigned long *) (&cpu_online_map)))
- {
- extern void machine_halt(void); /* arch/parisc.../process.c */
+ disable_sr_hashing();
+ mb();
+ /* Well, support 2.4 linux scheme as well. */
+ if (test_and_set_bit(cpunum, (unsigned long *) (&cpu_online_map))) {
printk(KERN_CRIT "CPU#%d already initialized!\n", cpunum);
machine_halt();
- }
+ }
/* Initialise the idle task for this CPU */
atomic_inc(&init_mm.mm_count);
current->active_mm = &init_mm;
- if(current->mm)
+ if (current->mm)
BUG();
enter_lazy_tlb(&init_mm, current, cpunum);
reply other threads:[~2003-02-09 16:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030209160059.GA17385@dsl2.external.hp.com \
--to=willy@dsl2.external.hp.com \
--cc=parisc-linux@parisc-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox