From: Matthew Wilcox <willy@debian.org>
To: Matthew Wilcox <willy@debian.org>,
binutils@sources.redhat.com, parisc-linux@parisc-linux.org
Subject: [parisc-linux] Re: [PATCH] space register 0 changes for hppa
Date: Mon, 24 Feb 2003 12:48:55 +0000 [thread overview]
Message-ID: <20030224124855.G2938@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20030224062421.GA31111@bubble.sa.bigpond.net.au>; from amodra@bigpond.net.au on Mon, Feb 24, 2003 at 04:54:21PM +1030
On Mon, Feb 24, 2003 at 04:54:21PM +1030, Alan Modra wrote:
> ChangeLog entries shouldn't be sent as diffs. Write this one as
>
> * hppa-dis.c (print_insn_hppa <2 bit space register>): Do not print
> the space register when the value is zero.
>
> and put the reason for the change as a comment in the code if you feel
> you need some justification for the change.
OK. I'm just used to changelogs which're a little more verbose. I
don't think it really needs justifying.
> Did you run the binutils testsuite?
I hadn't... but I have now, and it doesn't introduce any failures.
--
"It's not Hollywood. War is real, war is primarily not about defeat or
victory, it is about death. I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk
next prev parent reply other threads:[~2003-02-24 12:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-23 18:58 [parisc-linux] [PATCH] space register 0 changes for hppa Matthew Wilcox
2003-02-24 6:24 ` [parisc-linux] " Alan Modra
2003-02-24 6:24 ` Alan Modra
2003-02-24 12:48 ` Matthew Wilcox
2003-02-24 12:48 ` Matthew Wilcox [this message]
2003-02-24 15:01 ` law
2003-02-24 14:59 ` Matthew Wilcox
2003-02-24 14:59 ` Matthew Wilcox
2003-02-24 16:16 ` law
2003-02-24 16:16 ` law
2003-02-24 18:23 ` Matthew Wilcox
2003-02-24 18:39 ` law
2003-02-24 18:39 ` law
2003-02-24 18:42 ` Matthew Wilcox
2003-02-24 18:47 ` Daniel Jacobowitz
2003-02-24 18:47 ` Daniel Jacobowitz
2003-02-24 21:49 ` Andrew Cagney
2003-02-24 21:57 ` Matthew Wilcox
2003-02-24 21:57 ` Matthew Wilcox
2003-02-24 22:11 ` Andrew Cagney
2003-02-24 22:11 ` Andrew Cagney
2003-02-24 22:19 ` Matthew Wilcox
2003-02-25 0:21 ` Alan Modra
2003-02-25 0:21 ` Alan Modra
2003-02-24 22:19 ` Matthew Wilcox
2003-02-24 21:49 ` Andrew Cagney
2003-02-24 18:42 ` Matthew Wilcox
2003-02-24 18:23 ` Matthew Wilcox
2003-02-24 15:01 ` law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030224124855.G2938@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=binutils@sources.redhat.com \
--cc=parisc-linux@parisc-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox