From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pippin.tausq.org (gandalf.tausq.org [64.81.244.94]) by dsl2.external.hp.com (Postfix) with ESMTP id 61A384829 for ; Tue, 6 May 2003 09:11:23 -0600 (MDT) Date: Tue, 6 May 2003 08:08:27 -0700 From: Randolph Chung To: Joel Soete Cc: Jan-Benedict Glaw , parisc-linux@lists.parisc-linux.org Subject: Re: [parisc-linux] Oops on 2.4.20-pa33 Message-ID: <20030506150827.GA23465@tausq.org> Reply-To: Randolph Chung References: <20030506140425.GF18309@tausq.org> <3EB7766A00000308@ocpmta7.freegates.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <3EB7766A00000308@ocpmta7.freegates.net> Sender: parisc-linux-admin@lists.parisc-linux.org Errors-To: parisc-linux-admin@lists.parisc-linux.org List-Help: List-Post: List-Subscribe: , List-Id: parisc-linux developers list List-Unsubscribe: , List-Archive: > That is ok for me (even if I don't understand very well :( ; afaik the previous > code works fine for gcc<=3.1 and do not seems to concern 64bits? ) The point is that if the new code is always correct, then littering the code with #ifdef's makes the code hard to read and maintain. If you really need to make the code different for the two cases, it's better to conditionally define a function/macro in a single place (header file) and use that in the source, rather than having ifdef's in many places. HTH, randolph -- Randolph Chung Debian GNU/Linux Developer, hppa/ia64 ports http://www.tausq.org/