From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from caramon.arm.linux.org.uk (caramon.arm.linux.org.uk [212.18.232.186]) by dsl2.external.hp.com (Postfix) with ESMTP id 4F13848D4 for ; Fri, 22 Aug 2003 10:42:13 -0600 (MDT) Received: from flint.arm.linux.org.uk ([2002:d412:e8ba:1:201:2ff:fe14:8fad]) by caramon.arm.linux.org.uk with asmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.22) id 19qEzE-0003H3-9i; Fri, 22 Aug 2003 17:42:04 +0100 Received: from rmk by flint.arm.linux.org.uk with local (Exim 4.22) id 19qEzD-0006Xi-BX; Fri, 22 Aug 2003 17:42:03 +0100 Date: Fri, 22 Aug 2003 17:42:03 +0100 From: Russell King To: Matthew Wilcox Cc: "David S. Miller" , James Bottomley , linux-kernel@vger.kernel.org, parisc-linux@lists.parisc-linux.org, drepper@redhat.com Subject: Re: [parisc-linux] Re: Problems with kernel mmap (failing tst-mmap-eofsync in glibc on parisc) Message-ID: <20030822174203.H12903@flint.arm.linux.org.uk> References: <1061563239.2090.25.camel@mulgrave> <20030822091447.6ecea6ca.davem@redhat.com> <20030822163429.GH18834@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20030822163429.GH18834@parcelfarce.linux.theplanet.co.uk>; from willy@debian.org on Fri, Aug 22, 2003 at 05:34:29PM +0100 Sender: parisc-linux-admin@lists.parisc-linux.org Errors-To: parisc-linux-admin@lists.parisc-linux.org List-Help: List-Post: List-Subscribe: , List-Id: parisc-linux developers list List-Unsubscribe: , List-Archive: On Fri, Aug 22, 2003 at 05:34:29PM +0100, Matthew Wilcox wrote: > On Fri, Aug 22, 2003 at 09:14:47AM -0700, David S. Miller wrote: > > On 22 Aug 2003 09:40:37 -0500 > > James Bottomley wrote: > > > The reason this doesn't happen is because the mapping is not on the > > > mmap_shared list that flush_dcache_page() updates. > > > > flush_dcache_page() checks both the shared and non-shared mmap lists, > > so if it is on _either_ list it is flushed. It does not check only > > the shared list. Eww. > Gah, that's going to get really inefficient. I still think we want to > split flush_dcache_page() into two operations -- flush_dcache_user() and > flush_dcache_kernel(). flush_dcache_user() would flush this specific > user mapping back to ram and flush_dcache_kernel() would flush the > kernel mapping. Where are you proposing calling only _user() and _kernel() from ? -- Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux http://www.arm.linux.org.uk/personal/aboutme.html