From: Carlos O'Donell <carlos@baldric.uwo.ca>
To: Ulrich Drepper <drepper@redhat.com>
Cc: libc-alpha <libc-alpha@sources.redhat.com>,
parisc-linux@lists.parisc-linux.org
Subject: [parisc-linux] Re: [PATCH] Sysdeps changes for hppa.
Date: Wed, 15 Oct 2003 10:35:59 -0400 [thread overview]
Message-ID: <20031015143558.GG22495@systemhalted> (raw)
In-Reply-To: <3F8CDFD6.1010300@redhat.com>
Ulrich,
> I've applied this patch, but only because I really don't care how the PA
> port looks.
I didn't think the patch was too ugly, but then again a father thinks
all his children are beautiful.
> The semtimedop definition is completely wrong. If you want all
> syscall,s use appropriate headers.
Moot point. We know why it's there, because changes don't propagate
everywhere as fast as we'd like.
> You've modified the patch by hand and broke it, forcing me to do clean up.
Unforgivable. Please reject patches immediately if this happens again.
I will produce a correct patch.
> The coding style is completely wrong and a terrible mess. The coding
> standard document is available, read it.
Suggestions accepted. I will reread the document.
> The preprocessor directive indentation is wrong or non-existing.
Never non-existent. Incorrect yes.
Cheers,
Carlos.
next prev parent reply other threads:[~2003-10-15 14:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-12 21:32 [parisc-linux] [PATCH] Sysdeps changes for hppa Carlos O'Donell
2003-10-15 5:49 ` [parisc-linux] " Ulrich Drepper
2003-10-15 5:49 ` Ulrich Drepper
2003-10-15 14:35 ` Carlos O'Donell
2003-10-15 14:35 ` Carlos O'Donell [this message]
2003-10-18 20:47 ` Carlos O'Donell
2003-10-18 20:47 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031015143558.GG22495@systemhalted \
--to=carlos@baldric.uwo.ca \
--cc=drepper@redhat.com \
--cc=libc-alpha@sources.redhat.com \
--cc=parisc-linux@lists.parisc-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox